Hard to read Brush strength in Blender Light theme #71491

New Issue

Jun Mizutani · 2019-11-11T16:14:41+01:00

Jun Mizutani commented

2019-11-11 16:14:41 +01:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.60

Blender Version
Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-11 09:09, hash: 19c44ae087
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]
It is hard to read the brush strength in sculpt-mode with Blender Light theme.
When you set the Text Info ON in Viewport Overlays, the brush strength value will be drawn with white color.
When you set the Text Info OFF, the value will be drawn with black.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

New with Sculpting.
Change to Blender Light theme.
Set Text Info OFF in Viewport Overlays.
Hit Shift - F.

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.60 **Blender Version** Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-11 09:09, hash: `19c44ae087` Worked: (optional) **Short description of error** [Please fill out a short description of the error here] It is hard to read the brush strength in sculpt-mode with Blender Light theme. When you set the Text Info ON in Viewport Overlays, the brush strength value will be drawn with white color. When you set the Text Info OFF, the value will be drawn with black. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] 1. New with Sculpting. 2. Change to Blender Light theme. 3. Set Text Info OFF in Viewport Overlays. 4. Hit Shift - F. ![normal.png](https://archive.blender.org/developer/F8033482/normal.png) ![lightmode.png](https://archive.blender.org/developer/F8033505/lightmode.png)

Jun Mizutani commented

2019-11-11 16:14:41 +01:00

Added subscriber: @jmztn

Germano Cavalcante commented

2019-11-12 21:08:11 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2019-11-12 21:08:11 +01:00

The text color should not depend on the option Text info.
This is probably due to some unset gpu state.

The text color should not depend on the option `Text info`. This is probably due to some unset gpu state.

Pablo Dobarro was assigned by Germano Cavalcante

2019-11-12 21:51:23 +01:00

Germano Cavalcante commented

2019-11-12 21:51:23 +01:00

Added subscriber: @PabloDobarro

Germano Cavalcante commented

2019-11-12 21:51:23 +01:00

@PabloDobarro, you have worked in this area before.
One suggestion is to set the text color to the same color as the circle line:

diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
index 43bf5039825..c8c43991918 100644
--- a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -2320,6 +2320,7 @@ static void radial_control_paint_cursor(bContext *UNUSED(C), int x, int y, void
   immUnbindProgram();
 
   BLF_size(fontid, 1.75f * fstyle_points * U.pixelsize, U.dpi);
+  BLF_color3fv_alpha(fontid, col, 1.0f);
 
   /* draw value */
   BLF_width_and_height(fontid, str, strdrawlen, &strwidth, &strheight);

@PabloDobarro, you have worked in this area before. One suggestion is to set the text color to the same color as the circle line: ``` diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c index 43bf5039825..c8c43991918 100644 --- a/source/blender/windowmanager/intern/wm_operators.c +++ b/source/blender/windowmanager/intern/wm_operators.c @@ -2320,6 +2320,7 @@ static void radial_control_paint_cursor(bContext *UNUSED(C), int x, int y, void immUnbindProgram(); BLF_size(fontid, 1.75f * fstyle_points * U.pixelsize, U.dpi); + BLF_color3fv_alpha(fontid, col, 1.0f); /* draw value */ BLF_width_and_height(fontid, str, strdrawlen, &strwidth, &strheight); ```

Pablo Dobarro was unassigned by Dalai Felinto

2019-12-23 13:44:08 +01:00

blender-admin commented

2020-01-10 12:14:03 +01:00

This issue was referenced by 9867106199

This issue was referenced by 98671061993e2d053514a4df0cce24b63645c049

Jeroen Bakker commented

2020-01-10 12:17:04 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-01-10 12:17:04 +01:00

Jeroen Bakker self-assigned this 2020-01-10 12:17:04 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Hard to read Brush strength in Blender Light theme #71491