Page MenuHome
Maniphest T71491

Hard to read Brush strength in Blender Light theme
Open, Confirmed, MediumPublic
Actions

Description

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.60

Blender Version
Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-11 09:09, hash: rB19c44ae0870b
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]
It is hard to read the brush strength in sculpt-mode with Blender Light theme.
When you set the Text Info ON in Viewport Overlays, the brush strength value will be drawn with white color.
When you set the Text Info OFF, the value will be drawn with black.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

  1. New with Sculpting.
  2. Change to Blender Light theme.
  3. Set Text Info OFF in Viewport Overlays.
  4. Hit Shift - F.

Details

Type
Bug

Event Timeline

Germano Cavalcante (mano-wii) lowered the priority of this task from Needs Triage by Developer to Confirmed, Medium.EditedTue, Nov 12, 9:08 PM
Germano Cavalcante (mano-wii) added projects: User Interface, GPU / Viewport.
Germano Cavalcante (mano-wii) added a subscriber: Germano Cavalcante (mano-wii).

The text color should not depend on the option Text info.
This is probably due to some unset gpu state.

Germano Cavalcante (mano-wii) assigned this task to Pablo Dobarro (pablodp606).Tue, Nov 12, 9:51 PM
Germano Cavalcante (mano-wii) added a subscriber: Pablo Dobarro (pablodp606).

@Pablo Dobarro (pablodp606), you have worked in this area before.
One suggestion is to set the text color to the same color as the circle line:

diff --git a/source/blender/windowmanager/intern/wm_operators.c b/source/blender/windowmanager/intern/wm_operators.c
index 43bf5039825..c8c43991918 100644
--- a/source/blender/windowmanager/intern/wm_operators.c
+++ b/source/blender/windowmanager/intern/wm_operators.c
@@ -2320,6 +2320,7 @@ static void radial_control_paint_cursor(bContext *UNUSED(C), int x, int y, void
   immUnbindProgram();
 
   BLF_size(fontid, 1.75f * fstyle_points * U.pixelsize, U.dpi);
+  BLF_color3fv_alpha(fontid, col, 1.0f);
 
   /* draw value */
   BLF_width_and_height(fontid, str, strdrawlen, &strwidth, &strheight);