Grease Pencil Collection Instance Memory Leak #71867

Closed
opened 2019-11-24 19:45:30 +01:00 by Michael Hermann · 8 comments

System Information
Operating system: Linux-5.3.12-arch1-1-x86_64-with-arch 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.36

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: 26bd5ebd42
Worked: (optional)

Short description of error
During Playback of a scene containing a Grease Pencil instance from another scene or blend-file, the memory consumption will increase steadily.
I could only reproduce this with GP Objects.GP_Memory_Leak.blend

Exact steps for others to reproduce the error
Open the attached blend-file and press PLAY. Watch system memory consumption.

**System Information** Operating system: Linux-5.3.12-arch1-1-x86_64-with-arch 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.36 **Blender Version** Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash: `26bd5ebd42` Worked: (optional) **Short description of error** During Playback of a scene containing a Grease Pencil instance from another scene or blend-file, the memory consumption will increase steadily. I could only reproduce this with GP Objects.[GP_Memory_Leak.blend](https://archive.blender.org/developer/F8162524/GP_Memory_Leak.blend) **Exact steps for others to reproduce the error** Open the attached blend-file and press PLAY. Watch system memory consumption.

Added subscriber: @MichaelHermann

Added subscriber: @MichaelHermann

Added subscribers: @Sergey, @antoniov

Added subscribers: @Sergey, @antoniov

@Sergey I have tested and the problem is the function DRW_gpencil_freecache(ob); is not called in this situation from BKE_object_free_derived_caches function. I don't know why and no idea where add this call to be sure the instances memory cache is cleared. Could you take a look?

@Sergey I have tested and the problem is the function `DRW_gpencil_freecache(ob);` is not called in this situation from `BKE_object_free_derived_caches` function. I don't know why and no idea where add this call to be sure the instances memory cache is cleared. Could you take a look?

Not sure if this bug exists in the refactored engine. I will test it.

Not sure if this bug exists in the refactored engine. I will test it.

Closed as duplicate of #66293

Closed as duplicate of #66293
Member

Added subscriber: @JulianEisel

Added subscriber: @JulianEisel
Member

So is this actually solved in the refactor? This was a big issue for some artists here, so better to double check it doesn't get lost.

So is this actually solved in the refactor? This was a big issue for some artists here, so better to double check it doesn't get lost.

I have tested the test file above in the refactored version and I'm unable to detect any memory leak. Also now, the engine does not need to call to BKE_object_free_derived_caches()function as before, so I think we can consider it as solved in refactored code.

I have tested the test file above in the refactored version and I'm unable to detect any memory leak. Also now, the engine does not need to call to `BKE_object_free_derived_caches()`function as before, so I think we can consider it as solved in refactored code.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#71867
No description provided.