GPencil: deleting interpolated frames causes crash #72020
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#72020
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: AMD Radeon HD 5700 Series ATI Technologies Inc. 4.5.13417 Core Profile Context 15.301.1901.0
Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-11-20 14:27, hash:
26bd5ebd42
I've tested 2.8 and 2.82 alpha, both crash as well
Short description of error
Deleting one of a few specific grease pencil frames created by "Interpolate Sequence" reliably crashes Blender. Deleting a shape in the frame also produces the same result.
I've had this happen once or twice before, but I never paid it much mind since it seemed random. Here's a file where it happens rather predictably, however.
Exact steps for others to reproduce the error
20191128_gp_headturn.blend
Added subscriber: @Nelfie
Added subscriber: @antoniov
I have deleted all frames from 30 to 40 and my system doesn't crash.
Do you have any log of the crash?
The kind of log produced by the following instructions?
When run normally, the console produces this error on crash:
If I run
blender.exe --debug
the console gives these errors instead...... for the most part, but a crash has also occured, giving the
ACCESS_VIOLATION
error above.One information I forgot in my initial post: I'm using a portable version of Blender, maybe that has something to do with it.
Added subscriber: @lichtwerk
@lichtwerk Can you reproduce it?
Grease Pencil: deleting interpolated frames causes crashto GPencil: deleting interpolated frames causes crashYes, can reproduce. What I did:
X
>Delete Keyframes
X
>Delete Keyframes
X
>Delete Keyframes
Doesnt seem to crash in the same places, a bit weird, maybe we should check with ASAN as well?
It is totaly reliable crash, had a couple of sessions [some of which survived without crash], but here are the backtraces of two sessions where it crashed:
@Nelfie Did you noticed if this is only for interpolated frames? never had the same issue with hand draw frames?
@lichtwerk I have seen there is a problem whith weight free memory...if you look at the console, you will see a "Couldn't unmap memory". I guess there must be an issue when interpolate frames and the weights are not created as expected (almost sure, the weights arry is not initializated propertly).
I can't tell for sure. I use interpolation a lot - and they're the frames I delete most often, in large groups, since they need to be re-done whenever I modify a key.
I'll keep track of it if the same bug occurs again and let you know. (As long as it's relevant to fixing the problem, of course)
@lichtwerk I have submitted
1321be0af9
and I think this was the reason of the error. Could you recompile and try again?Really, the problem was not in the frame delete process, but in how the interpolated sequence frames were created. The problem was when the number of points of the destination stroke were less than original stroke and the weights array had to be resized. By a mistake, it was resizing the original stroke instead of the new interpolated stroke, and this corrupted the pointers... and after that corruption, anything can fail.
@Nelfie Can you reproduce the bug with the last buildbot? You must check with anew file...the old file already damaged can fail.
I'll try as soon as possible.
I assume I should reproduce the specific situation you described in the previous comment, yes? Also, is a single file enough, or should I make multiple in case the bug is random?
@Nelfie Yes, just create a new file and try to reproduced the steps to create the bug. I hope the fix avoids the error you had in your file.
So, I tried to reproduce the bug in 2.81 first, to make sure I was going through the right steps - but I haven't managed to make the bug happen again. Here's what I did:
It doesn't cause a crash, so unless it's random, I'm missing something. Any ideas?
Try painting weights in the strokes before interpolate, but if my fix worked all must go fine.
Ah, yes, that was it, thank you! I had forgotten I had added vertex groups in the original file.
I tested the bug with a new file in 2.81, and the crash occurred as predicted. Using the same file in the latest 2.82 alpha (saved without interpolations), I went through the same steps, and no crash occurred. Same for the reverse (file made and tested in 2.82 alpha, then saved and tested in 2.81.)
So, problem fixed as far as I can tell. Good work!
Changed status from 'Open' to: 'Resolved'
Thanks @Nelfie for your testing. I'm going to close the report. If you have more problems, please, open a new report.