Smooth Vertices called from the F3 operator search will put you in a modal without knowing [doesnt execute immediately] #72069

New Issue

Jonas Printzén · 2019-11-30T19:12:29+01:00

Jonas Printzén commented

2019-11-30 19:12:29 +01:00

System Information
Operating system: Linux (Ubuntu 18.04)
Graphics card: GTX 1080TI (NV driver 440.26)

Blender Version
Broken: 2.82, (blender-2.82-7af560438966-linux-glibc217-x86_64)
Worked: 2.81 released

Short description of error
Smoothing Vertices in edit mode when called from the F3 operator search will leave you stuck in modal

Exact steps for others to reproduce the error
Simply subdivide the initial cube a few times and called the operator from the F3 operator search
You are in a modal, operator only executes after first mouse click (with unwanted results depending on mouse position)

**System Information** Operating system: Linux (Ubuntu 18.04) Graphics card: GTX 1080TI (NV driver 440.26) **Blender Version** Broken: 2.82, (blender-2.82-7af560438966-linux-glibc217-x86_64) Worked: 2.81 released **Short description of error** `Smoothing Vertices` in edit mode when called from the F3 operator search will leave you stuck in modal **Exact steps for others to reproduce the error** Simply subdivide the initial cube a few times and called the operator from the F3 operator search You are in a modal, operator only executes after first mouse click (with unwanted results depending on mouse position)

Jonas Printzén commented

2019-11-30 19:12:29 +01:00

Added subscriber: @JonasPrintzen

blender-admin commented

2019-11-30 19:12:29 +01:00

#73445 was marked as duplicate of this issue

Jonas Printzén changed title from ~~Smooting in edit mode stopped working (works in XXX)~~ to Smooth vertices in edit mode stopped working (works in 2.81)

2019-11-30 19:18:48 +01:00

Habib Gahbiche commented

2019-12-01 08:54:58 +01:00

Added subscriber: @zazizizou

Habib Gahbiche commented

2019-12-01 08:54:58 +01:00

Thanks for reporting. I can't reproduce this on macOS with today's master (last commit is f1ac64921b49eaea8658d144754a1a532198c720).

A unit test for the smoothing operator will be added soon as part of D5357

Thanks for reporting. I can't reproduce this on macOS with today's master (last commit is `f1ac64921b49eaea8658d144754a1a532198c720`). A unit test for the smoothing operator will be added soon as part of [D5357](https://archive.blender.org/developer/D5357)

Lauri Hastholm commented

2019-12-01 09:39:25 +01:00

Added subscriber: @laurijh

Lauri Hastholm commented

2019-12-01 09:39:25 +01:00

There seems to be a difference between the menus in how the tools are activated. From Vertex menu / Smooth vertices there is instant effect and the tool settings appear in the lower left corner for further adjustment. The toolbar tool requires you to first drag left or right with the mouse to modify your mesh and afterwards pops up the tool options on the viewport corner.

However, it really is confusing that only a subset of the tool options are shown in the sidebar under Tool / Active Tool. Including the Smoothing slider there would also prompt for further action from user. If sidebar or the Tool tab is not open, most of the toolbar tools show no change in the viewport when selected, even mouse cursor stays the same cross.

I see this behaviour in all 2.8x builds though.

There seems to be a difference between the menus in how the tools are activated. From Vertex menu / Smooth vertices there is instant effect and the tool settings appear in the lower left corner for further adjustment. The toolbar tool requires you to first drag left or right with the mouse to modify your mesh and afterwards pops up the tool options on the viewport corner. However, it really is confusing that only a subset of the tool options are shown in the sidebar under Tool / Active Tool. Including the Smoothing slider there would also prompt for further action from user. If sidebar or the Tool tab is not open, most of the toolbar tools show no change in the viewport when selected, even mouse cursor stays the same cross. I see this behaviour in all 2.8x builds though.

Jonas Printzén commented

2019-12-01 12:22:14 +01:00

Some new info...

I tried with new nightly (blender-2.82-f1ac64921b49-linux-glibc217-x86_64), same failure.
I then tried removing all in $HOME/.config/blender/2.82, same failure.

Then I tried setting a shortcut via menu [Vertex/Smoth vertices] , Failed with similar UI glitch, no shortcut.
Tried setting shortcut via context-menu (rightclick in edit), shortcut registers but same fail...

Then I tried the same with Smoot Laplacian, works flawlessly, including all ways to invoke and setting shortcut!

I also noticed laplacian is not present in menu [Vertex/...] or the - [x] menu.
The - [x] menu has Smooth vertices grouped with Randomize (?) and randomize fail like Smooth vertices.

/ZPU

Some new info... I tried with new nightly (blender-2.82-f1ac64921b49-linux-glibc217-x86_64), same failure. I then tried removing all in $HOME/.config/blender/2.82, same failure. Then I tried setting a shortcut via menu [Vertex/Smoth vertices] , Failed with similar UI glitch, no shortcut. Tried setting shortcut via context-menu (rightclick in edit), shortcut registers but same fail... Then I tried the same with Smoot Laplacian, works flawlessly, including all ways to invoke and setting shortcut! I also noticed laplacian is not present in menu [Vertex/...] or the - [x] menu. The - [x] menu has Smooth vertices grouped with Randomize (?) and randomize fail like Smooth vertices. /ZPU

Lauri Hastholm commented

2019-12-01 13:12:20 +01:00

Can confirm failure of setting shortcut for Smooth Vertices from Vertex menu.

Setting a shortcut from RMB menu and using it requires a mouse click or drag to bring up the tool options, where initial value tends to be 10 and subsequent mouse movement does not reduce it so the result is distortion. Interestingly, a single click of the mouse on the viewport does not actually apply the smoothing but then touching the tool options updates the mesh.

Can confirm failure of setting shortcut for Smooth Vertices from Vertex menu. Setting a shortcut from RMB menu and using it requires a mouse click or drag to bring up the tool options, where initial value tends to be 10 and subsequent mouse movement does not reduce it so the result is distortion. Interestingly, a single click of the mouse on the viewport does not actually apply the smoothing but then touching the tool options updates the mesh.

Philipp Oeser commented

2019-12-02 12:30:05 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-12-02 12:30:05 +01:00

Can confirm calling Smooth Vertices from a shortcut behaves differently from 2.81 release, will check on this further... (this somehow seems to try to call the tool and not the operator?...)

Using the toolbar [aka "the - [x] menu"] and clicking on the tool there seems to work fine here though?
(not sure I am missing something from the repro steps, please clarify the failure in the toolbar...)

And please only one issue per report, answers below, but these will be ignored from now on [unless this is really connected to the reported issue...]

If sidebar or the Tool tab is not open, most of the toolbar tools show no change in the viewport when selected, even mouse cursor stays the same cross.

Do you have the tool settings visible?

I also noticed laplacian is not present in menu [Vertex/...] or the - [x] menu.

True, but not a bug

Can confirm calling `Smooth Vertices` from a shortcut behaves differently from 2.81 release, will check on this further... (this somehow seems to try to call the tool and not the operator?...) Using the toolbar [aka "the - [x] menu"] and clicking on the tool there seems to work fine here though? (not sure I am missing something from the repro steps, please clarify the failure in the toolbar...) And please only one issue per report, answers below, but these will be ignored from now on [unless this is really connected to the reported issue...] > If sidebar or the Tool tab is not open, most of the toolbar tools show no change in the viewport when selected, even mouse cursor stays the same cross. Do you have the tool settings visible? ![image.png](https://archive.blender.org/developer/F8184889/image.png) > I also noticed laplacian is not present in menu [Vertex/...] or the - [x] menu. True, but not a bug

Philipp Oeser changed title from ~~Smooth vertices in edit mode stopped working (works in 2.81)~~ to Smooth vertices called from a shortcut behaves differently in 2.82 [compared to 2.81 release]

2019-12-02 12:31:03 +01:00

Philipp Oeser commented

2019-12-02 13:23:02 +01:00

Added subscriber: @ideasman42

Philipp Oeser commented

2019-12-02 13:23:02 +01:00

Caused by f4a4ec8425

@ideasman42 : can these still be called with EXEC_DEFAULT from a shortcut? Or properly start the modal? (seem to be stuck in the middle and waiting for the mouse click...)

Caused by f4a4ec8425 @ideasman42 : can these still be called with `EXEC_DEFAULT` from a shortcut? Or properly start the modal? (seem to be stuck in the middle and waiting for the mouse click...)

Asher commented

2019-12-22 20:53:20 +01:00

Added subscriber: @ThatAsherGuy

William Reynish commented

2020-01-22 20:02:48 +01:00

Added subscriber: @WilliamReynish

William Reynish commented

2020-01-22 20:02:48 +01:00

I cannot reproduce any issues with the Smooth tool here. Seems to work normally.

Philipp Oeser commented

2020-01-22 20:50:05 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-01-22 20:50:05 +01:00

Philipp Oeser self-assigned this 2020-01-22 20:50:05 +01:00

Philipp Oeser commented

2020-01-22 20:50:05 +01:00

I can still reproduce this with e.g. f1ac64921b.
But this is working fine in todays build.
Havent hunted down the exact commit, but looks like this was resolved along the way, closing...

@JonasPrintzen: please try a new build from https://builder.blender.org/download/
(feel free to comment again if issues persist...)

I can still reproduce this with e.g. f1ac64921b. But this is working fine in todays build. Havent hunted down the exact commit, but looks like this was resolved along the way, closing... @JonasPrintzen: please try a new build from https://builder.blender.org/download/ (feel free to comment again if issues persist...)

Asher commented

2020-01-22 22:36:42 +01:00

The core issue still exists; call the operator via operator search. If you want a superficial fix, do this:

diff --git a/source/blender/windowmanager/intern/wm_operator_utils.c b/source/blender/windowmanager/intern/wm_operator_utils.cindex 44afa708136..c9a7c6e119b 100644
--- a/source/blender/windowmanager/intern/wm_operator_utils.c
+++ b/source/blender/windowmanager/intern/wm_operator_utils.c
@@ -336,7 +336,7 @@ void WM_operator_type_modal_from_exec_for_object_edit_coords(wmOperatorType *ot)
   ot->modal = op_generic_value_modal;
   ot->cancel = op_generic_value_cancel;

-  prop = RNA_def_boolean(ot->srna, "wait_for_input", true, "Wait for Input", "");
+  prop = RNA_def_boolean(ot->srna, "wait_for_input", false, "Wait for Input", "");
   RNA_def_property_flag(prop, PROP_HIDDEN | PROP_SKIP_SAVE);
 }

For a more thorough fix you'll have call ED_workspace_status_text() in op_generic_value_invoke() and throw some info into the status bar, so users know they're in a modal, and base the adjustment amount on the initializing click location instead of where the cursor was on invoke.

The core issue still exists; call the operator via operator search. If you want a superficial fix, do this: ``` diff --git a/source/blender/windowmanager/intern/wm_operator_utils.c b/source/blender/windowmanager/intern/wm_operator_utils.cindex 44afa708136..c9a7c6e119b 100644 --- a/source/blender/windowmanager/intern/wm_operator_utils.c +++ b/source/blender/windowmanager/intern/wm_operator_utils.c @@ -336,7 +336,7 @@ void WM_operator_type_modal_from_exec_for_object_edit_coords(wmOperatorType *ot) ot->modal = op_generic_value_modal; ot->cancel = op_generic_value_cancel; - prop = RNA_def_boolean(ot->srna, "wait_for_input", true, "Wait for Input", ""); + prop = RNA_def_boolean(ot->srna, "wait_for_input", false, "Wait for Input", ""); RNA_def_property_flag(prop, PROP_HIDDEN | PROP_SKIP_SAVE); } ``` For a more thorough fix you'll have call `ED_workspace_status_text()` in `op_generic_value_invoke()` and throw some info into the status bar, so users know they're in a modal, and base the adjustment amount on the initializing click location instead of where the cursor was on invoke.

Philipp Oeser commented

2020-01-22 22:45:13 +01:00

Changed status from 'Resolved' to: 'Needs Developer To Reproduce'

Philipp Oeser reopened this issue

2020-01-22 22:45:13 +01:00

Philipp Oeser commented

2020-01-22 22:45:13 +01:00

Thx for getting back, will have a look again

Philipp Oeser commented

2020-01-24 14:08:12 +01:00

I see this was (partially) addressed in 86832ececc.
So thats why I wasnt able reproduce when calling from the menus (or thus shortcuts) because these are now calling the operator with a factor set, immediately executing.

True though that calling this from the F3 search will still leave you stuck in modal...

@ideasman42 : will lower the prio (and update the task description), but have an idea here?

I see this was (partially) addressed in 86832ececc. So thats why I wasnt able reproduce when calling from the menus (or thus shortcuts) because these are now calling the operator with a factor set, immediately executing. True though that calling this from the F3 search will still leave you stuck in modal... @ideasman42 : will lower the prio (and update the task description), but have an idea here?

Philipp Oeser changed title from ~~Smooth vertices called from a shortcut behaves differently in 2.82 [compared to 2.81 release]~~ to Smooth Vertices called from the F3 operator search will put you in a modal without knowing [doesnt execute immediately]

2020-01-24 14:13:15 +01:00

Philipp Oeser removed their assignment 2020-01-24 14:13:33 +01:00

Campbell Barton commented

2020-01-28 02:31:37 +01:00

Added subscriber: @OdinFernandezMoreno

Campbell Barton commented

2020-01-28 02:34:31 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Campbell Barton closed this issue

2020-01-28 02:34:31 +01:00

Campbell Barton self-assigned this 2020-01-28 02:34:31 +01:00

Campbell Barton commented

2020-01-28 02:34:31 +01:00

Smooth is now a modal operator, calling from operator-search gives similar behavior to inset and bevel.

If you want to access this non-modally, it can be done via the vertex menu (Ctrl-V, O for example), or you can assign this menu item to a key binding which also runs non-modally.

Closing.

Smooth is now a modal operator, calling from operator-search gives similar behavior to inset and bevel. If you want to access this non-modally, it can be done via the vertex menu (`Ctrl-V, O` for example), or you can assign this menu item to a key binding which also runs non-modally. Closing.

Asher commented

2020-01-29 15:49:00 +01:00

The issue is that, when 'wait for input' is true (as it is by default), the modal starts without updating the header or the status bar. The user doesn't know a modal has started, why viewport navigation is blocked, or what input the operator is waiting for. When they do figure it out, the modal starts with an arbitrary smooth value that's rarely useful.

Is that the intended behavior?

The issue is that, when 'wait for input' is true (as it is by default), the modal starts without updating the header or the status bar. The user doesn't know a modal has started, why viewport navigation is blocked, or what input the operator is waiting for. When they do figure it out, the modal starts with an arbitrary smooth value that's rarely useful. Is that the intended behavior?

Andrei Nadin commented

2020-01-30 01:58:02 +01:00

Added subscriber: @AnadinX

Andrei Nadin commented

2020-01-30 01:58:02 +01:00

@ideasman42 (sorry to raise this on a closed issue but I agree with @ThatAsherGuy. If you look in the attached video, (from 2.8 Beta)

bevel puts you into a state (there is a line between the cursor and the object, moving the mouse has an obvious function
inset puts you into a state (there is a line between the cursor and the object, moving the mouse has an obvious function
smooth does absolutely nothing, no change on any status bars, no in view indicator etc. You HAVE to click on the screen to make the info/interaction window even appear.

In Blender 2.79, the panel appears in the T-Panel when you invoke the operator from the search menu,

BevelInsertSmooth.mp4

PS Extude is also intuitive, your mouse movement extrudes the face, there is no extra click to enable/start the operator.

@ThatAsherGuy's point is you are put into a state where you really don't know what is going on.

If you choose Smooth from the search menu you get nothing on screen at all
If you choose Smooth from the context menu, you get the popup with the values etc. but no widget
if you choose Smooth from the tool bar you get a widget but no popup, that popup suddenly appears once you start interacting with the widget

At the very least when choosing it from the search menu the popup showing would at least let you know you are able/about to do something

@ideasman42 (sorry to raise this on a closed issue but I agree with @ThatAsherGuy. If you look in the attached video, (from 2.8 Beta) bevel puts you into a state (there is a line between the cursor and the object, moving the mouse has an obvious function inset puts you into a state (there is a line between the cursor and the object, moving the mouse has an obvious function smooth does absolutely nothing, no change on any status bars, no in view indicator etc. You HAVE to click on the screen to make the info/interaction window even appear. In Blender 2.79, the panel appears in the T-Panel when you invoke the operator from the search menu, [BevelInsertSmooth.mp4](https://archive.blender.org/developer/F8312638/BevelInsertSmooth.mp4) PS Extude is also intuitive, your mouse movement extrudes the face, there is no extra click to enable/start the operator. @ThatAsherGuy's point is you are put into a state where you really don't know what is going on. If you choose Smooth from the search menu you get nothing on screen at all If you choose Smooth from the context menu, you get the popup with the values etc. but no widget if you choose Smooth from the tool bar you get a widget but no popup, that popup suddenly appears once you start interacting with the widget At the very least when choosing it from the search menu the popup showing would at least let you know you are able/about to do something

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Smooth Vertices called from the F3 operator search will put you in a modal without knowing [doesnt execute immediately] #72069