Multiple snap targets don't work when Increment is enabled in snapping options #72094

New Issue

Stanislav Blinov · 2019-12-01T18:35:59+01:00

Stanislav Blinov commented

2019-12-01 18:35:59 +01:00

Broken: 2.81, 2.82

Short description of error
When using mixed snapping, multiple snap targets don't seem to work if Increment is one of the snapping options. The manual doesn't specify any restrictions here, so if it's by design it probably should mention that.

Exact steps for others to reproduce the error

Load the default scene.
Enable snapping, with Increment, Vertex, and Face
Try moving the Camera object and adding snap targets - they will not be added
Disable Increment in snapping options
Try moving the camera and adding snap targets - they will be added

Broken: 2.81, 2.82 **Short description of error** When using mixed snapping, multiple snap targets don't seem to work if Increment is one of the snapping options. The manual doesn't specify any restrictions here, so if it's by design it probably should mention that. **Exact steps for others to reproduce the error** 1. Load the default scene. 2. Enable snapping, with Increment, Vertex, and Face 3. Try moving the Camera object and adding snap targets - they will not be added 4. Disable Increment in snapping options 5. Try moving the camera and adding snap targets - they will be added

Stanislav Blinov commented

2019-12-01 18:35:59 +01:00

Added subscriber: @Stan_Pancakes

Anthony Edlin commented

2019-12-02 15:26:29 +01:00

Added subscriber: @AnthonyEdlin

Germano Cavalcante commented

2019-12-03 17:31:28 +01:00

Added subscribers: @ideasman42, @mano-wii

Campbell Barton was assigned by Germano Cavalcante

2019-12-03 17:31:28 +01:00

Germano Cavalcante commented

2019-12-03 17:31:28 +01:00

This limitation seems to have been intentionally added in 881cc17f.
This change would be enough.

diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
index 74fc1406795..0645f8ae4b6 100644
--- a/source/blender/editors/transform/transform.c
+++ b/source/blender/editors/transform/transform.c
@@ -855,9 +855,6 @@ static bool transform_modal_item_poll(const wmOperator *op, int value)
       if (t->spacetype != SPACE_VIEW3D) {
         return false;
       }
-      else if (t->tsnap.mode & (SCE_SNAP_MODE_INCREMENT | SCE_SNAP_MODE_GRID)) {
-        return false;
-      }
       else if (!validSnap(t)) {
         return false;
       }

@ideasman42, what do you think?

This limitation seems to have been intentionally added in 881cc17f. This change would be enough. ``` diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c index 74fc1406795..0645f8ae4b6 100644 --- a/source/blender/editors/transform/transform.c +++ b/source/blender/editors/transform/transform.c @@ -855,9 +855,6 @@ static bool transform_modal_item_poll(const wmOperator *op, int value) if (t->spacetype != SPACE_VIEW3D) { return false; } - else if (t->tsnap.mode & (SCE_SNAP_MODE_INCREMENT | SCE_SNAP_MODE_GRID)) { - return false; - } else if (!validSnap(t)) { return false; } ``` @ideasman42, what do you think?

blender-admin commented

2020-01-13 17:47:05 +01:00

This issue was referenced by 389fc62f6c

This issue was referenced by 389fc62f6c4e039902c94c3da36fd24a351c8a8d

Germano Cavalcante commented

2020-01-13 17:48:13 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Germano Cavalcante closed this issue

2020-01-13 17:48:13 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Multiple snap targets don't work when Increment is enabled in snapping options #72094