Page MenuHome

Multiple snap targets don't work when Increment is enabled in snapping options
Open, Needs Triage by DeveloperPublic

Description

Broken: 2.81, 2.82

Short description of error
When using mixed snapping, multiple snap targets don't seem to work if Increment is one of the snapping options. The manual doesn't specify any restrictions here, so if it's by design it probably should mention that.

Exact steps for others to reproduce the error

  1. Load the default scene.
  2. Enable snapping, with Increment, Vertex, and Face
  3. Try moving the Camera object and adding snap targets - they will not be added
  4. Disable Increment in snapping options
  5. Try moving the camera and adding snap targets - they will be added

Details

Type
Bug

Event Timeline

This limitation seems to have been intentionally added in rB881cc17f.
This change would be enough.

diff --git a/source/blender/editors/transform/transform.c b/source/blender/editors/transform/transform.c
index 74fc1406795..0645f8ae4b6 100644
--- a/source/blender/editors/transform/transform.c
+++ b/source/blender/editors/transform/transform.c
@@ -855,9 +855,6 @@ static bool transform_modal_item_poll(const wmOperator *op, int value)
       if (t->spacetype != SPACE_VIEW3D) {
         return false;
       }
-      else if (t->tsnap.mode & (SCE_SNAP_MODE_INCREMENT | SCE_SNAP_MODE_GRID)) {
-        return false;
-      }
       else if (!validSnap(t)) {
         return false;
       }

@Campbell Barton (campbellbarton), what do you think?