File explorer - box select selects more files than intended #72351

Open
opened 2019-12-11 12:14:51 +01:00 by Vas · 15 comments

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.28

Blender Version
Broken: version: 2.82 (sub 4), branch: master, commit date: 2019-12-10 23:56, hash: 63d521432e
Worked: (optional)

Short description of error
If you use box select tool, with view set to thumbnails, extra elements are selected from a bottom row (as demonstrated in video)
2019-12-11 11-07-46.mp4
Exact steps for others to reproduce the error

  • open File browser
  • Set icons to Thumbnails mode
  • go to any folder that has an incomplete bottom row
  • attempt make a box selection with mouse starting on bottom empty area
  • notice that unintended extra files were selected
**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.28 **Blender Version** Broken: version: 2.82 (sub 4), branch: master, commit date: 2019-12-10 23:56, hash: `63d521432e` Worked: (optional) **Short description of error** If you use box select tool, with view set to thumbnails, extra elements are selected from a bottom row (as demonstrated in video) [2019-12-11 11-07-46.mp4](https://archive.blender.org/developer/F8208744/2019-12-11_11-07-46.mp4) **Exact steps for others to reproduce the error** - open File browser - Set icons to Thumbnails mode - go to any folder that has an incomplete bottom row - attempt make a box selection with mouse starting on bottom empty area - notice that unintended extra files were selected
Author

Added subscriber: @Alumx

Added subscriber: @Alumx
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

I can reproduce that.

I can reproduce that.

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

Don't think this is technically a bug. Blender's thumbnail view always worked like this, as though it was a list view. It selects everything in between the start and end point of the selection.

I think it's a reasonable idea to change it, but this is really just quirky/different behaviour rather than an actual bug.

Don't think this is technically a bug. Blender's thumbnail view always worked like this, as though it was a list view. It selects everything in between the start and end point of the selection. I think it's a reasonable idea to change it, but this is really just quirky/different behaviour rather than an actual bug.
Member

I see. Well I think it is weird when box select selects something that is not actually in the box. Feel free to close this if you think it is not a bug.

I see. Well I think it is weird when box select selects something that is not actually in the box. Feel free to close this if you think it is not a bug.

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
William Reynish self-assigned this 2019-12-29 16:20:08 +01:00

ok closing then. I think it's reasonable to look at changing this, but since this isn't new and not really a bug, it should not be an open bug report.

ok closing then. I think it's reasonable to look at changing this, but since this isn't new and not really a bug, it should not be an open bug report.
Member

Added subscriber: @Harley

Added subscriber: @Harley
Member

This might seem like a simple complaint about a simple problem, but is not.

First examine what is happening. Where is the end of the list? It is certainly below the last items, but is also to the right of those stragglers. So the selections shown in the video start at the end of the list, go to some part inside the list, and then therefore encompass everything in between.

To do to it more intuitively requires a very different set of behaviours when in thumbnail mode. Imagine that the selection shown worked as requested. You would, in fact, want to drag from that right corner up more than one row. It’s not just about not including those stragglers at the left, but more about selecting discontinuous groupings. For example, selecting up the left column of the example list would select a group of every fifth element.

This might seem like a simple complaint about a simple problem, but is not. First examine what is happening. Where is the end of the list? It is certainly below the last items, but is also to the right of those stragglers. So the selections shown in the video start at the end of the list, go to some part inside the list, and then therefore encompass everything in between. To do to it more intuitively requires a very different set of behaviours when in thumbnail mode. Imagine that the selection shown worked as requested. You would, in fact, want to drag from that right corner up more than one row. It’s not just about not including those stragglers at the left, but more about selecting discontinuous groupings. For example, selecting up the left column of the example list would select a group of every fifth element.

Added subscriber: @Garek

Added subscriber: @Garek

Changed status from 'Archived' to: 'Confirmed'

Changed status from 'Archived' to: 'Confirmed'
Garek reopened this issue 2022-01-18 14:52:04 +01:00

This task was closed before Known Issue was defined and used. I reopen it as this is typical case of that and should be open for better access and clarification for those looking up this issue (as I initially did).

I discussed doing this with UI members in a chat.

This task was closed before `Known Issue` was defined and used. I reopen it as this is typical case of that and should be open for better access and clarification for those looking up this issue (as I initially did). I discussed doing this with UI members in a chat.
Member

I'd love to see this worked on. The only small concern I have is that this task's description and "steps to reproduce" don't adequately describe the actual problem to fix.

The current code is selecting a beginning and ending position and including everything in between. This works great in a simple list, but not when there are multiple items per row. This instead has to be changed so that individual items are selected (as if you ctrl-clicked them) if they are touched by the selection rectangle. The target behavior should be the ability to start at the bottom-right of the list, drag to the top-right of the list and have it selected everything in the right-side column - so every 5th element in a list that is showing 5 items per row.

I'd love to see this worked on. The only small concern I have is that this task's description and "steps to reproduce" don't adequately describe the actual problem to fix. The current code is selecting a beginning and ending position and including everything in between. This works great in a simple list, but not when there are multiple items per row. This instead has to be changed so that individual items are selected (as if you ctrl-clicked them) if they are touched by the selection rectangle. The target behavior should be the ability to start at the bottom-right of the list, drag to the top-right of the list and have it selected everything in the right-side column - so every 5th element in a list that is showing 5 items per row.
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:25:02 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#72351
No description provided.