Improve UDIM functionality #72390

New Issue

Lukas Stockner · 2019-12-12T15:55:23+01:00

Lukas Stockner commented

2019-12-12 15:55:23 +01:00

The UDIM code from D3509 covers basic use cases, but there still are quite a few ToDos:

Correct UDIM drawing in workbench engine (D6421 or D6456)
UDIM support in Cycles with OSL (fa5e28ab08)
Add multiple tiles at once (e0cd5b980f)
Filling tiles during creation (11d9271804)
Support opening UDIMs by selecting any secondary tile in File Editor (bdbcb0df10)
Disable Add and Fill operators when primary tile is empty (850aa3a6cf)
Avoiding the texture limit in Eevee (D6456)
Consider adding support for different file name schemes (e.g. "u0_v0" instead of "1001") #77989 (UDIM Textures: support for different file name schemes)
Add operator for finding additional tiles on disk ( or support this via the image reload operator? #75116 (UDIM tiles not recognized when reloading images))
UDIM packing/unpacking (D14395, originally D6492)
Baking UDIMs (related to D3203), report #95190
Tools for UDIM-aware UV editing (e.g. "Move selection to separate tile")
Support for UDIMs in various other features that work with images
Displacement Modifier (f9e65fcea7)
"Edit Externally" (D7789 / #73730)
"Export UV Layout" blender/blender-addons#74325
Node Wrangler Principled Setup blender/blender-addons#93496
Generated UDIM images not saved properly (D14885 / #97251)

The UDIM code from [D3509](https://archive.blender.org/developer/D3509) covers basic use cases, but there still are quite a few ToDos: - [x] Correct UDIM drawing in workbench engine ([D6421](https://archive.blender.org/developer/D6421) or [D6456](https://archive.blender.org/developer/D6456)) - [x] UDIM support in Cycles with OSL (fa5e28ab08) - [x] Add multiple tiles at once (e0cd5b980f) - [x] Filling tiles during creation (11d9271804) - [x] Support opening UDIMs by selecting any secondary tile in File Editor (bdbcb0df10) - [x] Disable Add and Fill operators when primary tile is empty (850aa3a6cf) - [x] Avoiding the texture limit in Eevee ([D6456](https://archive.blender.org/developer/D6456)) - [x] Consider adding support for different file name schemes (e.g. "u0_v0" instead of "1001") #77989 (UDIM Textures: support for different file name schemes) - [x] Add operator for finding additional tiles on disk ( or support this via the image reload operator? #75116 (UDIM tiles not recognized when reloading images)) - [x] UDIM packing/unpacking ([D14395](https://archive.blender.org/developer/D14395), originally [D6492](https://archive.blender.org/developer/D6492)) - [x] Baking UDIMs (related to [D3203](https://archive.blender.org/developer/D3203)), report #95190 - [ ] Tools for UDIM-aware UV editing (e.g. "Move selection to separate tile") - [ ] Support for UDIMs in various other features that work with images - [x] Displacement Modifier (f9e65fcea7) - [ ] "Edit Externally" ([D7789](https://archive.blender.org/developer/D7789) / #73730) - [x] "Export UV Layout" blender/blender-addons#74325 - [ ] Node Wrangler Principled Setup blender/blender-addons#93496 - [ ] Generated UDIM images not saved properly ([D14885](https://archive.blender.org/developer/D14885) / #97251)

Lukas Stockner commented

2019-12-12 15:55:23 +01:00

Added subscriber: @LukasStockner

juan gargallo commented

2019-12-16 21:34:04 +01:00

Added subscriber: @txo

Francois Rimasson commented

2019-12-18 08:35:31 +01:00

Added subscriber: @FrancoisRimasson

Manuel Rais commented

2019-12-24 09:50:14 +01:00

Added subscriber: @g-lul

Alex Fuller commented

2019-12-26 05:19:29 +01:00

Added subscriber: @boberfly

Alex Fuller commented

2019-12-26 05:19:29 +01:00

Hey @LukasStockner

Testing this out on my end. In GafferCycles if I create an image_texture node but have the filename path blank, I will get an assert. My workaround is:

  if(!path_exists(filename)) {
    return -1;
  }

In: https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/image.cpp$319

So that in https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/nodes.cpp$410 this doesn't get set to true on an invalid filename path.

While I have your attention, may I suggest using the syntax to force is_tiled to on? This is aligned with how OpenImageIO works and other renderers using OIIO adhere to this system (and I assume the TextureCache branch might also use):
https://github.com/OpenImageIO/oiio/blob/master/src/libtexture/imagecache.cpp#L300

Cheers, great work so far Lukas!

Hey @LukasStockner Testing this out on my end. In GafferCycles if I create an image_texture node but have the filename path blank, I will get an assert. My workaround is: ``` if(!path_exists(filename)) { return -1; } ``` In: https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/image.cpp$319 So that in https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/nodes.cpp$410 this doesn't get set to true on an invalid filename path. While I have your attention, may I suggest using the <UDIM> syntax to force is_tiled to on? This is aligned with how OpenImageIO works and other renderers using OIIO adhere to this system (and I assume the TextureCache branch might also use): https://github.com/OpenImageIO/oiio/blob/master/src/libtexture/imagecache.cpp#L300 Cheers, great work so far Lukas!

楊景貴 commented

2019-12-26 16:34:39 +01:00

Added subscriber: @Yang_Jing_Gui

Lukas Stockner commented

2019-12-26 20:29:45 +01:00

@boberfly I can't reproduce that issue - if I set an empty filename, it just renders pink without any asserts. Can you tell me which assert you're hitting?
Regarding the tag: Good point, implemented in e4413dc.

@boberfly I can't reproduce that issue - if I set an empty filename, it just renders pink without any asserts. Can you tell me which assert you're hitting? Regarding the <UDIM> tag: Good point, implemented in e4413dc.

Alex Fuller commented

2019-12-26 21:00:46 +01:00

Hi @LukasStockner

I just did a clean build off of Blender master to my standalone Cycles and I can't recreate the issue now, it is pink so that's good. I am balancing the texture cache, openvdb, adaptive sampling & light-groups patch here which probably one of them introduced something weird with the udim patch which I'll try to investigate on my side (gut-feeling it was the openvdb one).

In my case it is triggering has_image to true (first slot is not -1) despite having an invalid path so it never assigns pink and thinks there's an image so it'll eventually assert in the kernel somewhere when it can't find the right INTERPOLATION_* or EXTENSION_* as they were never uploaded to the device properly.

Cheers for adding the tag, that'll work consistently inside of GafferCycles next to Arnold, Appleseed & 3Delight.

Hi @LukasStockner I just did a clean build off of Blender master to my standalone Cycles and I can't recreate the issue now, it is pink so that's good. I am balancing the texture cache, openvdb, adaptive sampling & light-groups patch here which probably one of them introduced something weird with the udim patch which I'll try to investigate on my side (gut-feeling it was the openvdb one). In my case it is triggering `has_image` to `true` (first slot is not -1) despite having an invalid path so it never assigns pink and thinks there's an image so it'll eventually assert in the kernel somewhere when it can't find the right `INTERPOLATION_*` or `EXTENSION_*` as they were never uploaded to the device properly. Cheers for adding the <UDIM> tag, that'll work consistently inside of GafferCycles next to Arnold, Appleseed & 3Delight.

Alex Fuller commented

2019-12-26 21:09:23 +01:00

I just had another thought/idea which isn't necessarily UDIM-related but it might be a good feature to have. In the other renderer backends you are allowed to set the pink missing texture to a color plug. This works well as a fallback, so often in lookdev we would assign a safe texture fallback to the missing texture plug or set it to black if we don't care (like if the model/texture is WIP) or if there's an asset variant change and only some UDIMs are modified and the missing ones would just sample from the base UDIMs via the fallback plug.

In addition to this, I haven't done much testing here with Cycles UDIMs but usually a toggle to fail the render on missing UDIMs (when there are some tiles but not all tiles available based on the mesh UV requests) can be set in other renderer's image samplers, which you can turn off and show the missing texture colour instead of failing. This might go hand-in-hand with the above feature.

Cheers!

I just had another thought/idea which isn't necessarily UDIM-related but it might be a good feature to have. In the other renderer backends you are allowed to set the pink missing texture to a color plug. This works well as a fallback, so often in lookdev we would assign a safe texture fallback to the missing texture plug or set it to black if we don't care (like if the model/texture is WIP) or if there's an asset variant change and only some UDIMs are modified and the missing ones would just sample from the base UDIMs via the fallback plug. In addition to this, I haven't done much testing here with Cycles UDIMs but usually a toggle to fail the render on missing UDIMs (when there are some tiles but not all tiles available based on the mesh UV requests) can be set in other renderer's image samplers, which you can turn off and show the missing texture colour instead of failing. This might go hand-in-hand with the above feature. Cheers!

Alex Fuller commented

2020-01-14 04:04:48 +01:00

Hey Lukas,

I got a chance to test out UDIM support in GafferCycles/Standalone, and I think I've found a bit of an issue here. I noticed in the blender_shader.cpp that this is where the known tiles available are discovered eg.
https://developer.blender.org/diffusion/B/browse/master/intern/cycles/blender/blender_shader.cpp$669

However, in the case of Cycles standalone there's no real way to give this information if all you've got is a file path, so there is an early exit made here:
https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/nodes.cpp$311

Should this use a filesystem check to see what tiles are available, or should I made something custom in GafferCycles to do something similar to what Blender is doing? I'm guessing for regular Cycles standalone that a path won't know/check for more than 1001 either and would need code as well to set the tiles vector.

I wanted to post it here to see if it was an oversight or by design.

Cheers

Hey Lukas, I got a chance to test out UDIM support in GafferCycles/Standalone, and I think I've found a bit of an issue here. I noticed in the blender_shader.cpp that this is where the known tiles available are discovered eg. https://developer.blender.org/diffusion/B/browse/master/intern/cycles/blender/blender_shader.cpp$669 However, in the case of Cycles standalone there's no real way to give this information if all you've got is a file path, so there is an early exit made here: https://developer.blender.org/diffusion/B/browse/master/intern/cycles/render/nodes.cpp$311 Should this use a filesystem check to see what tiles are available, or should I made something custom in GafferCycles to do something similar to what Blender is doing? I'm guessing for regular Cycles standalone that a <UDIM> path won't know/check for more than 1001 either and would need code as well to set the tiles vector. I wanted to post it here to see if it was an oversight or by design. Cheers

Marko Tatalovic commented

2020-02-07 18:11:21 +01:00

Added subscriber: @Fuxna

Marko Tatalovic commented

2020-02-07 18:11:21 +01:00

This comment was removed by @Fuxna

*This comment was removed by @Fuxna*

Vas commented

2020-02-13 19:27:21 +01:00

Added subscriber: @Alumx

Daniel Bystedt commented

2020-02-14 22:46:25 +01:00

Added subscriber: @DanielBystedt

Yegor commented

2020-03-17 14:08:07 +01:00

Added subscriber: @YegorSmirnov

Yegor commented

2020-03-27 11:55:10 +01:00

By the way, UDIMs are not autodetected if using ctrl+shift+t for simultaneous shader channels population with image nodes. But may be it's up to the node wrangler addon functionality.

Helge Maus commented

2020-04-21 10:24:20 +02:00

Added subscriber: @pixeltrain3d

Julien Leménicier commented

2020-04-21 19:34:28 +02:00

Added subscriber: @lemenicier_julien

Andreas Erni commented

2020-05-16 17:10:43 +02:00

Added subscriber: @AndreasErni

Kalle-Samuli Riihikoski commented

2020-07-18 08:09:36 +02:00

Added subscriber: @Kalle-SamuliRiihikoski

Kalle-Samuli Riihikoski commented

2020-07-18 08:09:36 +02:00

I don't know if this is already addressed, but I have python script that load tiled image (texture_1001, texture_1002) into texture node but preview only show first tile.

Did some more tests. So If I name textures in 3d-coat like this: Mesh_diffuse_1001..1002.jpg
Then use blender python script to create texture node and load images files into it. The preview will show only first tile. Now if I go back to 3d-coat and create textures again and this time name them Mesh_1001_diffuse.jpg, etc... then use texture node folder button to load images manually and select this new file ...1001.jpg file. Then preview view changes to look correct.

I don't know if this is already addressed, but I have python script that load tiled image (texture_1001, texture_1002) into texture node but preview only show first tile. Did some more tests. So If I name textures in 3d-coat like this: Mesh_diffuse_1001..1002.jpg Then use blender python script to create texture node and load images files into it. The preview will show only first tile. Now if I go back to 3d-coat and create textures again and this time name them Mesh_1001_diffuse.jpg, etc... then use texture node folder button to load images manually and select this new file ...1001.jpg file. Then preview view changes to look correct.

Swapnil Lade commented

2020-09-01 05:50:51 +02:00

Added subscriber: @SLAD1026