Adaptive domain very broken with collision objects: Mantaflow, Gas sim. #72761

Closed
opened 2019-12-29 04:38:20 +01:00 by Mark Spink · 9 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.86

Blender Version
Broken: version: 2.82 (sub 5), branch: fluid-mantaflow, commit date: 2019-12-16 14:05, hash: ed32db06c1
Worked: (optional)

Short description of error
[It looks like, in the 26-12-19 build, Adaptive Domain has another 'show-stopper': if a collision object is outside the initial volume of the domain-
AdaptiveCollisions.mp4
As you can see from the video this issue also cripples the playback frame rate of the scene.]

Exact steps for others to reproduce the error
[bake the attached .blend without 'adaptive domain' enabled and playback. Then free the bake, enable adaptive domain & re-bake (at this point you might want to save & re-start blender, before baking, as baking the scene now seems to cause a crash very often during baking, but as the above video shows - it can be baked).]
[{F8249516}]

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.86 **Blender Version** Broken: version: 2.82 (sub 5), branch: fluid-mantaflow, commit date: 2019-12-16 14:05, hash: `ed32db06c1` Worked: (optional) **Short description of error** [It looks like, in the 26-12-19 build, Adaptive Domain has another 'show-stopper': if a collision object is outside the initial volume of the domain- [AdaptiveCollisions.mp4](https://archive.blender.org/developer/F8249508/AdaptiveCollisions.mp4) As you can see from the video this issue also cripples the playback frame rate of the scene.] **Exact steps for others to reproduce the error** [bake the attached .blend without 'adaptive domain' enabled and playback. Then free the bake, enable adaptive domain & re-bake (at this point you might want to save & re-start blender, before baking, as baking the scene now seems to cause a crash very often during baking, but as the above video shows - it can be baked).] [{[F8249516](https://archive.blender.org/developer/F8249516/SmokeCollision_Mantaflow.blend)}]
Author

Added subscriber: @marks-4

Added subscriber: @marks-4
Author

And in case anyone's interested- this is not something that happens in the 'old' smoke sim-
AdaptiveCollisions_VanillaSmoke.mov
Loaded the Mantaflow file into Vanilla Blender (2.81a release version), and added the 'old' smoke sim to all items, only change made was lowering the domain vorticity down to 0.
It works as expected / correctly. Here's the 'old smoke' file-
SmokeCollision_Vanilla.blend
Also of interest is the fact that it bakes over 3 times slower, for arguably the same simulation, in Mantaflow, compared to the 'old' smoke sim-
SmokeBakeTimes.mp4
This was using the two previously uploaded .blend files for comparison. On the same machine, with the screen capture software running, so an 'even playing field' situation.
I don't know if you'd call this a separate bug, or even a bug at all, but it's certainly not an improvement over the old system, from a usability perspective.

And in case anyone's interested- this is not something that happens in the 'old' smoke sim- [AdaptiveCollisions_VanillaSmoke.mov](https://archive.blender.org/developer/F8249558/AdaptiveCollisions_VanillaSmoke.mov) Loaded the Mantaflow file into Vanilla Blender (2.81a release version), and added the 'old' smoke sim to all items, only change made was lowering the domain vorticity down to 0. It works as expected / correctly. Here's the 'old smoke' file- [SmokeCollision_Vanilla.blend](https://archive.blender.org/developer/F8249562/SmokeCollision_Vanilla.blend) Also of interest is the fact that it bakes over 3 times slower, for arguably the same simulation, in Mantaflow, compared to the 'old' smoke sim- [SmokeBakeTimes.mp4](https://archive.blender.org/developer/F8249595/SmokeBakeTimes.mp4) This was using the two previously uploaded .blend files for comparison. On the same machine, with the screen capture software running, so an 'even playing field' situation. I don't know if you'd call this a separate bug, or even a bug at all, but it's certainly not an *improvement* over the old system, from a usability perspective.
Author

Regarding Blender crashing when the collision outside the domain is enabled, I was making another scene to test the above issue, and this scene basically crashes Blender as soon as you attempt to bake with a second effector / collision object enabled.
AdaptiveCollisions.blend
Try to bake without the 'CylinderCollision' object enabled, then try again with it enabled- I tried it on 3 different machines and Blender crashes as soon as you press 'bake' on all of them, so it looks fairly repeatable.

Regarding Blender crashing when the collision outside the domain is enabled, I was making another scene to test the above issue, and this scene basically crashes Blender as soon as you attempt to bake with a second effector / collision object enabled. [AdaptiveCollisions.blend](https://archive.blender.org/developer/F8249804/AdaptiveCollisions.blend) Try to bake without the 'CylinderCollision' object enabled, then try again with it enabled- I tried it on 3 different machines and Blender crashes as soon as you press 'bake' on all of them, so it looks fairly repeatable.
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Seems I cannot reproduce crashes (tried buildbot builds da6929488a, c2a37867f2).
Tried AdaptiveCollisions.blend and SmokeCollision_Mantaflow.blend

System Information
Operating system: Linux-5.3.12-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits
Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.31

This might be a Windows-only issue?

Seems I cannot reproduce crashes (tried buildbot builds da6929488a, c2a37867f2). Tried `AdaptiveCollisions.blend` and `SmokeCollision_Mantaflow.blend` **System Information** Operating system: Linux-5.3.12-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits Graphics card: GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.31 This might be a Windows-only issue?
Author

When you say you can't reproduce the crashes, do you mean that the 'SmokeCollisions_Mantaflow' file works properly when you bake it with Adaptive Domain enabled on Linux, with the I'm guessing more recent builds, or the Domain keeps bouncing off the collision object like I get (first video), so you do see the bug?
This is the actual bug I'm reporting, the crashing is just a bonus feature really.

Could be a windows thing- I'm Windows 10 only machine wise, and I'm only using ed32db06c1 (16-12-2019 build) for testing this bug, as it's the build I found the bug in (the one on blender.org in the 'experimental builds' download area as of 10 minutes ago), I never use daily builds, only the download from blender.org.
Mantaflow gets rebuilt quite/very often, so I'd say it's pointless testing with later builds unless it's to compare them to the build used which shows the bug, as in try the .blend in exactly the same build & OS first.

I just tried it on a third machine (HP Z800, and it crashes as soon as you attempt to bake with the cylinder enabled.
All 3 get the same results baking wise (SmokeCollisions_Mantaflow.blend), as in the domain won't expand past the collision object to it's full dimansions when adaptive domain is enabled.

So that's:
an AMD Threadripper 16 core workstation (self-built, 64G Ram, gtx 1070ti + 1070),
a dual 6 core Xeon (HP Z800, 72G Ram, 1 x GTX 1070), both running windows 10 pro,
and an i7 Laptop (Gigabyte Aero15 i7-8750H, 16G Ram, 1 x GTX 1060) running windows 10 home. All using the 16-12-2019 Windows build.

All crash as soon as you press 'bake' with the cylinder enabled using the 16-12-19 build.

When you say you can't reproduce the crashes, do you mean that the 'SmokeCollisions_Mantaflow' file works properly when you bake it with Adaptive Domain enabled on Linux, with the I'm guessing more recent builds, or the Domain keeps bouncing off the collision object like I get (first video), so you do see the bug? This is the actual bug I'm reporting, the crashing is just a bonus feature really. Could be a windows thing- I'm Windows 10 only machine wise, and I'm only using ed32db06c1 (16-12-2019 build) for testing this bug, as it's the build I found the bug in (the one on blender.org in the 'experimental builds' download area as of 10 minutes ago), I never use daily builds, only the download from blender.org. Mantaflow gets rebuilt quite/very often, so I'd say it's pointless testing with later builds unless it's to compare them to the build used which shows the bug, as in try the .blend in exactly the same build & OS first. I just tried it on a third machine (HP Z800, and it crashes as soon as you attempt to bake with the cylinder enabled. All 3 get the same results baking wise (SmokeCollisions_Mantaflow.blend), as in the domain won't expand past the collision object to it's full dimansions when adaptive domain is enabled. So that's: an AMD Threadripper 16 core workstation (self-built, 64G Ram, gtx 1070ti + 1070), a dual 6 core Xeon (HP Z800, 72G Ram, 1 x GTX 1070), both running windows 10 pro, and an i7 Laptop (Gigabyte Aero15 i7-8750H, 16G Ram, 1 x GTX 1060) running windows 10 home. All using the 16-12-2019 Windows build. All crash as soon as you press 'bake' with the cylinder enabled using the 16-12-19 build.
Author

Hello again

Stupidly (apparently) I've been using the Mantaflow version from the experimental builds page, this would appear to be out of date (and should be removed from the page- see my rant in my last comment on this bug #73078)

I've just tried this in 2.82Beta and 2.83Alpha and the bug is completely gone (and the instant crashes), please close this bug!

Sorry for wasting anyone's time, and please, please lose the download from the 'Experimental Branches' page- it's well out of date and confusing as Mantaflow is no longer 'Experimental' and should only be tested / used with 2.82BGeta or 2.83Alpha.

Cheers!
Mark

Hello again Stupidly (apparently) I've been using the Mantaflow version from the experimental builds page, this would appear to be out of date (and should be removed from the page- see my rant in my last comment on this bug #73078) I've just tried this in 2.82Beta and 2.83Alpha and the bug is completely gone (and the instant crashes), please close this bug! Sorry for wasting anyone's time, and please, please lose the download from the 'Experimental Branches' page- it's well out of date and confusing as Mantaflow is no longer 'Experimental' and should only be tested / used with 2.82BGeta or 2.83Alpha. Cheers! Mark
Author

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Mark Spink self-assigned this 2020-01-15 08:05:03 +01:00
Author

See above.

See above.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#72761
No description provided.