Outliner: Alphabetical sorting sorts shorter names last. #72878

New Issue

Stanislav Blinov · 2020-01-03T15:45:19+01:00

Stanislav Blinov commented

2020-01-03 15:45:19 +01:00

Blender Version
Broken: 2.81, 2.82
Worked: 2.80 and before

Short description of error
Names such as "Cube, Cube.001, Cube.002" are ordered as "Cube.001, Cube.002, Cube", whereas you'd normally expect shorter name ordered first if it otherwise matches, and that is the way 2.80 and before do this. I'm aware there were some changes to how numeric parts are considered, but was the length ordering change intentional?

Comparison between 2.80 and 2.81 (2.82):

Exact steps for others to reproduce the error

In the default file, duplicate the Cube twice and note the order of objects in the Outliner. "Cube" will come after "Cube.001" and "Cube.002". Note that this is, of course, with alphabetical sorting enabled.

**Blender Version** Broken: 2.81, 2.82 Worked: 2.80 and before **Short description of error** Names such as "Cube, Cube.001, Cube.002" are ordered as "Cube.001, Cube.002, Cube", whereas you'd normally expect shorter name ordered first if it otherwise matches, and that is the way 2.80 and before do this. I'm aware there were some changes to how **numeric** parts are considered, but was the length ordering change intentional? Comparison between 2.80 and 2.81 (2.82): ![image.png](https://archive.blender.org/developer/F8258419/image.png) **Exact steps for others to reproduce the error** In the default file, duplicate the Cube twice and note the order of objects in the Outliner. "Cube" will come after "Cube.001" and "Cube.002". Note that this is, of course, with alphabetical sorting enabled.

Stanislav Blinov commented

2020-01-03 15:45:19 +01:00

Added subscriber: @Stan_Pancakes

Sam Brubaker commented

2020-01-03 23:48:21 +01:00

Added subscriber: @rocketman

Sam Brubaker commented

2020-01-03 23:48:21 +01:00

I can confirm, although this issue seems to be caused specifically by how the period character is ordered, not by string length. For instance, if you remove the period or replace it with white space, the order works again as one might expect.

Harley Acheson commented

2020-01-04 01:05:55 +01:00

Added subscriber: @Harley

Harley Acheson commented

2020-01-04 01:05:55 +01:00

D:\blender-2.8-git\blender\source\blender\blenlib\intern\string.c BLI_strcasecmp_natural() is definitely made to do that.

The strings are the same until it gets past "Cube". At that point the one with the period wins over the other no matter that it ended. This is because it (from comment) first check for '.' so "foo.bar" comes before "foo 1.bar

My gut feeling is that we just need to check for zero in there too, so changing line 702-704 from:

    if (c1 == '.' && c2 != '.') {
      return -1;
    }

To:

    if (c1 == '.' && c2 != '.' && c2 != 0) {
      return -1;
    }

And then the shorter will win regardless. But my gut feeling might be wrong. I've tried to muck about in there before and was not considering some important details.

D:\blender-2.8-git\blender\source\blender\blenlib\intern\string.c BLI_strcasecmp_natural() is definitely made to do that. The strings are the same until it gets past "Cube". At that point the one with the period wins over the other no matter that it ended. This is because it (from comment) *first check for '.' so "foo.bar" comes before "foo 1.bar* My gut feeling is that we just need to check for zero in there too, so changing line 702-704 from: ``` if (c1 == '.' && c2 != '.') { return -1; } ``` To: ``` if (c1 == '.' && c2 != '.' && c2 != 0) { return -1; } ``` And then the shorter will win regardless. But my gut feeling might be wrong. I've tried to muck about in there before and was not considering some important details.

blender-admin commented

2020-01-08 16:04:00 +01:00

This issue was referenced by f52d9a878d

This issue was referenced by f52d9a878de95ca50788f1773d2c7c48301a6789

Julian Eisel commented

2020-01-08 16:10:46 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Julian Eisel closed this issue

2020-01-08 16:10:46 +01:00

Julian Eisel self-assigned this 2020-01-08 16:10:46 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Outliner: Alphabetical sorting sorts shorter names last. #72878