Page MenuHome

Bone Envelope and Bone Size tools appear to have switched functions
Closed, ResolvedPublicBUG


Version: 2.82 alpha (Jan. 3rd, a854...) Linux 64 bit. Bug also occurs in current stable 2.81a

This bug requires no example file to reproduce.

How to reproduce:

  1. Create an armature object with "Envelope" as its display type
  2. Enter edit mode and open the toolbar
  3. Use the "Bone Size" tool on a bone
  4. Use the "Envelope Size" tool on a bone

The Bone Size tool edits the envelope size, and the Envelope Size tool affects the bone endpoint radius! That can't be right!

Event Timeline

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Jan 6 2020, 12:23 PM

I would confirm this, checking...

Well, might have to backflip on this; from the code-side this looks like intended behavior:

we have:

  • TFM_BONESIZE really goes to TFM_BONE_ENVELOPE_DIST in initTransform()
  • check createTransArmatureVerts for TFM_BONE_ENVELOPE & TFM_BONE_ENVELOPE_DIST (TFM_BONE_ENVELOPE does the radius head/tail related stuff...)

Bit confused atm., needs further investigation...

Philipp Oeser (lichtwerk) changed the task status from Confirmed to Needs Triage.Jan 6 2020, 12:45 PM
Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Developer to Reproduce.Jan 6 2020, 1:38 PM

So thinking about this further, the naming is not even that misleading, the overall Bone Size tool [can only be changed on the whole bone, not individually for head/tail] might be understood as additional envelope distance, whereas the Bone Envelope tool itself can influence head/tail individually and also changes envelope of course [just not the additional distance].

Might be a bit confusing, both icons are unfortunate in my opinion:

  • the Bone Size tool is only relevant to BBones (which only uses its size for viewport display afaict) and Envelopes yet displays as octahedral?
  • the icon for the Bone Envelope tool seems to have an emphasis on the drawn envelope, almost suggesting it is only there for altering the additional distance whereas its main purpose is altering head/tail radii...

Not sure what to do with this report...

@William Reynish (billreynish)
@Sybren A. Stüvel (sybren)

@Philipp Oeser (lichtwerk) please repeat the steps with the transform side panel visible (N). You will notice that the tool which is called "Bone Envelope" does not alter the bone's envelope distance value at all. It only effects the radius size of the bone's head and/or tail. Likewise, the tool which is called "Bone Size" affects only the envelope distance, and not the radius (size) of anything. It's backwards.

Wait, I see now that you have not misunderstood anything. But I still don't think this is a matter of confusing names or icons. The tool's intended functions are quite clear already- they're just switched! One simply does what the other ought to do!

EDIT: Okay NOW I see what you mean about Bbones. In this display mode, the Bone Size tool stops affecting the evnelope size, and instead affects the viewport display size.

Seems like there are, in fact, THREE different functions, split between TWO available tools in ONE toolbar slot, and they're all wrong. Thank you so much for looking into this issue. I will now go stick my head the toilet

William Reynish (billreynish) changed the task status from Needs Developer to Reproduce to Confirmed.Jan 6 2020, 9:01 PM

This is clearly a bug. They indeed are swapped. I had a brief look in the keymap and the tool definition, but it seems to be set correct there, so the issue must be somewhere deeper.

Assigning to @Campbell Barton (campbellbarton) (feel free to re-assign as you wish).

Bastien Montagne (mont29) changed the subtype of this task from "Report" to "Bug".Jan 14 2020, 2:51 PM