Marker sync does not work correctly if moving strip so it overlaps another strip #73014

Closed
opened 2020-01-10 04:03:28 +01:00 by Nick Gammon · 6 comments

System Information
Operating system: Linux-4.15.0-39-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 780/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.77

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-09 19:46, hash: 9d95c035c5

Short description of error
Moving (grabbing) a video strip with a marker through it, and Sync Markers enabled, fails to update the marker location correctly if you drop the strip on top of another strip.

Exact steps for others to reproduce the error

  • Make a new Blender Video Editing project
  • Add two videos (or image sequences) to the sequencer.
  • At the first frame of the second (right-hand) strip add a marker with M. In the example I named it "second video". (first screenshot)
  • Go to Marker menu -> Check Sync Markers option
  • Grab the second strip and move it around to confirm the marker moves with it. (second screenshot)
  • Now grab the second strip and drop on top of first strip (near the end). The border will turn red (third screenshot) and when you release the mouse the strip will snap to the end of the first strip (as expected).
  • However the marker moves to where you tried to release the mouse, not where the strip actually ended up. (fourth screenshot)
  • The marker is now permanently offset by the difference between where you released the mouse, and where the first strip ended.

Two strips with a marker at the start of the second strip:

{F8268067, size=full}

Moved strip to the right, marker follows it:

{F8268069, size=full}

Overlapped move in progress, strip is highlighted in red:

{F8268071, size=full}

When mouse released, strip snaps to end of first strip, however marker stays where it would have been if it had not snapped:

{F8268073, size=full}

It appears that the code to update the marker position runs before the check for the overlapping strips is made.

Thanks!

**System Information** Operating system: Linux-4.15.0-39-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 780/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.77 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-09 19:46, hash: `9d95c035c5` **Short description of error** Moving (grabbing) a video strip with a marker through it, and Sync Markers enabled, fails to update the marker location correctly if you drop the strip on top of another strip. **Exact steps for others to reproduce the error** * Make a new Blender Video Editing project * Add two videos (or image sequences) to the sequencer. * At the first frame of the second (right-hand) strip add a marker with M. In the example I named it "second video". (first screenshot) * Go to Marker menu -> Check **Sync Markers** option * Grab the second strip and move it around to confirm the marker moves with it. (second screenshot) * Now grab the second strip and drop on top of first strip (near the end). The border will turn red (third screenshot) and when you release the mouse the strip will snap to the end of the first strip (as expected). * However the marker moves to where you tried to release the mouse, not where the strip actually ended up. (fourth screenshot) * The marker is now permanently offset by the difference between where you released the mouse, and where the first strip ended. Two strips with a marker at the start of the second strip: {[F8268067](https://archive.blender.org/developer/F8268067/Blender_bug_-_initial_position.png), size=full} Moved strip to the right, marker follows it: {[F8268069](https://archive.blender.org/developer/F8268069/Blender_bug_-_successful_move.png), size=full} Overlapped move in progress, strip is highlighted in red: {[F8268071](https://archive.blender.org/developer/F8268071/Blender_bug_-_overlapped_move.png), size=full} When mouse released, strip snaps to end of first strip, however marker stays where it would have been if it had not snapped: {[F8268073](https://archive.blender.org/developer/F8268073/Blender_bug_-_marker_in_wrong_place.png), size=full} It appears that the code to update the marker position runs before the check for the overlapping strips is made. Thanks!
Author

Added subscriber: @nickgammon

Added subscriber: @nickgammon
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Philipp Oeser self-assigned this 2020-01-10 12:09:46 +01:00
Member

Confirmed, checking...

Confirmed, checking...

This issue was referenced by aa123555d7

This issue was referenced by aa123555d7a75c784f479b9572145f45862bcb2b
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#73014
No description provided.