Crash entering edit mode for "Object Font" instance mesh #73045

New Issue

Peter Lönnebring · 2020-01-11T15:49:27+01:00

Peter Lönnebring commented

2020-01-11 15:49:27 +01:00

System Information
Operating system: Linux-5.3.0-23-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-12-04 11:32, hash: f1aa4d18d4
Also broken: 2.83 alpha (2020-01-11) "blender-2.83-01d9a2f71b56-linux-glibc217-x86_64"
Worked: 2.80 (tested on Linux and macOS)

Short description of error
Crash on entering edit mode for mesh used as "Object Font" instance.

When using an object as "Object Font" for character instancing, entering edit mode for the instanced mesh crashes Blender.
I'm happy to inform you that the issue is really easy to reproduce! :)

I also noticed that if temporarily removing the "Object Font" property (object name prefix) while editing the instanced mesh object, the crash is kind of avoided, but when setting the "Object Font" property to the correct prefix again, the old mesh, before edits, is shown. Entering edit mode at this point crashes Blender again. This seems to be a related issue, but it's difficult to investigate as long as Blender crashes while exploring.

Exact steps for others to reproduce the error
Super quick reproducer:

Open the attached .blend file
Press Tab (enter "edit mode")

blender-crash.blend

Re-create from scratch:

Start with a new file
Create a mesh object
Name mesh object "font.a"
Create a text object
Enable Object -> Instancing -> Verts
Under text/font properties enter "font." as Object Font
Select object "font.a"
Enter mesh edit mode (Tab)

Please tell me if there is anything else I can do to help. Thank you!

**System Information** Operating system: Linux-5.3.0-23-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-12-04 11:32, hash: `f1aa4d18d4` Also broken: 2.83 alpha (2020-01-11) "blender-2.83-01d9a2f71b56-linux-glibc217-x86_64" Worked: 2.80 (tested on Linux and macOS) **Short description of error** Crash on entering edit mode for mesh used as "Object Font" instance. When using an object as "Object Font" for character instancing, entering edit mode for the instanced mesh crashes Blender. I'm happy to inform you that the issue is really easy to reproduce! :) I also noticed that if temporarily removing the "Object Font" property (object name prefix) while editing the instanced mesh object, the crash is kind of avoided, but when setting the "Object Font" property to the correct prefix again, the *old* mesh, before edits, is shown. Entering edit mode at this point crashes Blender again. This seems to be a related issue, but it's difficult to investigate as long as Blender crashes while exploring. **Exact steps for others to reproduce the error** Super quick reproducer: - Open the attached .blend file - Press Tab (enter "edit mode") [blender-crash.blend](https://archive.blender.org/developer/F8269878/blender-crash.blend) Re-create from scratch: - Start with a new file - Create a mesh object - Name mesh object "font.a" - Create a text object - Enable Object -> Instancing -> Verts - Under text/font properties enter "font." as Object Font - Select object "font.a" - Enter mesh edit mode (Tab) Please tell me if there is anything else I can do to help. Thank you!

Peter Lönnebring commented

2020-01-11 15:49:27 +01:00

Added subscriber: @peter.lonnebring

Richard Antalik commented

2020-01-12 17:43:26 +01:00

Added subscriber: @iss

Richard Antalik commented

2020-01-12 17:43:26 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2020-01-12 17:43:26 +01:00

Confirm crash in DRW_mesh_batch_cache_create_requested()

  /* Sanity check. */
  if ((me->edit_mesh != NULL) && (ob->mode & OB_MODE_EDIT)) {
    BLI_assert(me->edit_mesh->mesh_eval_final != NULL);
  }

>	blender.exe!DRW_mesh_batch_cache_create_requested(Object * ob, Mesh * me, const Scene * scene, const bool is_paint_mode, const bool use_hide) Line 1069	C

 	blender.exe!drw_batch_cache_generate_requested(Object * ob) Line 3427	C
 	blender.exe!ghash_free_cb(GHash * gh, void(*)(void *) keyfreefp, void(*)(void *) valfreefp) Line 651	C
 	blender.exe!BLI_ghash_free(GHash * gh, void(*)(void *) keyfreefp, void(*)(void *) valfreefp) Line 1028	C
 	blender.exe!drw_duplidata_free() Line 807	C
 	blender.exe!DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * ar, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1575	C
 	blender.exe!DRW_draw_view(const bContext * C) Line 1486	C
 	blender.exe!view3d_draw_view(const bContext * C, ARegion * ar) Line 1533	C
 	blender.exe!view3d_main_region_draw(const bContext * C, ARegion * ar) Line 1558	C
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * ar) Line 539	C
 	blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 628	C
 	blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 766	C
 	blender.exe!wm_draw_update(bContext * C) Line 946	C
 	blender.exe!WM_main(bContext * C) Line 424	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 520	C

Confirm crash in `DRW_mesh_batch_cache_create_requested()` ``` /* Sanity check. */ if ((me->edit_mesh != NULL) && (ob->mode & OB_MODE_EDIT)) { BLI_assert(me->edit_mesh->mesh_eval_final != NULL); } ``` ``` > blender.exe!DRW_mesh_batch_cache_create_requested(Object * ob, Mesh * me, const Scene * scene, const bool is_paint_mode, const bool use_hide) Line 1069 C blender.exe!drw_batch_cache_generate_requested(Object * ob) Line 3427 C blender.exe!ghash_free_cb(GHash * gh, void(*)(void *) keyfreefp, void(*)(void *) valfreefp) Line 651 C blender.exe!BLI_ghash_free(GHash * gh, void(*)(void *) keyfreefp, void(*)(void *) valfreefp) Line 1028 C blender.exe!drw_duplidata_free() Line 807 C blender.exe!DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * ar, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1575 C blender.exe!DRW_draw_view(const bContext * C) Line 1486 C blender.exe!view3d_draw_view(const bContext * C, ARegion * ar) Line 1533 C blender.exe!view3d_main_region_draw(const bContext * C, ARegion * ar) Line 1558 C blender.exe!ED_region_do_draw(bContext * C, ARegion * ar) Line 539 C blender.exe!wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 628 C blender.exe!wm_draw_window(bContext * C, wmWindow * win) Line 766 C blender.exe!wm_draw_update(bContext * C) Line 946 C blender.exe!WM_main(bContext * C) Line 424 C blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Line 520 C ```

Campbell Barton commented

2020-01-13 08:47:09 +01:00

Added subscribers: @fclem, @ideasman42

Clément Foucault was assigned by Campbell Barton

2020-01-13 08:47:09 +01:00

Campbell Barton commented

2020-01-13 08:47:09 +01:00

The drawing code expects me->edit_mesh->mesh_eval_final to have been created by BKE_object_handle_data_update.

I'm not sure how this is meant to work with drw_batch_cache_generate_requested, relates to 1d92888ee8, assigning to @fclem.

The drawing code expects `me->edit_mesh->mesh_eval_final` to have been created by `BKE_object_handle_data_update`. I'm not sure how this is meant to work with `drw_batch_cache_generate_requested`, relates to 1d92888ee8, assigning to @fclem.

Clément Foucault commented

2020-01-15 15:32:48 +01:00

Added subscriber: @Sergey

Clément Foucault commented

2020-01-15 15:32:48 +01:00

@Sergey I think it is a depsgraph or COW issue more than a drawing issue. In normal vertex instancing, the eval Mesh and EditMesh are shared accross all the instances and the edited object.

But here the dupli object is not sharing the mesh data and seems to be using an incomplete mesh copy.

editbmesh_build_data > obedit 0x7fe2d8fd8a08 em 0x7fe294632e08 mesh_eval_final 0x7fe28680a008
DRW_mesh_batch_cache_create_requested > me 0x7fe2974bc608 em 0x7fe294632e08
DRW_mesh_batch_cache_create_requested > me 0x7fe2942f0608 em 0x7fe29463b008 (dupli object)
Writing: /tmp/blender-crash.crash.txt

Do you have an idea of what could be wrong?

@Sergey I think it is a depsgraph or COW issue more than a drawing issue. In normal vertex instancing, the eval Mesh and EditMesh are shared accross all the instances and the edited object. But here the dupli object is not sharing the mesh data and seems to be using an incomplete mesh copy. ``` editbmesh_build_data > obedit 0x7fe2d8fd8a08 em 0x7fe294632e08 mesh_eval_final 0x7fe28680a008 DRW_mesh_batch_cache_create_requested > me 0x7fe2974bc608 em 0x7fe294632e08 DRW_mesh_batch_cache_create_requested > me 0x7fe2942f0608 em 0x7fe29463b008 (dupli object) Writing: /tmp/blender-crash.crash.txt ``` Do you have an idea of what could be wrong?

Philipp Oeser commented

2020-01-15 15:53:26 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-15 15:53:26 +01:00

"Object Font" duplication also crashes with Curve objects in general:
T73045_curves.blend
(try typing a "b" here...)

"Object Font" duplication also crashes with Curve objects in general: [T73045_curves.blend](https://archive.blender.org/developer/F8279790/T73045_curves.blend) (try typing a "b" here...)

blender-admin commented

2020-02-03 18:37:12 +01:00

This issue was referenced by 0936f2f52c

This issue was referenced by 0936f2f52c584ba623ba6ec722d1581dea97f1f3

Clément Foucault commented

2020-02-03 18:38:52 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-02-03 18:38:52 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash entering edit mode for "Object Font" instance mesh #73045