Page MenuHome

Render Baking From Quick Favourite Menu will not use current pass type [instead stores the one it was added with]
Closed, InvalidPublic

Description

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 419.71

Blender Version
Broken: version: 2.81 (sub 16), branch: master, commit date: 2019-12-04 11:32, hash: rBf1aa4d18d49d
Worked: (optional)

Short description of error
If you add the bake button to the quick favorite menu it will only bake the passes you had selected when you added the button despite the passes you have selected at the moment.

Exact steps for others to reproduce the error
Add the bake button to quick favorite with the "bake type" in Combined.

Now change the "bake type" to Normal.

Go to the viewport and press Q, Bake.

The baking result will be Combined, not Normal as spected.

Event Timeline

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Needs Developer to Reproduce.EditedJan 16 2020, 8:07 PM

Pretty sure this would not be considered a bug.
It might be a bit inconvenient though (in some situations this can be convenient even).


Bit of a detour here (more of a dev-question in the direction of @Dalai Felinto (dfelinto)):
The way this operator works,

  • it is either executed with the pass_type property set [the UI does this, Quick Favorites stores this with the property, true]
  • or you run it without this property set [then it will always be the default for this property: SCE_PASS_COMBINED]

Now all the other properties of this operator are picked up later by the operator "dynamically" [margin etc... basically what you set in the UI -- codewise: read from BakeData in bake_set_props]
I guess we could do the same for pass_type in the UI:

  • not call layout.operator("object.bake", icon='RENDER_STILL').type = cscene.bake_type
  • instead call layout.operator("object.bake", icon='RENDER_STILL') without the type
  • pick up the the pass_type later, so it will also take what is set in the UI without having to call it with the type explicitly
  • Problem here is that pass_type is part of the RenderEngine, not BakeData, @Dalai Felinto (dfelinto): is there a reason for this?

Leaving that aside, happy to hear the opinions of the UI mafia.

Philipp Oeser (lichtwerk) renamed this task from Error at Baking From Quick Favourite Menu to Render Baking From Quick Favourite Menu will not use current pass type [instead stores the one it was added with].Jan 16 2020, 8:08 PM

If we're going to let this pass as a "feature, not a bug", then the Quick Save label should say "Bake (Combined)", or "Bake (Normal)" according to which baking pass the button stored when saved. If it shows just "Bake" as it does, it's a bug, given that you're suppose to be just quick-saving the "Bake" button alone, and that should bake whatever it's selected for its pass at the given moment.

Note this will be resolved with T73178: Menu Editor for Quick Favorites.
@Campbell Barton (campbellbarton): could we merge this report into T73178? Or put this as a subtask T73178 and tag as Known Issue?

@Philipp Oeser (lichtwerk) this report will be linked (now you've mentioned it :) ), don't think it helps to keep it open.
Once we have a menu editor it won't be an issue.

Closing since this isn't an error in the code.