Last undo in undo history reverting multiple actions #73180

New Issue

Dominik Kosík · 2020-01-17T10:42:18+01:00

Dominik Kosík commented

2020-01-17 10:42:18 +01:00

Version:
Tested with version 8.32 alpha, windows x64 self compiled (master branch, date 2020-01-16, commit 2cd3298fde)
(present in stable release, possibly since rework of undo)

Bug description:
When going on last undo in undo history (assuming enough actions were done to start overwriting undo stack) going one step further (ctrl+z) makes Blender skip several actions back.

Replication:
Creating cube, subdividing and removing faces till the maximum capacity of undo stack is reached (and a bit more after).
After doing undo till possible. Last undo will be large skip of actions (mentioned bug)
Alternatively selecting last undo from undo history and then making one more undo with undo button (or ctrl+z)
PS: The easy way is to set undo steps to a minimum to faster reach overwriting of undo stack.

Possible cause:
This bug is caused by leaving at least one undo record with type 'BKE_UNDOSYS_TYPE_MEMFILE' (function BKE_undosys_stack_init_or_active_with_type(...), specifically code below line 435 in undo_system.c).
This kept undo record will often stay at the bottom of the stack and contains very old undo and thus skipping a lot of actions that were made (that can lead to accidental lose work).

Possible fix:
Ignore this always kept undo record when doing undo. (Not sure about inner working and might be bad fix):

(after line 670 in BKE_undosys_step_undo_with_data_ex(...) in undo_system.c)
inserting this snippet:

while (us != NULL && us->type->name == "Global Undo") {
  us = us->prev;
}

Referred files:
source/blender/blenkernel/intern/undo_system.c

**Version:** Tested with version 8.32 alpha, windows x64 self compiled (master branch, date 2020-01-16, commit 2cd3298fde496b1632dac5cb7e9ff21d22e9bad3) (present in stable release, possibly since rework of undo) **Bug description:** When going on last undo in undo history (assuming enough actions were done to start overwriting undo stack) going one step further (ctrl+z) makes Blender skip several actions back. **Replication:** Creating cube, subdividing and removing faces till the maximum capacity of undo stack is reached (and a bit more after). After doing undo till possible. Last undo will be large skip of actions (mentioned bug) Alternatively selecting last undo from undo history and then making one more undo with undo button (or ctrl+z) PS: The easy way is to set undo steps to a minimum to faster reach overwriting of undo stack. **Possible cause:** This bug is caused by leaving at least one undo record with type 'BKE_UNDOSYS_TYPE_MEMFILE' (function BKE_undosys_stack_init_or_active_with_type(...), specifically code below line 435 in undo_system.c). This kept undo record will often stay at the bottom of the stack and contains very old undo and thus skipping a lot of actions that were made (that can lead to accidental lose work). **Possible fix:** Ignore this always kept undo record when doing undo. (Not sure about inner working and might be bad fix): (after line 670 in BKE_undosys_step_undo_with_data_ex(...) in undo_system.c) inserting this snippet: ``` while (us != NULL && us->type->name == "Global Undo") { us = us->prev; } ``` **Referred files:** source/blender/blenkernel/intern/undo_system.c

Dominik Kosík commented

2020-01-17 10:42:18 +01:00

Added subscriber: @Rengyr

Richard Antalik commented

2020-01-20 12:29:57 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-01-20 12:53:50 +01:00

Added subscribers: @ideasman42, @mano-wii

Germano Cavalcante commented

2020-01-20 12:53:50 +01:00

I tried to reproduce the problem.
The cube ended up like this:

Blender skipped to the action of entering edit mode and skipped the first edits.
In fact, it kept (internally) one last undo of the type BKE_UNDOSYS_TYPE_MEMFILE.

I suppose it was expected to have stopped in edit mode.

@ideasman42, is this somehow working as designed or is it a bug?

I tried to reproduce the problem. The cube ended up like this: ![image.png](https://archive.blender.org/developer/F8289530/image.png) Blender skipped to the action of entering edit mode and skipped the first edits. In fact, it kept (internally) one last undo of the type `BKE_UNDOSYS_TYPE_MEMFILE`. I suppose it was expected to have stopped in edit mode. @ideasman42, is this somehow working as designed or is it a bug?

Bastien Montagne commented

2020-01-20 21:08:50 +01:00

Added subscriber: @mont29

Campbell Barton commented

2020-06-18 11:13:46 +02:00

Closed as duplicate of #76642

Campbell Barton closed this issue

2020-06-18 11:13:46 +02:00

Campbell Barton commented

2020-06-18 11:13:58 +02:00

Changed status from 'Duplicate' to: 'Resolved'

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Last undo in undo history reverting multiple actions #73180