Collections created with CTRL G do not appear in Outliner View Layer #73197

New Issue

Wayne Johnson · 2020-01-17T15:40:13+01:00

Wayne Johnson commented

2020-01-17 15:40:13 +01:00

System Information
Operating system: Darwin-19.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon R9 M295X OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.4.19

Blender Version
Broken: version: 2.83 (sub 0), branch: master, commit date: 2020-01-16 20:11, hash: 86db35845a
Worked: (optional)

Short description of error
Collections created with CTRL G do not appear in Outliner View Layer

Exact steps for others to reproduce the error

Select more than one object
CTRL G to 'Make New Collection'
Observe that this collection is not shown in View Layer of Outliner
Switch Outliner to Blender File
Observe that the new collection IS shown in the Blender File list

Looks like a bug to me?
Thanks
Wayne

**System Information** Operating system: Darwin-19.2.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon R9 M295X OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.4.19 **Blender Version** Broken: version: 2.83 (sub 0), branch: master, commit date: 2020-01-16 20:11, hash: `86db35845a` Worked: (optional) **Short description of error** Collections created with CTRL G do not appear in Outliner View Layer **Exact steps for others to reproduce the error** 1. Select more than one object 2. CTRL G to 'Make New Collection' 3. Observe that this collection is not shown in View Layer of Outliner 4. Switch Outliner to Blender File 5. Observe that the new collection IS shown in the Blender File list Looks like a bug to me? Thanks Wayne

Wayne Johnson commented

2020-01-17 15:40:14 +01:00

Added subscriber: @slowboy

Sybren A. Stüvel commented

2020-01-17 16:43:26 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-01-17 16:43:26 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sybren A. Stüvel commented

2020-01-17 16:43:26 +01:00

AFAIK this is by design. The newly created collection doesn't have to be in the scene to be used; for example, it can be used in a particle system.

Something like this could be sufficient to implement this:

diff --git a/source/blender/editors/object/object_collection.c b/source/blender/editors/object/object_collection.c
index a00e5e7b198..12c6a488532 100644
--- a/source/blender/editors/object/object_collection.c
+++ b/source/blender/editors/object/object_collection.c
@@ -401,6 +401,28 @@ static int collection_create_exec(bContext *C, wmOperator *op)
   }
   CTX_DATA_END;
 
+  /* Add the new collection to the scene. */
+  Collection *active_collection = CTX_data_collection(C);
+  Scene *scene = CTX_data_scene(C);
+  bool scene_is_linked = ID_IS_LINKED(scene);
+  if ((active_collection->flag & COLLECTION_IS_MASTER) && scene_is_linked) {
+    BKE_report(op->reports, RPT_WARNING, "Cannot add a collection to a linked scene");
+    active_collection = NULL;
+  }
+  else if (ID_IS_LINKED(active_collection)) {
+    /* Fall back to the scene master collection if possible. */
+    if (scene_is_linked) {
+      BKE_report(op->reports, RPT_WARNING, "Cannot add a collection to a linked scene");
+      active_collection = NULL;
+    }
+    else {
+      active_collection = scene->master_collection;
+    }
+  }
+  if (active_collection != NULL) {
+    BKE_collection_child_add(bmain, active_collection, collection);
+  }
+
   DEG_relations_tag_update(bmain);
   WM_event_add_notifier(C, NC_GROUP | NA_EDITED, NULL);

However, a change like this should be properly designed & the behaviour agreed upon before implementing it.

AFAIK this is by design. The newly created collection doesn't have to be in the scene to be used; for example, it can be used in a particle system. Something like this could be sufficient to implement this: ``` diff --git a/source/blender/editors/object/object_collection.c b/source/blender/editors/object/object_collection.c index a00e5e7b198..12c6a488532 100644 --- a/source/blender/editors/object/object_collection.c +++ b/source/blender/editors/object/object_collection.c @@ -401,6 +401,28 @@ static int collection_create_exec(bContext *C, wmOperator *op) } CTX_DATA_END; + /* Add the new collection to the scene. */ + Collection *active_collection = CTX_data_collection(C); + Scene *scene = CTX_data_scene(C); + bool scene_is_linked = ID_IS_LINKED(scene); + if ((active_collection->flag & COLLECTION_IS_MASTER) && scene_is_linked) { + BKE_report(op->reports, RPT_WARNING, "Cannot add a collection to a linked scene"); + active_collection = NULL; + } + else if (ID_IS_LINKED(active_collection)) { + /* Fall back to the scene master collection if possible. */ + if (scene_is_linked) { + BKE_report(op->reports, RPT_WARNING, "Cannot add a collection to a linked scene"); + active_collection = NULL; + } + else { + active_collection = scene->master_collection; + } + } + if (active_collection != NULL) { + BKE_collection_child_add(bmain, active_collection, collection); + } + DEG_relations_tag_update(bmain); WM_event_add_notifier(C, NC_GROUP | NA_EDITED, NULL); ``` However, a change like this should be properly designed & the behaviour agreed upon before implementing it.

Philipp Oeser commented

2020-01-17 16:56:08 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-17 16:56:08 +01:00

This task was "usually" used for this #53662 (Usability issues with old group operators), @dr.sybren, feel free to merge in either direction...

Sybren A. Stüvel commented

2020-01-17 17:38:35 +01:00

Closed as duplicate of #68942

Sybren A. Stüvel closed this issue

2020-01-17 17:38:35 +01:00

Sybren A. Stüvel commented

2020-01-17 17:46:09 +01:00

Added subscriber: @dfelinto

Sybren A. Stüvel commented

2020-01-17 17:46:09 +01:00

I checked with @dfelinto and Ctrl+G is working as designed right now.

Wayne Johnson commented

2020-01-17 17:50:51 +01:00

Fair enough, but does seem strange to me. If a dialog tells me that I am about to 'Create New Collection' as CTRL+G does, wouldn't I reasonably expect that created Collection to behave just the same as any other Collection, and appear in the View Layer, just as a Collection created in any other way does?

Juan Gea commented

2020-01-18 09:21:02 +01:00

Added subscriber: @juang3d

Juan Gea commented

2020-01-18 09:21:02 +01:00

O agree on this, if it’s working as designed there are two possibilities:

1.- Bad design :) but I don’t think so, I see the utility of this

2.- Bad user feedback/UI/communication of what is happening, I think the dialog should communicate a bit better what is happening, and in any case a checkbox like “Instance to Scene” or “Add collection to scene” wouldn’t hurt :)

O agree on this, if it’s working as designed there are two possibilities: 1.- Bad design :) but I don’t think so, I see the utility of this 2.- Bad user feedback/UI/communication of what is happening, I think the dialog should communicate a bit better what is happening, and in any case a checkbox like “Instance to Scene” or “Add collection to scene” wouldn’t hurt :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Collections created with CTRL G do not appear in Outliner View Layer #73197