mathnode socket doesn't restore when voronoi signal is turned to #73211

New Issue

user1 · 2020-01-18T10:09:15+01:00

user1 commented

2020-01-18 10:09:15 +01:00

System Information
Operating system: Linux-4.15.0-66201911071317-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GT 630/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-30 18:20, hash: 56ef761381
Worked: (optional)

Short description of error
the mathnode after a voronoi tex node ejects the noodle when you switch voronoi to "n-sphere radius" and keeps hiding any values.

Exact steps for others to reproduce the error
open blender
create a material for an object of your choice
add voronoi and mathnode as shown in the picture
switch voronoi from f1 to n-sphere radius
notice that the mathnode disconnenćts, which is fine, butit should re-open the slot then, right?

**System Information** Operating system: Linux-4.15.0-66201911071317-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GT 630/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.116 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2019-12-30 18:20, hash: `56ef761381` Worked: (optional) **Short description of error** the mathnode after a voronoi tex node ejects the noodle when you switch voronoi to "n-sphere radius" and keeps hiding any values. **Exact steps for others to reproduce the error** open blender create a material for an object of your choice add voronoi and mathnode as shown in the picture switch voronoi from f1 to n-sphere radius notice that the mathnode disconnenćts, which is fine, butit should re-open the slot then, right? ![Bildschirmfoto zu 2020-01-18 10-08-45.png](https://archive.blender.org/developer/F8284931/Bildschirmfoto_zu_2020-01-18_10-08-45.png)

user1 commented

2020-01-18 10:09:15 +01:00

Added subscriber: @user1

Richard Antalik commented

2020-01-20 14:17:45 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2020-03-04 15:17:25 +01:00

Added subscribers: @OmarEmaraDev, @JacquesLucke

Jacques Lucke commented

2020-03-04 15:17:26 +01:00

This is a possible solution to the issue:

diff --git a/source/blender/blenkernel/intern/node.c b/source/blender/blenkernel/intern/node.c
index 9e52f7ea939..b4bdbd97fbe 100644
--- a/source/blender/blenkernel/intern/node.c
+++ b/source/blender/blenkernel/intern/node.c
@@ -3336,8 +3336,10 @@ void ntreeTagUsedSockets(bNodeTree *ntree)
   }
 
   for (link = ntree->links.first; link; link = link->next) {
-    link->fromsock->flag |= SOCK_IN_USE;
-    link->tosock->flag |= SOCK_IN_USE;
+    if ((link->fromsock->flag & SOCK_UNAVAIL) == 0 && (link->tosock->flag & SOCK_UNAVAIL) == 0) {
+      link->fromsock->flag |= SOCK_IN_USE;
+      link->tosock->flag |= SOCK_IN_USE;
+    }
   }
 }

This redefines SOCK_IN_USE from "socket that has any incident link" to "socket that is available and is linked to any other available socket". This might conflict with some versioning code from @OmarEmaraDev though.

This is a possible solution to the issue: ``` diff --git a/source/blender/blenkernel/intern/node.c b/source/blender/blenkernel/intern/node.c index 9e52f7ea939..b4bdbd97fbe 100644 --- a/source/blender/blenkernel/intern/node.c +++ b/source/blender/blenkernel/intern/node.c @@ -3336,8 +3336,10 @@ void ntreeTagUsedSockets(bNodeTree *ntree) } for (link = ntree->links.first; link; link = link->next) { - link->fromsock->flag |= SOCK_IN_USE; - link->tosock->flag |= SOCK_IN_USE; + if ((link->fromsock->flag & SOCK_UNAVAIL) == 0 && (link->tosock->flag & SOCK_UNAVAIL) == 0) { + link->fromsock->flag |= SOCK_IN_USE; + link->tosock->flag |= SOCK_IN_USE; + } } } ``` This redefines `SOCK_IN_USE` from "socket that has any incident link" to "socket that is available and is linked to any other available socket". This might conflict with some versioning code from @OmarEmaraDev though.

Omar Emara commented

2020-03-04 16:09:20 +01:00

@JacquesLucke Taking a quick look at the versioning code. It seems versioning is done before any update take place. So it doesn't seem like this change will affect versioning. I will take a closer look later.

Omar Emara commented

2020-03-04 18:54:43 +01:00

Unfortunately, I was wrong. This does break versioning.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

mathnode socket doesn't restore when voronoi signal is turned to #73211