UI Themes: Grid color affecting axis color #73390

New Issue

Gilberto Rodrigues · 2020-01-25T16:29:28+01:00

2020-01-25 16:29:28 +01:00

Blender Version
2.81a, 2.82 Beta.

Description
In 3D View, the grid color overlays the XYZ axis colors, so it's impossible to set the colors I want to the XYZ axis.
This even happens if the grid color is set to transparent.

0020-1556.mp4

Exact steps for others to reproduce the error

Go to preferences -> Themes -> User Interface -> Axis & Gizmo Colors
Change X and Y axis color to black RGB(0, 0, 0)
Go to preferences -> Themes -> 3d View
change Grid color/alpha.

X and Y axis color will be affected

**Blender Version** 2.81a, 2.82 Beta. **Description** In 3D View, the grid color overlays the XYZ axis colors, so it's impossible to set the colors I want to the XYZ axis. This even happens if the grid color is set to transparent. [0020-1556.mp4](https://archive.blender.org/developer/F8512321/0020-1556.mp4) **Exact steps for others to reproduce the error** - Go to preferences -> Themes -> User Interface -> Axis & Gizmo Colors - Change X and Y axis color to black RGB(0, 0, 0) - Go to preferences -> Themes -> 3d View - change Grid color/alpha. X and Y axis color will be affected

Gilberto Rodrigues commented

2020-01-25 16:29:28 +01:00

Added subscriber: @Gilberto.R

blender-admin commented

2020-01-25 16:29:28 +01:00

#88672 was marked as duplicate of this issue

Ankit Meel commented

2020-01-25 17:18:44 +01:00

Added subscriber: @ankitm

Ankit Meel commented

2020-01-25 17:18:44 +01:00

Find the settings to change axis and gizmo colors in Preferences → Themes → User interface → Axis and Gizmo Colours.

Find the settings to change axis and gizmo colors in Preferences → Themes → User interface → Axis and Gizmo Colours. ![Screenshot 2020-01-25 at 21.47.37.png](https://archive.blender.org/developer/F8301414/Screenshot_2020-01-25_at_21.47.37.png)

Gilberto Rodrigues commented

2020-01-25 18:17:14 +01:00

Ankit, I know how to choose the axis color. The problem is that the color we pick for the Axis is then mixed with the grid color in the viewport. So the axis colors are brighter or darker depending on the grid color, and always less saturated. For example, if you need to set X axis to be the color red (R 255 G 0 B 0) the viewport will show a different less saturated red because it is mixing it with the grid color, so if I change the grid color to match the desired red for the axis, the other 2 axis colors will be screwed up. The grid is influencing XYZ colors even if the grid is fully transparent. The XYZ axis colors should be totally independent from the grid color.

Russell commented

2020-01-25 18:21:46 +01:00

Added subscriber: @Russ1642

Russell commented

2020-01-25 18:21:46 +01:00

I can confirm this. For an easy to see example set the x-axis to red (1 0 0) and the grid to blue (0 0 1). The x-axis will show as a magenta line.

I can confirm this. For an easy to see example set the x-axis to red (1 0 0) and the grid to blue (0 0 1). The x-axis will show as a magenta line. ![Incorrect Axis Colours.png](https://archive.blender.org/developer/F8301525/Incorrect_Axis_Colours.png)

Ankit Meel commented

2020-01-25 18:23:18 +01:00

It was not clear to me by the original task description. I suggest you edit it.
Also, not that I know the code, but the axes are grid first, and then three special lines were taken to be given a different color. So linkage between grid and axis settings could be there.

It was not clear to me by the original task description. I suggest you edit it. Also, not that I know the code, but the axes are grid first, and then three special lines were taken to be given a different color. So linkage between grid and axis settings could be there.

Russell commented

2020-01-25 18:26:27 +01:00

Even setting the grid colour (RGBA) to 0,0,0,0 will only get you close to the axis colour. I can't get a pure red axis to show up on screen. Perhaps there's some other colour management stuff going on there.

Richard Antalik changed title from ~~3d viewport XYZ axis colors are incorrect.~~ to UI Themes: Grid color affecting axis color

2020-01-25 20:18:29 +01:00

Richard Antalik commented

2020-01-25 20:19:24 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Julian Eisel commented

2020-02-04 18:02:13 +01:00

Added subscribers: @Jeroen-Bakker, @JulianEisel

Julian Eisel commented

2020-02-04 18:02:13 +01:00

I've recently checked on this briefly to see where the issue is coming from, but I didn't see anything suspicious. My first guess was that the grid overlaps the axes, so that you'd get the color mixed. But even disabling the grid didn't seem to fix this.

@Jeroen-Bakker, could you have a look at this?

I've recently checked on this briefly to see where the issue is coming from, but I didn't see anything suspicious. My first guess was that the grid overlaps the axes, so that you'd get the color mixed. But even disabling the grid didn't seem to fix this. @Jeroen-Bakker, could you have a look at this?

Julian Eisel commented

2020-02-18 18:44:47 +01:00

Classifying this as bug for now, because the code doesn't seem to do this intentionally from what I can see. The viewport team can re-classify if they disagree.

Clément Foucault commented

2020-04-17 21:27:25 +02:00

Added subscribers: @WilliamReynish, @fclem

Clément Foucault commented

2020-04-17 21:27:25 +02:00

This seems to be on purpose. draw_common.c : l.173 :

  /* Grid Axis */
  UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_X, 0.5f, -10, gb->colorGridAxisX);
  UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_Y, 0.5f, -10, gb->colorGridAxisY);
  UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_Z, 0.5f, -10, gb->colorGridAxisZ);

To me this is to avoid too much contrast in the grid but this could be a theme setting. I don't remember if there was any discussion about this.
CC: @WilliamReynish

This seems to be on purpose. `draw_common.c : l.173` : ``` /* Grid Axis */ UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_X, 0.5f, -10, gb->colorGridAxisX); UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_Y, 0.5f, -10, gb->colorGridAxisY); UI_GetThemeColorBlendShade4fv(TH_GRID, TH_AXIS_Z, 0.5f, -10, gb->colorGridAxisZ); ``` To me this is to avoid too much contrast in the grid but this could be a theme setting. I don't remember if there was any discussion about this. CC: @WilliamReynish

Gilberto Rodrigues commented

2020-04-21 07:36:32 +02:00

This comment was removed by @Gilberto.R

*This comment was removed by @Gilberto.R*

Gilberto Rodrigues commented

2020-05-04 18:24:20 +02:00

@WilliamReynish What's your say?

William Reynish commented

2020-05-04 21:12:03 +02:00

I agree this seems like a bug - at the very least it’s quite unexpected.

Harley Acheson commented

2020-05-04 23:09:55 +02:00

Added subscriber: @Harley

Harley Acheson commented

2020-05-04 23:09:55 +02:00

There might be some "gotchas" in fixing this.

We can easily make it so the axes are drawn with in the exact theme colors chosen:

  /* Grid Axis */
  UI_GetThemeColor4fv(TH_AXIS_X, gb->colorGridAxisX);
  UI_GetThemeColor4fv(TH_AXIS_Y, gb->colorGridAxisY);
  UI_GetThemeColor4fv(TH_AXIS_Z, gb->colorGridAxisZ);

Then set the default colors to how they visually work out to now:

At that point the default lines look as they do now, but you can set them to anything you like and you see exactly that.

However, the Navigate gizmo balls look washed out since they share the same colors. We are used to those nav balls looking more saturated than the axes lines:

There might be some "gotchas" in fixing this. We can easily make it so the axes are drawn with in the exact theme colors chosen: ``` /* Grid Axis */ UI_GetThemeColor4fv(TH_AXIS_X, gb->colorGridAxisX); UI_GetThemeColor4fv(TH_AXIS_Y, gb->colorGridAxisY); UI_GetThemeColor4fv(TH_AXIS_Z, gb->colorGridAxisZ); ``` Then set the default colors to how they visually work out to now: ![AxesColors.png](https://archive.blender.org/developer/F8512674/AxesColors.png) At that point the default lines look as they do now, but you can set them to anything you like and you see exactly that. However, the Navigate gizmo balls look washed out since they share the same colors. We are used to those nav balls looking more saturated than the axes lines: ![NavigateGizmo.png](https://archive.blender.org/developer/F8512680/NavigateGizmo.png)

Gilberto Rodrigues commented

2020-05-05 05:38:37 +02:00

Then there needs to be an option to select the axis colors for the gizmo separately.