Missing undo push when switching active shape keys #73495

New Issue

David C. · 2020-01-29T18:27:14+01:00

David C. commented

2020-01-29 18:27:14 +01:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: AMD Radeon (TM) R9 380 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010

Blender Version
Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-28 23:34, hash: f9e1e088a4
Worked: (optional)

Short description of error
In edit mode, while selecting a shape key, followed by any other operation (Translating vertices or extruding or whatever), followed by an Undo (Ctrl-Z) command causes the shape key selector to hop to the "basis" shape key.

Exact steps for others to reproduce the error
From Default Startup:

Create two shape keys on Default Cube
Select shape key Key 1
Perform any edit mode operation (extrude)
Undo

Basis shape key is now selected.

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: AMD Radeon (TM) R9 380 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010 **Blender Version** Broken: version: 2.82 (sub 6), branch: master, commit date: 2020-01-28 23:34, hash: `f9e1e088a4` Worked: (optional) **Short description of error** In edit mode, while selecting a shape key, followed by any other operation (Translating vertices or extruding or whatever), followed by an Undo (Ctrl-Z) command causes the shape key selector to hop to the "basis" shape key. **Exact steps for others to reproduce the error** From Default Startup: - Create two shape keys on Default Cube - Select shape key `Key 1` - Perform any edit mode operation (extrude) - Undo Basis shape key is now selected.

David C. commented

2020-01-29 18:27:14 +01:00

Added subscriber: @Broand

Stanislav Blinov commented

2020-01-29 19:22:52 +01:00

Added subscriber: @Stan_Pancakes

Stanislav Blinov commented

2020-01-29 19:22:52 +01:00

Inset tool itself has no bearing on this issue. All the reproduction is (in edit mode):

select a different shape key
perform any edit mode operation
undo

Both the operation and shape key selection will be undone.

Inset tool itself has no bearing on this issue. All the reproduction is (in edit mode): - select a different shape key - perform any edit mode operation - undo Both the operation and shape key selection will be undone.

Richard Antalik commented

2020-01-29 19:39:23 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

William Reynish changed title from ~~Inset faces command has bugged interaction with Undo command.~~ to Missing undo push when switching active shape keys

2020-01-29 19:47:12 +01:00

blender-admin commented

2020-01-30 04:55:54 +01:00

This issue was referenced by 1d28ff7f2b

This issue was referenced by 1d28ff7f2bd100e7921bfc02e9ad20f78847a5be

Campbell Barton commented

2020-01-30 05:12:03 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2020-01-30 05:12:03 +01:00

Campbell Barton self-assigned this 2020-01-30 05:12:03 +01:00

David C. commented

2020-02-01 08:11:07 +01:00

Hm, I found the bug only seemed to occur with the inset tool. Further, when I "undo" the inset itself, the shape key selection goes back on key 1.
Glad to know a bug was found and fixed though.

Hm, I found the bug only seemed to occur with the inset tool. Further, when I "undo" the inset itself, the shape key selection goes back on key 1. Glad to know a bug was found and fixed though.

Evan Wilson commented

2020-02-01 09:05:30 +01:00

Added subscriber: @EAW

Evan Wilson commented

2020-02-01 09:05:30 +01:00

Changed status from 'Resolved' to: 'Confirmed'

Evan Wilson reopened this issue

2020-02-01 09:05:30 +01:00

Evan Wilson commented

2020-02-01 09:05:30 +01:00

After talking with @Broand in #blender-coders, I tested it using the original steps. I can confirm that pressing control-z still causes both the operation after using inset and the shape key selection to be undone. Pressing control-z again will undo the Inset and the shape key selection will jump back to Key 1 I am using a fresh 2.83 build.

@Broand did offer to open a new report. I chose to reopened this report as 1d28ff7f2b did not fix the reported issue. Let me know if I should have followed a different procedure. This type of situation isn't covered in the triaging playbook :)

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13

Blender Version
Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-01 02:58, hash: bf8a26b745

After talking with @Broand in #blender-coders, I tested it using the original steps. I can confirm that pressing `control-z` still causes both the operation *after using inset* and the shape key selection to be undone. Pressing `control-z` again will undo the Inset and the shape key selection will jump back to `Key 1` I am using a fresh 2.83 build. @Broand did offer to open a new report. I chose to reopened this report as 1d28ff7f2b did not fix the reported issue. Let me know if I should have followed a different procedure. This type of situation isn't covered in the triaging playbook :) --- **System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 470/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.13 **Blender Version** Broken: version: 2.83 (sub 2), branch: master, commit date: 2020-02-01 02:58, hash: `bf8a26b745`

Asher commented

2020-02-01 16:10:50 +01:00

Added subscriber: @ThatAsherGuy

Asher commented

2020-02-01 16:10:50 +01:00

I can confirm this one to a degree. It seems to depend on what's in the undo history and how far back you go. In certain situations it'll change the shape key, and then change it back, as you undo.

Campbell Barton commented

2020-02-04 04:48:47 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2020-02-04 04:48:47 +01:00

Campbell Barton commented

2020-02-04 04:48:47 +01:00

The basic case of changing shape keys not doing undo pushes has been solved (double checked the steps from the report),
if you manage to cause another error please open a new report with exact steps.

The basic case of changing shape keys not doing undo pushes has been solved (double checked the steps from the report), if you manage to cause another error please open a new report with exact steps.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Missing undo push when switching active shape keys #73495