Give Make Single User sensible defaults #73711

New Issue

Alfred Morgan · 2020-02-10T13:55:33+01:00

Alfred Morgan commented

2020-02-10 13:55:33 +01:00

Broken: version: 2.83 master b59adcaa36

Description:
A make single user operation should at least do something when activated. Reasonable default options should be set. I included a diff with suggested reasonable options.

Steps:
Open Blender > New fresh default file.
Duplicate default cube once or more times with ALT + D (so all the cubes share the same object data). Now we have 2 or more cubes linked.
With all cubes selected > 'Operator Search' > 'Make Single User' > 'Selected Objects'

Expected:
Unlinked Objects

Actual:
No operation

Diff:

diff --git a/source/blender/editors/object/object_relations.c b/source/blender/editors/object/object_relations.c
index f9e2a2b8a1a..1c036f44cdf 100644
--- a/source/blender/editors/object/object_relations.c
+++ b/source/blender/editors/object/object_relations.c
@@ -2656,8 +2656,8 @@ void OBJECT_OT_make_single_user(wmOperatorType *ot)
   /* properties */
   ot->prop = RNA_def_enum(ot->srna, "type", type_items, MAKE_SINGLE_USER_SELECTED, "Type", "");

-  RNA_def_boolean(ot->srna, "object", 0, "Object", "Make single user objects");
-  RNA_def_boolean(ot->srna, "obdata", 0, "Object Data", "Make single user object data");
+  RNA_def_boolean(ot->srna, "object", 1, "Object", "Make single user objects");
+  RNA_def_boolean(ot->srna, "obdata", 1, "Object Data", "Make single user object data");
   RNA_def_boolean(ot->srna, "material", 0, "Materials", "Make materials local to each data-block");
   RNA_def_boolean(
       ot->srna, "animation", 0, "Object Animation", "Make animation data local to each object");

Broken: version: 2.83 master b59adcaa368 Description: A `make single user operation` should at least do something when activated. Reasonable default options should be set. I included a diff with suggested reasonable options. Steps: Open Blender > New fresh default file. Duplicate default cube once or more times with ALT + D (so all the cubes share the same object data). Now we have 2 or more cubes linked. With all cubes selected > 'Operator Search' > 'Make Single User' > 'Selected Objects' Expected: Unlinked Objects Actual: No operation Diff: ``` diff --git a/source/blender/editors/object/object_relations.c b/source/blender/editors/object/object_relations.c index f9e2a2b8a1a..1c036f44cdf 100644 --- a/source/blender/editors/object/object_relations.c +++ b/source/blender/editors/object/object_relations.c @@ -2656,8 +2656,8 @@ void OBJECT_OT_make_single_user(wmOperatorType *ot) /* properties */ ot->prop = RNA_def_enum(ot->srna, "type", type_items, MAKE_SINGLE_USER_SELECTED, "Type", ""); - RNA_def_boolean(ot->srna, "object", 0, "Object", "Make single user objects"); - RNA_def_boolean(ot->srna, "obdata", 0, "Object Data", "Make single user object data"); + RNA_def_boolean(ot->srna, "object", 1, "Object", "Make single user objects"); + RNA_def_boolean(ot->srna, "obdata", 1, "Object Data", "Make single user object data"); RNA_def_boolean(ot->srna, "material", 0, "Materials", "Make materials local to each data-block"); RNA_def_boolean( ot->srna, "animation", 0, "Object Animation", "Make animation data local to each object"); ```

Alfred Morgan commented

2020-02-10 13:55:33 +01:00

Added subscriber: @Zectbumo

blender-admin commented

2020-02-10 13:55:33 +01:00

#71654 was marked as duplicate of this issue

blender-admin commented

2020-02-11 04:01:01 +01:00

This issue was referenced by 50d5c03e2d

This issue was referenced by 50d5c03e2d14b852c6afd3046aa8428bede85efd

Campbell Barton commented

2020-02-11 04:11:20 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Campbell Barton closed this issue

2020-02-11 04:11:20 +01:00

Campbell Barton self-assigned this 2020-02-11 04:11:20 +01:00

Campbell Barton commented

2020-02-11 04:14:30 +01:00

Note that this isn't a bug strictly speaking, since the operator was working as intended.

In this case there is no obvious default action, duplicating all object data could be an expensive operation in some cases, which might not be what the user wants.

Blender's redo popup isn't useful in this case either since the changes aren't visible.

Committed an alternative change that uses a popup dialog.

*Note that this isn't a bug strictly speaking, since the operator was working as intended.* ---- In this case there is no obvious default action, duplicating all object data could be an expensive operation in some cases, which might not be what the user wants. Blender's redo popup isn't useful in this case either since the changes aren't visible. Committed an alternative change that uses a popup dialog.

Alfred Morgan commented

2020-02-11 06:14:00 +01:00

much better thanks.

Philipp Oeser commented

2020-02-11 12:49:37 +01:00

Added subscribers: @lowpolysaac, @dfelinto, @lichtwerk

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Give Make Single User sensible defaults #73711