UI: Metadata Panel is added to every Sidebar Tab #74041

New Issue

tintwotin · 2020-02-20T14:23:03+01:00

tintwotin commented

2020-02-20 14:23:03 +01:00

System Information
Operating system: Windows-10-10.0.17763-SP0 64 Bits
Graphics card: Intel(R) UHD Graphics 600 Intel 4.5.0 - Build 26.20.100.7262

Blender Version
Broken: version: 2.83 (sub 4), branch: master (modified), commit date: 2020-02-18 11:23, hash: e3e6dc41a7
Worked: (optional)

Short description of error
The empty Metadata Panel is added to every Sidebar tab here and there, all over Blender. Ex. in the Sequencer Preview:

**System Information** Operating system: Windows-10-10.0.17763-SP0 64 Bits Graphics card: Intel(R) UHD Graphics 600 Intel 4.5.0 - Build 26.20.100.7262 **Blender Version** Broken: version: 2.83 (sub 4), branch: master (modified), commit date: 2020-02-18 11:23, hash: `e3e6dc41a7` Worked: (optional) **Short description of error** The empty Metadata Panel is added to every Sidebar tab here and there, all over Blender. Ex. in the Sequencer Preview: ![Metadata_panel.gif](https://archive.blender.org/developer/F8353438/Metadata_panel.gif)

tintwotin commented

2020-02-20 14:23:03 +01:00

Added subscriber: @tintwotin

blender-admin commented

2020-02-20 14:23:03 +01:00

#86969 was marked as duplicate of this issue

Philipp Oeser commented

2020-02-21 10:36:21 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-02-21 10:36:21 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-02-21 10:36:21 +01:00

Can confirm.

This is where the metadata panel shows up:

Movie Clip Editor: in Footage tab
Image Editor: in Image tab
Video Sequencer: everywhere, (should only be in Strip tab?)

Also checking why it is always empty apparently...

Can confirm. This is where the metadata panel shows up: - **Movie Clip Editor**: in `Footage` tab - **Image Editor**: in `Image` tab - **Video Sequencer**: everywhere, (should only be in `Strip` tab?) Also checking why it is always empty apparently...

Philipp Oeser self-assigned this 2020-02-21 10:49:04 +01:00

Philipp Oeser commented

2020-02-21 11:21:41 +01:00

Regarding the panel being everywhere in the VSE: not so very sure anymore about putting it in the "Strip" tab, this will not display info for the selected strip, but for what you see in the preview (ImBuf)... so maybe makes sense to have it in all tabs?
Or put it in its own "Metadata" tab?
Regarding the Panel actually being empty: seems like we are not displaying the original ImBuf, but the cache or something? If I load in EXRs, then sequencer_ibuf_get will still get me a PNG? Still needs more investigation...

- Regarding the panel being everywhere in the VSE: not so very sure anymore about putting it in the "Strip" tab, this will not display info for the selected strip, but for what you see in the preview (ImBuf)... so maybe makes sense to have it in all tabs? Or put it in its own "Metadata" tab? - Regarding the Panel actually being empty: seems like we are not displaying the original ImBuf, but the cache or something? If I load in EXRs, then `sequencer_ibuf_get` will still get me a PNG? Still needs more investigation...

Philipp Oeser removed their assignment 2020-02-21 12:08:31 +01:00

Philipp Oeser commented

2020-02-21 12:08:31 +01:00

Added subscribers: @iss, @Sergey

Philipp Oeser commented

2020-02-21 12:08:31 +01:00

OK, I am not sure how this would ever work in the Video Sequencer if we try to get the ImBuf from sequencer_ibuf_get (as this gets rendered and there is no metadata on the newly rendered ImBuf)...

@Sergey, @iss : am I missing something? If this indeed cannot work (by design), should we instead change direction and put the metadata panel as part of the strip tab (getting the metadata for the strip instead -- which should work, would be happy to write a patch for this)

regarding the issue of the panel being everywhere: it just needs a category (being it its own "Metadata" or alternatively put in the "Strip" tab - see above)
P1269: T74041_snippet



diff --git a/source/blender/editors/space_sequencer/sequencer_buttons.c b/source/blender/editors/space_sequencer/sequencer_buttons.c
index 7bec913900d..8cb9e44eb6d 100644
--- a/source/blender/editors/space_sequencer/sequencer_buttons.c
+++ b/source/blender/editors/space_sequencer/sequencer_buttons.c
@@ -113,6 +113,7 @@ void sequencer_buttons_register(ARegionType *art)
   pt = MEM_callocN(sizeof(PanelType), "spacetype sequencer panel metadata");
   strcpy(pt->idname, "SEQUENCER_PT_metadata");
   strcpy(pt->label, N_("Metadata"));
+  strcpy(pt->category, "Metadata");
   strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA);
   pt->poll = metadata_panel_context_poll;
   pt->draw = metadata_panel_context_draw;

relevant commits:

8c87af7440 (put the panel in "Footage" for MCE, had it in all tabs for Image Editor & VSE)
83d78eb32c
4d89667663
340c564020 (moved the panel to the Image tab for the Image Editor)

OK, I am not sure how this would ever work in the Video Sequencer if we try to get the ImBuf from `sequencer_ibuf_get` (as this gets rendered and there is no metadata on the newly rendered ImBuf)... @Sergey, @iss : am I missing something? If this indeed cannot work (by design), should we instead change direction and put the metadata panel as part of the strip tab (getting the metadata for the strip instead -- which should work, would be happy to write a patch for this) regarding the issue of the panel being everywhere: it just needs a category (being it its own "Metadata" or alternatively put in the "Strip" tab - see above) [P1269: T74041_snippet](https://archive.blender.org/developer/P1269.txt) ``` diff --git a/source/blender/editors/space_sequencer/sequencer_buttons.c b/source/blender/editors/space_sequencer/sequencer_buttons.c index 7bec913900d..8cb9e44eb6d 100644 --- a/source/blender/editors/space_sequencer/sequencer_buttons.c +++ b/source/blender/editors/space_sequencer/sequencer_buttons.c @@ -113,6 +113,7 @@ void sequencer_buttons_register(ARegionType *art) pt = MEM_callocN(sizeof(PanelType), "spacetype sequencer panel metadata"); strcpy(pt->idname, "SEQUENCER_PT_metadata"); strcpy(pt->label, N_("Metadata")); + strcpy(pt->category, "Metadata"); strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA); pt->poll = metadata_panel_context_poll; pt->draw = metadata_panel_context_draw; ``` relevant commits: - 8c87af7440 (put the panel in "Footage" for MCE, had it in all tabs for Image Editor & VSE) - 83d78eb32c - 4d89667663 - 340c564020 (moved the panel to the Image tab for the Image Editor)

tintwotin commented

2020-02-21 12:14:56 +01:00

It should only be in the Sequencer Preview Sidebar Tab called View - as it is only printing data in the preview and is executed when the playhead moves. AFAIR it only works for Blender generated EXR files, saved with that meta data inserted. There was the same problem in the Sequencer/timeline sidebar and it was fixed by Sebastian(?), but I can't find the commit.

Nb. it is also inserted into tabs generated by add-ons. The Misc tab above in the gif - is from an add-on.

It should only be in the Sequencer Preview Sidebar Tab called View - as it is only printing data in the preview and is executed when the playhead moves. AFAIR it only works for Blender generated EXR files, saved with that meta data inserted. There was the same problem in the Sequencer/timeline sidebar and it was fixed by Sebastian(?), but I can't find the commit. Nb. it is also inserted into tabs generated by add-ons. The Misc tab above in the gif - is from an add-on.

Philipp Oeser commented

2020-02-21 12:24:55 +01:00

In #74041#877400, @tintwotin wrote:
It should only be in the Sequencer Preview Sidebar Tab called View - as it is only printing data in the preview and is executed when the playhead moves.

"View" could be good, yes (if it would really work to get the metadata from the preview...)

AFAIR it only works for Blender generated EXR files, saved with that meta data inserted. There was the same problem in the Sequencer/timeline sidebar and it was fixed by Sebastian(?), but I can't find the commit.

Cannot get it to work. What could I be doing wrong?

Nb. it is also inserted into tabs generated by add-ons. The Misc tab above in the gif - is from an add-on.

That should go away if we give it a category

> In #74041#877400, @tintwotin wrote: > It should only be in the Sequencer Preview Sidebar Tab called View - as it is only printing data in the preview and is executed when the playhead moves. "View" could be good, yes (if it would really work to get the metadata from the preview...) > AFAIR it only works for Blender generated EXR files, saved with that meta data inserted. There was the same problem in the Sequencer/timeline sidebar and it was fixed by Sebastian(?), but I can't find the commit. Cannot get it to work. What could I be doing wrong? > Nb. it is also inserted into tabs generated by add-ons. The Misc tab above in the gif - is from an add-on. That should go away if we give it a category

tintwotin commented

2020-06-09 08:25:32 +02:00

Changed status from 'Confirmed' to: 'Archived'

tintwotin closed this issue

2020-06-09 08:25:32 +02:00

tintwotin self-assigned this 2020-06-09 08:25:32 +02:00

Philipp Oeser commented

2021-03-31 17:24:00 +02:00

Changed status from 'Archived' to: 'Confirmed'

Philipp Oeser reopened this issue

2021-03-31 17:24:00 +02:00

Philipp Oeser commented

2021-03-31 17:24:00 +02:00

I am reopening this, since the same has been reported again in #86969 (UI: Metadata option is added in all VSE Preview Sidebar tabs) (and I am not sure why this was closed at that time, this report already has a bit more information...)

tintwotin removed their assignment 2021-05-29 09:44:51 +02:00

Richard Antalik commented

2021-05-31 11:06:44 +02:00

This seems to be resolved everywhere else, will look into limiting appearence in VSE.

Richard Antalik commented

2021-06-01 23:19:04 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2021-06-01 23:19:04 +02:00

Richard Antalik self-assigned this 2021-06-01 23:19:04 +02:00

Richard Antalik commented

2021-06-01 23:19:04 +02:00

In #74041#877390, @lichtwerk wrote:
OK, I am not sure how this would ever work in the Video Sequencer if we try to get the ImBuf from sequencer_ibuf_get (as this gets rendered and there is no metadata on the newly rendered ImBuf)...

This is bug - metadata should be transfered to final ImBuf.
This data could exist per strip too, which arguably could be better solution.

regarding the issue of the panel being everywhere: it just needs a category (being it its own "Metadata" or alternatively put in the "Strip" tab - see above)
P1269: T74041_snippet



diff --git a/source/blender/editors/space_sequencer/sequencer_buttons.c b/source/blender/editors/space_sequencer/sequencer_buttons.c
index 7bec913900d..8cb9e44eb6d 100644
--- a/source/blender/editors/space_sequencer/sequencer_buttons.c
+++ b/source/blender/editors/space_sequencer/sequencer_buttons.c
@@ -113,6 +113,7 @@ void sequencer_buttons_register(ARegionType *art)
   pt = MEM_callocN(sizeof(PanelType), "spacetype sequencer panel metadata");
   strcpy(pt->idname, "SEQUENCER_PT_metadata");
   strcpy(pt->label, N_("Metadata"));
+  strcpy(pt->category, "Metadata");
   strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA);
   pt->poll = metadata_panel_context_poll;
   pt->draw = metadata_panel_context_draw;

This sounds reasonable, committed in 3400ba329e.

Forgot to mention task in commit, so closing now.

> In #74041#877390, @lichtwerk wrote: > OK, I am not sure how this would ever work in the Video Sequencer if we try to get the ImBuf from `sequencer_ibuf_get` (as this gets rendered and there is no metadata on the newly rendered ImBuf)... This is bug - metadata should be transfered to final `ImBuf`. This data could exist per strip too, which arguably could be better solution. > regarding the issue of the panel being everywhere: it just needs a category (being it its own "Metadata" or alternatively put in the "Strip" tab - see above) > [P1269: T74041_snippet](https://archive.blender.org/developer/P1269.txt) ``` diff --git a/source/blender/editors/space_sequencer/sequencer_buttons.c b/source/blender/editors/space_sequencer/sequencer_buttons.c index 7bec913900d..8cb9e44eb6d 100644 --- a/source/blender/editors/space_sequencer/sequencer_buttons.c +++ b/source/blender/editors/space_sequencer/sequencer_buttons.c @@ -113,6 +113,7 @@ void sequencer_buttons_register(ARegionType *art) pt = MEM_callocN(sizeof(PanelType), "spacetype sequencer panel metadata"); strcpy(pt->idname, "SEQUENCER_PT_metadata"); strcpy(pt->label, N_("Metadata")); + strcpy(pt->category, "Metadata"); strcpy(pt->translation_context, BLT_I18NCONTEXT_DEFAULT_BPYRNA); pt->poll = metadata_panel_context_poll; pt->draw = metadata_panel_context_draw; ``` This sounds reasonable, committed in 3400ba329e. Forgot to mention task in commit, so closing now.

Richard Antalik commented

2021-06-01 23:33:22 +02:00

Just a note, that metadata are copied only when only one strip is being processed, so when you blend 2 strips, they are not. I can see this in some effects, and it would be probaly easier and cleaner to support metadata on strip level than constantly make sure that you don't miss IMB_metadata_copy somewhere.

Edit: But on other metadata panel for each strip wouldn' be great either, because you will have to first click on correct strip first to see anything and this can be problem when you want to see metadata but strips are too small.

Alternative could be to iterate through "temp cache" items that are guaranteed to contain all images produced by all strips, and print all metadata per strip. But this could too get messy in complicated edits.

Just a note, that metadata are copied only when only one strip is being processed, so when you blend 2 strips, they are not. I can see this in some effects, and it would be probaly easier and cleaner to support metadata on strip level than constantly make sure that you don't miss `IMB_metadata_copy` somewhere. Edit: But on other metadata panel for each strip wouldn' be great either, because you will have to first click on correct strip first to see anything and this can be problem when you want to see metadata but strips are too small. Alternative could be to iterate through "temp cache" items that are guaranteed to contain all images produced by all strips, and print all metadata per strip. But this could too get messy in complicated edits.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Metadata Panel is added to every Sidebar Tab #74041