2.83.4 Immediate crash upon using splash screen to open Recent/ New files. #74102

New Issue

Paul Hartsuyker · 2020-02-22T08:19:24+01:00

Paul Hartsuyker commented

2020-02-22 08:19:24 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66

Blender Version
Broken: version: 2.83 (sub 4), branch: master, commit date: 2020-02-21 23:50, hash: 0b626703f9
Worked: (in prior build)

Short description of error
Load attached file after opening. Immediate crash. Did do this prior build.
Just double checked. Crashes immediately if loaded from my Most Recent List, but doesn't crash if I just use Open. Tried it twice??

Exact steps for others to reproduce the error
Launch Blender 2.83.4, (this build) Open attached file. Save. Close.
Restart Blender, click on Most Recent record of this file, Crash. Did not do this on prior build.
Opens just fine in 2.82.6
boy_v11full.blend

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.66 **Blender Version** Broken: version: 2.83 (sub 4), branch: master, commit date: 2020-02-21 23:50, hash: `0b626703f9` Worked: (in prior build) **Short description of error** Load attached file after opening. Immediate crash. Did do this prior build. Just double checked. Crashes immediately if loaded from my Most Recent List, but doesn't crash if I just use Open. Tried it twice?? **Exact steps for others to reproduce the error** Launch Blender 2.83.4, (this build) Open attached file. Save. Close. Restart Blender, click on Most Recent record of this file, Crash. Did not do this on prior build. Opens just fine in 2.82.6 [boy_v11full.blend](https://archive.blender.org/developer/F8362078/boy_v11full.blend)

Paul Hartsuyker commented

2020-02-22 08:19:24 +01:00

Added subscriber: @PaulHartsuyker

blender-admin commented

2020-02-22 08:19:24 +01:00

#74170 was marked as duplicate of this issue

blender-admin commented

2020-02-22 08:19:24 +01:00

#74117 was marked as duplicate of this issue

blender-admin commented

2020-02-22 08:19:24 +01:00

#74113 was marked as duplicate of this issue

blender-admin commented

2020-02-22 08:19:24 +01:00

#74104 was marked as duplicate of this issue

blender-admin commented

2020-02-22 08:19:24 +01:00

#74105 was marked as duplicate of this issue

Ankit Meel commented

2020-02-22 12:29:04 +01:00

Added subscriber: @ankitm

Ankit Meel commented

2020-02-22 12:29:04 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Ankit Meel commented

2020-02-22 12:29:04 +01:00

This comment was removed by @ankitm

*This comment was removed by @ankitm*

Ankit Meel commented

2020-02-22 12:30:54 +01:00

Added subscribers: @LaurentCHAIX, @Gaddhi

Ankit Meel commented

2020-02-22 12:31:07 +01:00

Added subscriber: @Blendork

Ankit Meel commented

2020-02-22 12:32:15 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Ankit Meel changed title from ~~Immediate crash, 2.83.4~~ to 2.83.4 Immediate crash upon using splash screen to open Recent/ New files.

2020-02-22 12:36:01 +01:00

Gaddhi commented

2020-02-22 12:38:24 +01:00

A few additional notes (copy from closed task based on request by Ankit):

Looks like this was introduced in 0b626703f9, because this crash does not happen in the previous commit to master
Blender crashes also when selecting any of the items under "New Files" like for example "General" or "Video Editing" in the Splash Screen
One can redisplay the Splash Screen by selecting in the menu the Blender-Icon to the left of the File menu. Opening any file via this Splash Screen works without problems.

A few additional notes (copy from closed task based on request by Ankit): - Looks like this was introduced in 0b626703f9, because this crash does not happen in the previous commit to master - Blender crashes also when selecting any of the items under "New Files" like for example "General" or "Video Editing" in the Splash Screen - One can redisplay the Splash Screen by selecting in the menu the Blender-Icon to the left of the File menu. Opening any file via this Splash Screen works without problems.

Campbell Barton was assigned by Robert Guetzkow

2020-02-22 13:27:35 +01:00

Robert Guetzkow commented

2020-02-22 13:31:01 +01:00

Added subscriber: @rjg

Robert Guetzkow commented

2020-02-22 13:31:01 +01:00

ctx_sa is NULL when opening a file through the splash screen. This causes a crash at the following part of the code introduced in 0b626703f9:

  if (BLI_listbase_is_empty(&sc->regionbase)) {
    ctx_sa->flag |= AREA_FLAG_CURSOR_UPDATE;
  }

Stacktrace

ui_popup_block_remove(bContext * C, uiPopupBlockHandle * handle) Line 558	C
ui_popup_block_free(bContext * C, uiPopupBlockHandle * handle) Line 855	C
ui_popup_handler_remove(bContext * C, void * userdata) Line 10815	C
WM_event_remove_handlers(bContext * C, ListBase * handlers) Line 1759	C
wm_window_match_init(bContext * C, ListBase * wmlist) Line 168	C
WM_file_read(bContext * C, const unsigned char * filepath, ReportList * reports) Line 629	C
wm_file_read_opwrap(bContext * C, const unsigned char * filepath, ReportList * reports, const bool autoexec_init) Line 2095	C
wm_open_mainfile__open(bContext * C, wmOperator * op) Line 2236	C
operator_state_dispatch(bContext * C, wmOperator * op, OperatorDispatchTarget * targets) Line 2131	C
wm_open_mainfile_dispatch(bContext * C, wmOperator * op) Line 2263	C
wm_open_mainfile__discard_changes(bContext * C, wmOperator * op) Line 2178	C
operator_state_dispatch(bContext * C, wmOperator * op, OperatorDispatchTarget * targets) Line 2131	C
wm_open_mainfile_dispatch(bContext * C, wmOperator * op) Line 2263	C
wm_open_mainfile_invoke(bContext * C, wmOperator * op, const wmEvent * UNUSED_event) Line 2268	C
wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1267	C
wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line 1514	C
WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1529	C
ui_apply_but_funcs_after(bContext * C) Line 883	C
ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 10785	C
wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 617	C
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2553	C
wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2799	C
wm_event_do_handlers(bContext * C) Line 3178	C
WM_main(bContext * C) Line 421	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 520	C

`ctx_sa` is `NULL` when opening a file through the splash screen. This causes a crash at the following part of the code introduced in 0b626703f9: ``` if (BLI_listbase_is_empty(&sc->regionbase)) { ctx_sa->flag |= AREA_FLAG_CURSOR_UPDATE; } ``` Stacktrace ``` ui_popup_block_remove(bContext * C, uiPopupBlockHandle * handle) Line 558 C ui_popup_block_free(bContext * C, uiPopupBlockHandle * handle) Line 855 C ui_popup_handler_remove(bContext * C, void * userdata) Line 10815 C WM_event_remove_handlers(bContext * C, ListBase * handlers) Line 1759 C wm_window_match_init(bContext * C, ListBase * wmlist) Line 168 C WM_file_read(bContext * C, const unsigned char * filepath, ReportList * reports) Line 629 C wm_file_read_opwrap(bContext * C, const unsigned char * filepath, ReportList * reports, const bool autoexec_init) Line 2095 C wm_open_mainfile__open(bContext * C, wmOperator * op) Line 2236 C operator_state_dispatch(bContext * C, wmOperator * op, OperatorDispatchTarget * targets) Line 2131 C wm_open_mainfile_dispatch(bContext * C, wmOperator * op) Line 2263 C wm_open_mainfile__discard_changes(bContext * C, wmOperator * op) Line 2178 C operator_state_dispatch(bContext * C, wmOperator * op, OperatorDispatchTarget * targets) Line 2131 C wm_open_mainfile_dispatch(bContext * C, wmOperator * op) Line 2263 C wm_open_mainfile_invoke(bContext * C, wmOperator * op, const wmEvent * UNUSED_event) Line 2268 C wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Line 1267 C wm_operator_call_internal(bContext * C, wmOperatorType * ot, PointerRNA * properties, ReportList * reports, const short context, const bool poll_only, wmEvent * event) Line 1514 C WM_operator_name_call_ptr(bContext * C, wmOperatorType * ot, short context, PointerRNA * properties) Line 1529 C ui_apply_but_funcs_after(bContext * C) Line 883 C ui_popup_handler(bContext * C, const wmEvent * event, void * userdata) Line 10785 C wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) Line 617 C wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Line 2553 C wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Line 2799 C wm_event_do_handlers(bContext * C) Line 3178 C WM_main(bContext * C) Line 421 C main(int argc, const unsigned char * * UNUSED_argv_c) Line 520 C ```

Robert Guetzkow commented

2020-02-22 13:47:41 +01:00

ED_region_cursor_set(), which was previously used, checked if ctx_sa is NULL. Therefore this should be done here as well.

`ED_region_cursor_set()`, which was previously used, checked if `ctx_sa` is `NULL`. Therefore this should be done here as well.

Evan Wilson commented

2020-02-22 15:42:00 +01:00

Added subscriber: @EAW

Evan Wilson commented

2020-02-22 15:42:00 +01:00

As this is a crash caused by an extremely common action, from a commit from less than 24 hours ago, raising this to high.
The longer this is around, the more bug reports we will get on it is my thought.

As this is a crash caused by an extremely common action, from a commit from less than 24 hours ago, raising this to high. The longer this is around, the more bug reports we will get on it is my thought.

Antonio Vazquez commented

2020-02-22 16:30:20 +01:00

Added subscriber: @antoniov