Python console: cursor drawing issue #74298

New Issue

Kim Geonwoo · 2020-02-28T16:33:19+01:00

Kim Geonwoo commented

2020-02-28 16:33:19 +01:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19

Blender Version
Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-02-28 13:46, hash: 94dcfe7a77

Short description of error
Cursor is drawn higher every time current line go up, and gone when text reach the top of main window.
Desktop 2020.02.28 - 23.50.47.03 (online-video-cutter.com).mp4

Exact steps for others to reproduce the error
On the default startup, open python console.

Make a number of lines by typing some text or zooming in, and make cursor go up using arrow key.
Type more text or zoom in until text reach the top of main window.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.19 **Blender Version** Broken: version: 2.83 (sub 5), branch: master, commit date: 2020-02-28 13:46, hash: `94dcfe7a77` **Short description of error** Cursor is drawn higher every time current line go up, and gone when text reach the top of main window. [Desktop 2020.02.28 - 23.50.47.03 (online-video-cutter.com).mp4](https://archive.blender.org/developer/F8378219/Desktop_2020.02.28_-_23.50.47.03__online-video-cutter.com_.mp4) **Exact steps for others to reproduce the error** On the default startup, open python console. 1. Make a number of lines by typing some text or zooming in, and make cursor go up using arrow key. 2. Type more text or zoom in until text reach the top of main window.

Kim Geonwoo commented

2020-02-28 16:33:19 +01:00

Added subscriber: @skyjib

Richard Antalik commented

2020-02-29 00:59:41 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Kim Geonwoo commented

2020-03-04 16:30:28 +01:00

I found out the reason why cursor has gone.

      if (!textview_draw_string(&tds,
                                ext_line,
                                ext_len,
                                (data_flag & TVC_LINE_FG) ? fg : NULL,
                                (data_flag & TVC_LINE_BG) ? bg : NULL,
                                (data_flag & TVC_LINE_ICON) ? icon : 0,
                                (data_flag & TVC_LINE_ICON_FG) ? icon_fg : NULL,
                                (data_flag & TVC_LINE_ICON_BG) ? icon_bg : NULL,
                                bg_sel)) {
        /* When drawing, if we pass v2d->cur.ymax, then quit. */
        if (do_draw) {
          /* Past the y limits. */
          break;
        }
      }

      if (do_draw) {
        if (tvc->draw_cursor && iter_index == 0) {
          tvc->draw_cursor(tvc, tds.cwidth, tds.columns, tds.lofs);
        }
      }

textview_draw_string returns false when the last line is off the screen, then it breaks the loop that calls draw_cursor.
When break is removed or draw_cursor is called before break, cursor will be drawn incorrectly without disappearing.

I found out the reason why cursor has gone. ``` if (!textview_draw_string(&tds, ext_line, ext_len, (data_flag & TVC_LINE_FG) ? fg : NULL, (data_flag & TVC_LINE_BG) ? bg : NULL, (data_flag & TVC_LINE_ICON) ? icon : 0, (data_flag & TVC_LINE_ICON_FG) ? icon_fg : NULL, (data_flag & TVC_LINE_ICON_BG) ? icon_bg : NULL, bg_sel)) { /* When drawing, if we pass v2d->cur.ymax, then quit. */ if (do_draw) { /* Past the y limits. */ break; } } if (do_draw) { if (tvc->draw_cursor && iter_index == 0) { tvc->draw_cursor(tvc, tds.cwidth, tds.columns, tds.lofs); } } ``` `textview_draw_string` returns false when the last line is off the screen, then it breaks the loop that calls `draw_cursor`. When break is removed or `draw_cursor` is called before break, cursor will be drawn incorrectly without disappearing. ![SharedScreenshot.jpg](https://archive.blender.org/developer/F8388052/SharedScreenshot.jpg)

Mateusz commented

2020-03-29 11:26:59 +02:00

Added subscriber: @brezdo