Skin Modifier not applied to Array Modifier Start & End Caps #74598

New Issue

L Furneaux · 2020-03-10T02:19:29+01:00

L Furneaux commented

2020-03-10 02:19:29 +01:00

Skin Modifier not applied to Array Modifier Start & End Caps

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.97

Blender Version
Broken: version: 2.82 (sub 7), branch: master, commit date: 2020-02-12 16:20, hash: 77d23b0bd7
Also tried in 2.83 alpha blender-2.83-fbe81db29a28-windows64, 2.81b and 2.79.
Worked: Not in any Blender version I have access to.

Short description of error
When adding a skin modifier to an array with start and end caps, the skin modifier does not extend around the caps.

Exact steps for others to reproduce the error
Default Blend file - add three planes.
Add array modifier to Plane.
Set array modifier start cap as Plane.001 and end cap as Plane.002 and enable Merge.
Add skin modifier.
Skin Modifier will only be applied to the arrayed object, not the start/end caps, with spears at the joins.

To see expected outcome: Apply array modifier. Remove and re-add Skin modifier.

Example blend file attached with fence model.
Maybe related to #59770 but Blender does not crash, it just doesn't add the skin properly.

Skin - Array End Caps Bug.blend

Skin Modifier not applied to Array Modifier Start & End Caps **System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 440.97 **Blender Version** Broken: version: 2.82 (sub 7), branch: master, commit date: 2020-02-12 16:20, hash: `77d23b0bd7` Also tried in 2.83 alpha blender-2.83-fbe81db29a28-windows64, 2.81b and 2.79. Worked: Not in any Blender version I have access to. **Short description of error** When adding a skin modifier to an array with start and end caps, the skin modifier does not extend around the caps. **Exact steps for others to reproduce the error** Default Blend file - add three planes. Add array modifier to Plane. Set array modifier start cap as Plane.001 and end cap as Plane.002 and enable Merge. Add skin modifier. Skin Modifier will only be applied to the arrayed object, not the start/end caps, with spears at the joins. To see expected outcome: Apply array modifier. Remove and re-add Skin modifier. Example blend file attached with fence model. Maybe related to #59770 but Blender does not crash, it just doesn't add the skin properly. ![Skin-Array Modifier Bug.png](https://archive.blender.org/developer/F8398357/Skin-Array_Modifier_Bug.png) [Skin - Array End Caps Bug.blend](https://archive.blender.org/developer/F8398360/Skin_-_Array_End_Caps_Bug.blend)

L Furneaux commented

2020-03-10 02:19:29 +01:00

Added subscriber: @sherbert_lemon

Germano Cavalcante commented

2020-03-10 20:37:20 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-03-10 20:37:20 +01:00

Changed status from 'Needs Triage' to: 'Archived'

Germano Cavalcante closed this issue

2020-03-10 20:37:20 +01:00

Germano Cavalcante self-assigned this 2020-03-10 20:37:20 +01:00

Germano Cavalcante commented

2020-03-10 20:37:20 +01:00

The problem here is that the skin radius of the caps' vertices are not initialized.
This patch would allow them to be initialized:
P1292: Patch for #74598

diff --git a/source/blender/blenkernel/BKE_mesh.h b/source/blender/blenkernel/BKE_mesh.h
index ae2f5231e25..34fb4fcacab 100644
--- a/source/blender/blenkernel/BKE_mesh.h
+++ b/source/blender/blenkernel/BKE_mesh.h
@@ -26,6 +26,7 @@
 /* defines BLI_INLINE */
 #include "BLI_compiler_compat.h"
 
+enum eCDAllocType;
 struct BLI_Stack;
 struct BMEditMesh;
 struct BMesh;
@@ -124,7 +125,8 @@ struct Mesh *BKE_mesh_new_nomain_from_template_ex(const struct Mesh *me_src,
                                                   int tessface_len,
                                                   int loops_len,
                                                   int polys_len,
-                                                  struct CustomData_MeshMasks mask);
+                                                  struct CustomData_MeshMasks mask,
+                                                  enum eCDAllocType alloctype);
 
 void BKE_mesh_eval_delete(struct Mesh *me_eval);
 
diff --git a/source/blender/blenkernel/intern/mesh.c b/source/blender/blenkernel/intern/mesh.c
index 127acf0e464..aadd6d85293 100644
--- a/source/blender/blenkernel/intern/mesh.c
+++ b/source/blender/blenkernel/intern/mesh.c
@@ -727,7 +727,8 @@ Mesh *BKE_mesh_new_nomain_from_template_ex(const Mesh *me_src,
                                            int tessface_len,
                                            int loops_len,
                                            int polys_len,
-                                           CustomData_MeshMasks mask)
+                                           CustomData_MeshMasks mask,
+                                           enum eCDAllocType alloctype)
 {
   /* Only do tessface if we are creating tessfaces or copying from mesh with only tessfaces. */
   const bool do_tessface = (tessface_len || ((me_src->totface != 0) && (me_src->totpoly == 0)));
@@ -745,12 +746,12 @@ Mesh *BKE_mesh_new_nomain_from_template_ex(const Mesh *me_src,
   me_dst->cd_flag = me_src->cd_flag;
   BKE_mesh_copy_settings(me_dst, me_src);
 
-  CustomData_copy(&me_src->vdata, &me_dst->vdata, mask.vmask, CD_CALLOC, verts_len);
-  CustomData_copy(&me_src->edata, &me_dst->edata, mask.emask, CD_CALLOC, edges_len);
-  CustomData_copy(&me_src->ldata, &me_dst->ldata, mask.lmask, CD_CALLOC, loops_len);
-  CustomData_copy(&me_src->pdata, &me_dst->pdata, mask.pmask, CD_CALLOC, polys_len);
+  CustomData_copy(&me_src->vdata, &me_dst->vdata, mask.vmask, alloctype, verts_len);
+  CustomData_copy(&me_src->edata, &me_dst->edata, mask.emask, alloctype, edges_len);
+  CustomData_copy(&me_src->ldata, &me_dst->ldata, mask.lmask, alloctype, loops_len);
+  CustomData_copy(&me_src->pdata, &me_dst->pdata, mask.pmask, alloctype, polys_len);
   if (do_tessface) {
-    CustomData_copy(&me_src->fdata, &me_dst->fdata, mask.fmask, CD_CALLOC, tessface_len);
+    CustomData_copy(&me_src->fdata, &me_dst->fdata, mask.fmask, alloctype, tessface_len);
   }
   else {
     mesh_tessface_clear_intern(me_dst, false);
@@ -771,8 +772,14 @@ Mesh *BKE_mesh_new_nomain_from_template(const Mesh *me_src,
                                         int loops_len,
                                         int polys_len)
 {
-  return BKE_mesh_new_nomain_from_template_ex(
-      me_src, verts_len, edges_len, tessface_len, loops_len, polys_len, CD_MASK_EVERYTHING);
+  return BKE_mesh_new_nomain_from_template_ex(me_src,
+                                              verts_len,
+                                              edges_len,
+                                              tessface_len,
+                                              loops_len,
+                                              polys_len,
+                                              CD_MASK_EVERYTHING,
+                                              CD_CALLOC);
 }
 
 void BKE_mesh_eval_delete(struct Mesh *mesh_eval)
diff --git a/source/blender/blenkernel/intern/subdiv_mesh.c b/source/blender/blenkernel/intern/subdiv_mesh.c
index 6c9cd72363a..15173eb735e 100644
--- a/source/blender/blenkernel/intern/subdiv_mesh.c
+++ b/source/blender/blenkernel/intern/subdiv_mesh.c
@@ -506,8 +506,14 @@ static bool subdiv_mesh_topology_info(const SubdivForeachContext *foreach_contex
   mask.lmask &= ~CD_MASK_MULTIRES_GRIDS;
 
   SubdivMeshContext *subdiv_context = foreach_context->user_data;
-  subdiv_context->subdiv_mesh = BKE_mesh_new_nomain_from_template_ex(
-      subdiv_context->coarse_mesh, num_vertices, num_edges, 0, num_loops, num_polygons, mask);
+  subdiv_context->subdiv_mesh = BKE_mesh_new_nomain_from_template_ex(subdiv_context->coarse_mesh,
+                                                                     num_vertices,
+                                                                     num_edges,
+                                                                     0,
+                                                                     num_loops,
+                                                                     num_polygons,
+                                                                     mask,
+                                                                     CD_CALLOC);
   subdiv_mesh_ctx_cache_custom_data_layers(subdiv_context);
   subdiv_mesh_prepare_accumulator(subdiv_context, num_vertices);
   return true;
diff --git a/source/blender/modifiers/intern/MOD_array.c b/source/blender/modifiers/intern/MOD_array.c
index f8f8ea49676..729957949c6 100644
--- a/source/blender/modifiers/intern/MOD_array.c
+++ b/source/blender/modifiers/intern/MOD_array.c
@@ -499,9 +499,19 @@ static Mesh *arrayModifier_doArray(ArrayModifierData *amd,
   result_nloops = chunk_nloops * count + start_cap_nloops + end_cap_nloops;
   result_npolys = chunk_npolys * count + start_cap_npolys + end_cap_npolys;
 
+  /* If there are caps, we need to initialize the customdata values since they may not be copied.
+   * TODO: Initialize only customdatas that are not in the caps. */
+  eCDAllocType alloctype = (start_cap_mesh || end_cap_mesh) ? CD_DEFAULT : CD_CALLOC;
+
   /* Initialize a result dm */
-  result = BKE_mesh_new_nomain_from_template(
-      mesh, result_nverts, result_nedges, 0, result_nloops, result_npolys);
+  result = BKE_mesh_new_nomain_from_template_ex(mesh,
+                                                result_nverts,
+                                                result_nedges,
+                                                0,
+                                                result_nloops,
+                                                result_npolys,
+                                                CD_MASK_EVERYTHING,
+                                                alloctype);
   result_dm_verts = result->mvert;
 
   if (use_merge) {

But then we would have another problem. You cannot edit the skin radius of the vertices in the caps.

So that would not bring any advantage.
So it seems that there is no simple solution to this. And the code works as designed.

The problem here is that the skin radius of the caps' vertices are not initialized. This patch would allow them to be initialized: [P1292: Patch for #74598](https://archive.blender.org/developer/P1292.txt) ```diff diff --git a/source/blender/blenkernel/BKE_mesh.h b/source/blender/blenkernel/BKE_mesh.h index ae2f5231e25..34fb4fcacab 100644 --- a/source/blender/blenkernel/BKE_mesh.h +++ b/source/blender/blenkernel/BKE_mesh.h @@ -26,6 +26,7 @@ /* defines BLI_INLINE */ #include "BLI_compiler_compat.h" +enum eCDAllocType; struct BLI_Stack; struct BMEditMesh; struct BMesh; @@ -124,7 +125,8 @@ struct Mesh *BKE_mesh_new_nomain_from_template_ex(const struct Mesh *me_src, int tessface_len, int loops_len, int polys_len, - struct CustomData_MeshMasks mask); + struct CustomData_MeshMasks mask, + enum eCDAllocType alloctype); void BKE_mesh_eval_delete(struct Mesh *me_eval); diff --git a/source/blender/blenkernel/intern/mesh.c b/source/blender/blenkernel/intern/mesh.c index 127acf0e464..aadd6d85293 100644 --- a/source/blender/blenkernel/intern/mesh.c +++ b/source/blender/blenkernel/intern/mesh.c @@ -727,7 +727,8 @@ Mesh *BKE_mesh_new_nomain_from_template_ex(const Mesh *me_src, int tessface_len, int loops_len, int polys_len, - CustomData_MeshMasks mask) + CustomData_MeshMasks mask, + enum eCDAllocType alloctype) { /* Only do tessface if we are creating tessfaces or copying from mesh with only tessfaces. */ const bool do_tessface = (tessface_len || ((me_src->totface != 0) && (me_src->totpoly == 0))); @@ -745,12 +746,12 @@ Mesh *BKE_mesh_new_nomain_from_template_ex(const Mesh *me_src, me_dst->cd_flag = me_src->cd_flag; BKE_mesh_copy_settings(me_dst, me_src); - CustomData_copy(&me_src->vdata, &me_dst->vdata, mask.vmask, CD_CALLOC, verts_len); - CustomData_copy(&me_src->edata, &me_dst->edata, mask.emask, CD_CALLOC, edges_len); - CustomData_copy(&me_src->ldata, &me_dst->ldata, mask.lmask, CD_CALLOC, loops_len); - CustomData_copy(&me_src->pdata, &me_dst->pdata, mask.pmask, CD_CALLOC, polys_len); + CustomData_copy(&me_src->vdata, &me_dst->vdata, mask.vmask, alloctype, verts_len); + CustomData_copy(&me_src->edata, &me_dst->edata, mask.emask, alloctype, edges_len); + CustomData_copy(&me_src->ldata, &me_dst->ldata, mask.lmask, alloctype, loops_len); + CustomData_copy(&me_src->pdata, &me_dst->pdata, mask.pmask, alloctype, polys_len); if (do_tessface) { - CustomData_copy(&me_src->fdata, &me_dst->fdata, mask.fmask, CD_CALLOC, tessface_len); + CustomData_copy(&me_src->fdata, &me_dst->fdata, mask.fmask, alloctype, tessface_len); } else { mesh_tessface_clear_intern(me_dst, false); @@ -771,8 +772,14 @@ Mesh *BKE_mesh_new_nomain_from_template(const Mesh *me_src, int loops_len, int polys_len) { - return BKE_mesh_new_nomain_from_template_ex( - me_src, verts_len, edges_len, tessface_len, loops_len, polys_len, CD_MASK_EVERYTHING); + return BKE_mesh_new_nomain_from_template_ex(me_src, + verts_len, + edges_len, + tessface_len, + loops_len, + polys_len, + CD_MASK_EVERYTHING, + CD_CALLOC); } void BKE_mesh_eval_delete(struct Mesh *mesh_eval) diff --git a/source/blender/blenkernel/intern/subdiv_mesh.c b/source/blender/blenkernel/intern/subdiv_mesh.c index 6c9cd72363a..15173eb735e 100644 --- a/source/blender/blenkernel/intern/subdiv_mesh.c +++ b/source/blender/blenkernel/intern/subdiv_mesh.c @@ -506,8 +506,14 @@ static bool subdiv_mesh_topology_info(const SubdivForeachContext *foreach_contex mask.lmask &= ~CD_MASK_MULTIRES_GRIDS; SubdivMeshContext *subdiv_context = foreach_context->user_data; - subdiv_context->subdiv_mesh = BKE_mesh_new_nomain_from_template_ex( - subdiv_context->coarse_mesh, num_vertices, num_edges, 0, num_loops, num_polygons, mask); + subdiv_context->subdiv_mesh = BKE_mesh_new_nomain_from_template_ex(subdiv_context->coarse_mesh, + num_vertices, + num_edges, + 0, + num_loops, + num_polygons, + mask, + CD_CALLOC); subdiv_mesh_ctx_cache_custom_data_layers(subdiv_context); subdiv_mesh_prepare_accumulator(subdiv_context, num_vertices); return true; diff --git a/source/blender/modifiers/intern/MOD_array.c b/source/blender/modifiers/intern/MOD_array.c index f8f8ea49676..729957949c6 100644 --- a/source/blender/modifiers/intern/MOD_array.c +++ b/source/blender/modifiers/intern/MOD_array.c @@ -499,9 +499,19 @@ static Mesh *arrayModifier_doArray(ArrayModifierData *amd, result_nloops = chunk_nloops * count + start_cap_nloops + end_cap_nloops; result_npolys = chunk_npolys * count + start_cap_npolys + end_cap_npolys; + /* If there are caps, we need to initialize the customdata values since they may not be copied. + * TODO: Initialize only customdatas that are not in the caps. */ + eCDAllocType alloctype = (start_cap_mesh || end_cap_mesh) ? CD_DEFAULT : CD_CALLOC; + /* Initialize a result dm */ - result = BKE_mesh_new_nomain_from_template( - mesh, result_nverts, result_nedges, 0, result_nloops, result_npolys); + result = BKE_mesh_new_nomain_from_template_ex(mesh, + result_nverts, + result_nedges, + 0, + result_nloops, + result_npolys, + CD_MASK_EVERYTHING, + alloctype); result_dm_verts = result->mvert; if (use_merge) { ``` But then we would have another problem. You cannot edit the skin radius of the vertices in the caps. ![image.png](https://archive.blender.org/developer/F8399715/image.png) So that would not bring any advantage. So it seems that there is no simple solution to this. And the code works as designed.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Skin Modifier not applied to Array Modifier Start & End Caps #74598