Key Indicator for motion paths not updating for objects #74605

New Issue

CobraA · 2020-03-10T05:38:57+01:00

CobraA commented

2020-03-10 05:38:57 +01:00

System Information
Windows 10 64 Bits.
Graphics card GeForce GTX 1080 Ti.

Blender Version
Broken: version: 2.82.7 and 2.83.7 hash: 04e9ba7169
Worked: 2.81 & 2.80

Short description of error
Key indicator or whatever it's called doesn't update realtime for none armature objects, I remembered that it worked in 2.81 & 2.80 for most objects,if you have Autokey on and set motion paths then you can move the indicator of that key and preview where it could be in the next position.

{F8398477 size = full}
Exact steps for others to reproduce the error
Open the file and move the sphere and see that the key indicator doesn't come along, only after mouse release.
But when you move the bone the indicator comes along in the correct way.

I tested the file in 2.80,2.81,.2.82 and 2.83 and the last two versions seems the behavior has changed.
Bug or not that's the question.
Anim.blend

**System Information** Windows 10 64 Bits. Graphics card GeForce GTX 1080 Ti. **Blender Version** Broken: version: 2.82.7 and 2.83.7 hash: 04e9ba7169c0 Worked: 2.81 & 2.80 **Short description of error** Key indicator or whatever it's called doesn't update realtime for none armature objects, I remembered that it worked in 2.81 & 2.80 for most objects,if you have Autokey on and set motion paths then you can move the indicator of that key and preview where it could be in the next position. {[F8398477](https://archive.blender.org/developer/F8398477/Key.gif) size = full} **Exact steps for others to reproduce the error** Open the file and move the sphere and see that the key indicator doesn't come along, only after mouse release. But when you move the bone the indicator comes along in the correct way. I tested the file in 2.80,2.81,.2.82 and 2.83 and the last two versions seems the behavior has changed. Bug or not that's the question. [Anim.blend](https://archive.blender.org/developer/F8398486/Anim.blend)

CobraA commented

2020-03-10 05:38:57 +01:00

Added subscriber: @CobraA

Philipp Oeser commented

2020-03-10 13:43:17 +01:00

Added subscribers: @Sergey, @dr.sybren, @lichtwerk

Philipp Oeser commented

2020-03-10 13:43:17 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-03-10 13:43:17 +01:00

Can confirm (for me, 2.80 works, 2.81 already has this issue though).

Not sure if we keep this report open (or how to classify), since we have this on the list (and for bones this 'live' preview only affects the current frame -- which seems of limited use anyways?):

#68901 ( Motion path viewport editing)
#68905 (Motion path revamp)

CC @dr.sybren
CC @Sergey

Can confirm (for me, 2.80 works, 2.81 already has this issue though). Not sure if we keep this report open (or how to classify), since we have this on the list (and for bones this 'live' preview only affects the current frame -- which seems of limited use anyways?): - #68901 ( Motion path viewport editing) - #68905 (Motion path revamp) CC @dr.sybren CC @Sergey

Sybren A. Stüvel commented

2020-03-12 10:28:38 +01:00

@CobraA Thanks for testing with various versions of Blender, that makes it much easier to pinpoint the issue.

Testing the file in 2.80, it shows different motion path problems, so my guess is that the reported behaviour was introduced in a change that actually fixed other issues.

I did some digging, and it seems that this is caused by 4db2a08281. That changed the parameter current_frame_only=true to range=xxxxx_CURRENT_FRAME for bones but range=xxxxx_CHANGED for objects. As animviz_calc_motionpaths() only updates the motion path for the current frame if range=xxxxx_CURRENT_FRAME, this introduced the observed difference between the handling of bones and objects.

This issue can be fixed by this change:

diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c
index bb4d50fcf54..716df24f195 100644
--- a/source/blender/editors/transform/transform_generics.c
+++ b/source/blender/editors/transform/transform_generics.c
@@ -1102,7 +1102,7 @@ static void recalcData_objects(TransInfo *t)
 
     if (motionpath_update) {
       /* Update motion paths once for all transformed objects. */
-      ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CHANGED);
+      ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CURRENT_FRAME);
     }
 
     if (t->options & CTX_OBMODE_XFORM_SKIP_CHILDREN) {

I'll discuss with @Sergey to see if this is the appropriate fix.

@CobraA Thanks for testing with various versions of Blender, that makes it much easier to pinpoint the issue. Testing the file in 2.80, it shows different motion path problems, so my guess is that the reported behaviour was introduced in a change that actually fixed other issues. I did some digging, and it seems that this is caused by 4db2a08281. That changed the parameter `current_frame_only=true` to `range=xxxxx_CURRENT_FRAME` for bones but `range=xxxxx_CHANGED` for objects. As `animviz_calc_motionpaths()` only updates the motion path for the current frame if `range=xxxxx_CURRENT_FRAME`, this introduced the observed difference between the handling of bones and objects. This issue can be fixed by this change: ``` diff --git a/source/blender/editors/transform/transform_generics.c b/source/blender/editors/transform/transform_generics.c index bb4d50fcf54..716df24f195 100644 --- a/source/blender/editors/transform/transform_generics.c +++ b/source/blender/editors/transform/transform_generics.c @@ -1102,7 +1102,7 @@ static void recalcData_objects(TransInfo *t) if (motionpath_update) { /* Update motion paths once for all transformed objects. */ - ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CHANGED); + ED_objects_recalculate_paths(t->context, t->scene, OBJECT_PATH_CALC_RANGE_CURRENT_FRAME); } if (t->options & CTX_OBMODE_XFORM_SKIP_CHILDREN) { ``` I'll discuss with @Sergey to see if this is the appropriate fix.

Sergey Sharybin commented

2020-03-12 10:50:04 +01:00

@dr.sybren, good find! Just commit it ;)

Sybren A. Stüvel changed title from ~~Key Indicator for motion paths not updating for non-armature objects.~~ to Key Indicator for motion paths not updating for objects

2020-03-12 11:07:32 +01:00

Sybren A. Stüvel self-assigned this 2020-03-12 11:08:25 +01:00

blender-admin commented

2020-03-12 11:08:45 +01:00

This issue was referenced by 6c707aad6a

This issue was referenced by 6c707aad6a2e0cc6f5d3b561c32fabc2663cdb0e

Sybren A. Stüvel commented

2020-03-12 11:09:09 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2020-03-12 11:09:09 +01:00

CobraA commented

2020-03-12 16:56:16 +01:00

@dr.sybren My pleasure, Thank you for taking the time to take a look at it.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Key Indicator for motion paths not updating for objects #74605