Grease Pencil will not create new keyframe when using eraser tool #74608

Closed
opened 2020-03-10 09:11:35 +01:00 by Pierson Mason · 16 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13571 Core Profile Context 19.9.2 26.20.13003.1007

Blender Version
Broken: version: 2.83 (sub 7), branch: master, commit date: 2020-03-09 22:23, hash: fbe81db29a
Worked: 2.82{F8398631}

Short description of error
Instead of Creating a new Keyframe in grease Pencil When using the eraser tool, Changes made to the Drawing will be applied to the previous keyframe

Exact steps for others to reproduce the error

  1. from the splash screen open a 2D animation new File
  2. use the draw tool to draw as realistic a dragon you can
  3. advance at least one frame and us the erase tool on your drawing
  • this should result in the keyframe closest previous keyframe being edited rather than creating a new keyframe like it would in 2.8
**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13571 Core Profile Context 19.9.2 26.20.13003.1007 **Blender Version** Broken: version: 2.83 (sub 7), branch: master, commit date: 2020-03-09 22:23, hash: `fbe81db29a` Worked: 2.82{[F8398631](https://archive.blender.org/developer/F8398631/GreasePencilKeyframeBug_2.83.blend)} **Short description of error** Instead of Creating a new Keyframe in grease Pencil When using the eraser tool, Changes made to the Drawing will be applied to the previous keyframe **Exact steps for others to reproduce the error** 1. from the splash screen open a 2D animation new File 2. use the draw tool to draw as realistic a dragon you can 3. advance at least one frame and us the erase tool on your drawing - this should result in the keyframe closest previous keyframe being edited rather than creating a new keyframe like it would in 2.8
Author

Added subscriber: @SpikedPie

Added subscriber: @SpikedPie

Added subscribers: @mendio, @pepe-school-land, @antoniov

Added subscribers: @mendio, @pepe-school-land, @antoniov

This was a design decission. Before when you used the eraser you could create a new frame, but now the eraser never creates a new frame, only erase the existing one. There are a lot of implications in this decission.

@mendio @pepe-school-land We decided to go in this way, but we could consider a change here? how?

This was a design decission. Before when you used the eraser you could create a new frame, but now the eraser never creates a new frame, only erase the existing one. There are a lot of implications in this decission. @mendio @pepe-school-land We decided to go in this way, but we could consider a change here? how?

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author

Could the eraser tool adding keyframes be added as a selectable option? It'd be similar to how the additive animation option works with the draw tool.

It's uncomfortable to have to reach up and go through the options to duplicate the frame when I'm used to just clicking my eraser's hot key. I'd be grateful to At least have the "old method" available as an option, like how you can still use right click select.

I love the new options grease pencil has and appreciate all the work that had gone into making it more powerful. Thank you guys for considering this

Could the eraser tool adding keyframes be added as a selectable option? It'd be similar to how the additive animation option works with the draw tool. It's uncomfortable to have to reach up and go through the options to duplicate the frame when I'm used to just clicking my eraser's hot key. I'd be grateful to At least have the "old method" available as an option, like how you can still use right click select. I love the new options grease pencil has and appreciate all the work that had gone into making it more powerful. Thank you guys for considering this

You could use the I key to duplicate frame:

image.png

You could use the `I` key to duplicate frame: ![image.png](https://archive.blender.org/developer/F8400435/image.png)

Yes, basically that kind of functionality is centralized in the I key menu

Yes, basically that kind of functionality is centralized in the `I` key menu

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Antonio Vazquez self-assigned this 2020-03-11 17:15:29 +01:00

Thanks for your report. As this is a design decission and not a bug, due the tracker policy I have to close the task report.

Thanks for your report. As this is a design decission and not a bug, due the tracker policy I have to close the task report.
(Deleted) commented 2020-05-19 22:10:20 +02:00 (Migrated from localhost:3001)

Added subscriber: @(Deleted)

Added subscriber: @(Deleted)
(Deleted) commented 2020-05-19 22:10:20 +02:00 (Migrated from localhost:3001)

I hope this is the right place to talk about it:

TL;DR: Automatically create a new frame when using the eraser was saving a lot of time.

Let's say we have the grease pencil drawing of someone from torso to head. The GP is composed of 2 layers: one for lines, one for fills.

Now we want to have this character's head turn to the right.

Old workflow (assuming "auto-lock inactive layer" is checked):

  • go to a new frame, hide fills
  • erase from neck to the top of the head
  • draw new keyframe
  • unhide fills and select this layer
  • erase everything that's not within the lines
  • fill
    Done.

New workflow:

  • Go to a new frame, hide fills
  • go to draw -> animation -> insert keyframe
  • erase from neck to the top of the head
  • draw new keyframe
  • unhide fills and select this layer
  • click on "isolate layer" so you won't erase lines
  • erase everything that's not within the lines
  • fill
  • unisolate layer
    Done.

The new workflow, even with quick favorite shortcuts, implies actions that weren't necessary before. Moreover, this requires to have 4 quick favorite shortcuts and plan ahead a lot more than before to know whether you have to duplicate all layers or just one or create a blank frame of all layers or just one.

With the old workflow you just had to erase lines on a layer. Then fill or not. There was no need to plan any further

If fills are not needed, no keyframe were created for fills. So you didn't have to eliminate keyframe or plan ahead. In other words, the old workflow was perfectly straightforward.

It might be that my workflow is wrong on some levels. I am open to critics and would like to learn if I can do better. I thank you for your time (and for the grease pencil and the refactor, which are remarkable works that I am now using daily).

I hope this is the right place to talk about it: TL;DR: Automatically create a new frame when using the eraser was saving a lot of time. Let's say we have the grease pencil drawing of someone from torso to head. The GP is composed of 2 layers: one for lines, one for fills. Now we want to have this character's head turn to the right. Old workflow (assuming "auto-lock inactive layer" is checked): - go to a new frame, hide fills - erase from neck to the top of the head - draw new keyframe - unhide fills and select this layer - erase everything that's not within the lines - fill Done. New workflow: - Go to a new frame, hide fills - go to draw -> animation -> insert keyframe - erase from neck to the top of the head - draw new keyframe - unhide fills and select this layer - click on "isolate layer" so you won't erase lines - erase everything that's not within the lines - fill - unisolate layer Done. The new workflow, even with quick favorite shortcuts, implies actions that weren't necessary before. Moreover, this requires to have 4 quick favorite shortcuts and plan ahead a lot more than before to know whether you have to duplicate all layers or just one or create a blank frame of all layers or just one. With the old workflow you just had to erase lines on a layer. Then fill or not. There was no need to plan any further If fills are not needed, no keyframe were created for fills. So you didn't have to eliminate keyframe or plan ahead. In other words, the old workflow was perfectly straightforward. It might be that my workflow is wrong on some levels. I am open to critics and would like to learn if I can do better. I thank you for your time (and for the grease pencil and the refactor, which are remarkable works that I am now using daily).

@Braisque I have added a patch with a fix for your request. Pending of review.

@Braisque I have added a patch with a fix for your request. Pending of review.

This issue was referenced by 29afadcb15

This issue was referenced by 29afadcb15f71119f70f77bcf32c8e54c7614576
(Deleted) commented 2020-05-21 17:37:13 +02:00 (Migrated from localhost:3001)

@antoniov Thank you so much!

@antoniov Thank you so much!

Added subscriber: @jamiroguy

Added subscriber: @jamiroguy

This comment was removed by @jamiroguy

*This comment was removed by @jamiroguy*
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#74608
No description provided.