Incorrect mixing in Glare node #74680

Closed
opened 2020-03-12 13:02:10 +01:00 by Marcin Twarowski · 11 comments

System Information
Operating system: Windows-10-10.0.16299-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.86

Blender Version
Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-12 00:33, hash: 8751af6d19
Worked: Never (2.79+)

Short description of error
Glare node with mix between -1 and 0 will brighten entire image

Exact steps for others to reproduce the error

See attached file:
glare_bug.blend
First set Mix value to 1 and render to see only effect

  • Setting Mix to 0 is supposed to give a middle point between original and processed image. You can see that the background is not brightened:

  • Render image.
    glare_bug_02.png

  • Mix set to -1 essentially disables glare. The background is also not brightened:

  • Render image.
    glare_bug_03.png

  • Set Mix is set to -0.5

  • Render image. You can see that glare brightened entire image - this should not happen
    glare_bug_01.png

**System Information** Operating system: Windows-10-10.0.16299-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.86 **Blender Version** Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-12 00:33, hash: `8751af6d19` Worked: Never (2.79+) **Short description of error** Glare node with mix between -1 and 0 will brighten entire image **Exact steps for others to reproduce the error** See attached file: [glare_bug.blend](https://archive.blender.org/developer/F8402170/glare_bug.blend) First set **Mix** value to 1 and render to see only effect - Setting **Mix** to **0** is supposed to give a middle point between original and processed image. You can see that the background is not brightened: - Render image. ![glare_bug_02.png](https://archive.blender.org/developer/F8402176/glare_bug_02.png) - **Mix** set to **-1** essentially disables glare. The background is also not brightened: - Render image. ![glare_bug_03.png](https://archive.blender.org/developer/F8402178/glare_bug_03.png) - Set **Mix** is set to **-0.5** - Render image. You can see that glare brightened entire image - this should not happen ![glare_bug_01.png](https://archive.blender.org/developer/F8402171/glare_bug_01.png)

Added subscriber: @MarcinTwarowski

Added subscriber: @MarcinTwarowski

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'

I don't understand what the issue is here.
The mix is between -1 and 1.

A value of -1 would give just the original image, 0 gives a 50/50 mix, and 1 gives just the effect.

The images you showed show what Glare is intended to do.

The Glare node is used to add lens flares, fog, glows around exposed parts of an image and much more.

source

I don't understand what the issue is here. The mix is between -1 and 1. > A value of -1 would give just the original image, 0 gives a 50/50 mix, and 1 gives just the effect. The images you showed show what Glare is intended to do. > The Glare node is used to add lens flares, fog, glows around exposed parts of an image and much more. [source ](https://docs.blender.org/manual/en/dev/compositing/types/filter/glare.html)

At Mix -0.5, the background is brightened, when only the emmisive part should be. Quickly switch between first two images. At mix = 0 it does not happen.

At Mix -0.5, the background is brightened, when only the emmisive part should be. Quickly switch between first two images. At mix = 0 it does not happen.

Added subscriber: @iss

Added subscriber: @iss

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'

I can confirm this

If you render with mix of 1, you will see, that no brightening near image edges should happen here

I can confirm this If you render with mix of 1, you will see, that no brightening near image edges should happen here
Richard Antalik changed title from Glare node brightens entire image when mix is between -1 and 0 to Incorrect mixing in Glare node 2020-03-12 17:47:24 +01:00

Added subscriber: @szulat

Added subscriber: @szulat

This issue was referenced by 95e010a22e

This issue was referenced by 95e010a22eb422a1efa2f7e2bbb6b3ee168ce9e5
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Jeroen Bakker self-assigned this 2021-04-12 14:42:43 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#74680
No description provided.