Rendering workspace: Slot, View Layer & Combined drop downs, displaying label before data. #74690

Closed
opened 2020-03-12 18:46:43 +01:00 by Adrian Newton · 6 comments

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1660/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.59

Blender Version
Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-12 16:33, hash: 38ba022858

Less of a Bug, more of a task I think.

  1. Render Default Cube.
  2. Go to Rendering workspace.
  3. Select either the Slot1, View Layer or Combined drop downs.

You should get this:
Render_top.png

If you flip the header to the bottom, you get this:
Render_bottom.png

I have looked around and the issue lies in Blender\Editors\space_image\image_buttons.c

  1. I would like to take a look at resolving this &
  2. The Slot drop down list, displays information in the order of Slot 8 -> Slot 1. I wonder if it would be better if the order was Slot 1 -> Slot 8 (Personal Preference)?
    If so I would like to tackle this as well.
**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 1660/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.59 **Blender Version** Broken: version: 2.83 (sub 8), branch: master, commit date: 2020-03-12 16:33, hash: `38ba022858` Less of a Bug, more of a task I think. 1. Render Default Cube. 2. Go to Rendering workspace. 3. Select either the Slot1, View Layer or Combined drop downs. You should get this: ![Render_top.png](https://archive.blender.org/developer/F8402556/Render_top.png) If you flip the header to the bottom, you get this: ![Render_bottom.png](https://archive.blender.org/developer/F8402560/Render_bottom.png) I have looked around and the issue lies in Blender\Editors\space_image\image_buttons.c 1. I would like to take a look at resolving this & 2. The Slot drop down list, displays information in the order of Slot 8 -> Slot 1. I wonder if it would be better if the order was Slot 1 -> Slot 8 (Personal Preference)? If so I would like to tackle this as well.
Author

Added subscriber: @TheJanitor

Added subscriber: @TheJanitor
Author

The following Diff resolves the issue of the Labels being in the wrong place, Point 1. above.

Slot-View Layer-Combined_Label Fix.diff

If you wish me to submit another patch to change the Slot display order from it's current Slot 8 -> Slot 1 order, to Slot 1 -> Slot 8, then let me know,

The following Diff resolves the issue of the Labels being in the wrong place, Point 1. above. [Slot-View Layer-Combined_Label Fix.diff](https://archive.blender.org/developer/F8403594/Slot-View_Layer-Combined_Label_Fix.diff) If you wish me to submit another patch to change the Slot display order from it's current Slot 8 -> Slot 1 order, to Slot 1 -> Slot 8, then let me know,

Added subscribers: @WilliamReynish, @iss

Added subscribers: @WilliamReynish, @iss

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Richard Antalik self-assigned this 2020-03-13 15:06:28 +01:00

@TFM please use https://developer.blender.org/differential/diff/create/ to post patches.
I would recommend to look at https://wiki.blender.org/wiki/Tools/CodeReview as general guide
You can tag perhaps @WilliamReynish as a reviewer. Or tag #user_interface project in general

In general I recommend to get in touch with developer before working on new features, so your work is not for nothing.

Unless this is agreed to be worked on I will close this report, because it is not a bug.

@TFM please use https://developer.blender.org/differential/diff/create/ to post patches. I would recommend to look at https://wiki.blender.org/wiki/Tools/CodeReview as general guide You can tag perhaps @WilliamReynish as a reviewer. Or tag #user_interface project in general In general I recommend to get in touch with developer before working on new features, so your work is not for nothing. Unless this is agreed to be worked on I will close this report, because it is not a bug.
Author

Thanks. I shall submit using Diff mechanism as you suggest.

Thanks. I shall submit using Diff mechanism as you suggest.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#74690
No description provided.