Dopesheet in cache file mode - Type Error val:enum "DRAW_POLY" not found in ... #74921

New Issue

Reiner Prokein · 2020-03-19T11:45:07+01:00

Reiner Prokein commented

2020-03-19 11:45:07 +01:00

Blender Version
Broken: version: 2.79, 2.80rc1, 2.82a, 2.83 (sub 8), branch: master, commit date: 2020-03-13 11:24, hash: cf9b3310c0
Worked: Probably since the Cache File mode was added

Short description of error
Switching in Dopesheet editor to Cache File mode thows an error in the console.

Exact steps for others to reproduce the error

Open Blender.
Switch to Animation workspace
In the Dope Sheet eidtor change the Editing context to Cache File.
Watch the console.

**Blender Version** Broken: version: 2.79, 2.80rc1, 2.82a, 2.83 (sub 8), branch: master, commit date: 2020-03-13 11:24, hash: `cf9b3310c0` Worked: Probably since the `Cache File` mode was added **Short description of error** Switching in Dopesheet editor to Cache File mode thows an error in the console. ![cachefile.jpg](https://archive.blender.org/developer/F8415559/cachefile.jpg) **Exact steps for others to reproduce the error** - Open Blender. - Switch to Animation workspace - In the `Dope Sheet` eidtor change the Editing context to `Cache File`. - Watch the console.

Reiner Prokein commented

2020-03-19 11:45:07 +01:00

Added subscriber: @tiles

Germano Cavalcante commented

2020-03-19 19:06:11 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sebastian Parborg commented

2020-03-23 20:18:42 +01:00

Added subscribers: @dr.sybren, @ZedDB

Sebastian Parborg commented

2020-03-23 20:18:42 +01:00

@dr.sybren I looked into this and the issue is that in blender/source/blender/editors/animation/anim_filter.c:211 we say that the thing we want to filter is a ANIMCONT_CHANNEL but instead of assigning a channel to the data variable we assign the bDopeSheet data.

This obviously leads to issues in animdata_filter_animchan where it gets a bDopeSheet instead of a bAnimListElem. (We do infact already have a pointer to the dopesheet data at this point as well, so this function gets the same dopesheet pointer twice in different variables *ads and *channel)

However, I do not see and easy solution to this as it seems like there are no cache channels stored. Instead these are created on the fly in animdata_filter_ds_cachefile which would be called if the dope sheet summary view was used.
This would also be called if the animdata_filter_animchan call succeeded, which seems wrong to me as we would in this case already have a channel containing the cache data.

So to me it seems like the code to make this work is simply missing and it might not have worked at all?

To me, it seems like we would have to make a ANIMCONT_CACHE enum or something to make this work. Simply having it be bundled with ANIMCONT_CHANNEL will not work with the current way the data is stored I guess.

@dr.sybren I looked into this and the issue is that in `blender/source/blender/editors/animation/anim_filter.c:211` we say that the thing we want to filter is a `ANIMCONT_CHANNEL` but instead of assigning a channel to the `data` variable we assign the `bDopeSheet` data. This obviously leads to issues in `animdata_filter_animchan` where it gets a `bDopeSheet` instead of a `bAnimListElem`. (We do infact already have a pointer to the dopesheet data at this point as well, so this function gets the same dopesheet pointer twice in different variables *ads and *channel) However, I do not see and easy solution to this as it seems like there are no cache channels stored. Instead these are created on the fly in `animdata_filter_ds_cachefile` which would be called if the dope sheet summary view was used. This would also be called if the `animdata_filter_animchan` call succeeded, which seems wrong to me as we would in this case already have a channel containing the cache data. So to me it seems like the code to make this work is simply missing and it might not have worked at all? To me, it seems like we would have to make a `ANIMCONT_CACHE` enum or something to make this work. Simply having it be bundled with `ANIMCONT_CHANNEL` will not work with the current way the data is stored I guess.

Sybren A. Stüvel commented

2020-03-24 09:41:17 +01:00

In #74921#896841, @ZedDB wrote:
So to me it seems like the code to make this work is simply missing and it might not have worked at all?

That seems to be it. The manual, it is "documented" as "Cache File: Alembic Todo 2.78". 2.78 was the version in which Alembic was introduced, so this never worked.

To me, it seems like we would have to make a ANIMCONT_CACHE enum or something to make this work.

That makes sense, yes.

I think the use of the dope sheet will have to be re-evaluated for #73363 (Alembic / USD) milestone 4 anyway. I think for now it's fine to keep things as they are. I mean, it's been in there for three years and it's just a message (no crash/data loss).

> In #74921#896841, @ZedDB wrote: > So to me it seems like the code to make this work is simply missing and it might not have worked at all? That seems to be it. [The manual](https://docs.blender.org/manual/en/dev/editors/dope_sheet/introduction.html#dope-sheet-modes), it is "documented" as "Cache File: Alembic Todo 2.78". 2.78 was the version in which Alembic was introduced, so this never worked. > To me, it seems like we would have to make a ANIMCONT_CACHE enum or something to make this work. That makes sense, yes. I think the use of the dope sheet will have to be re-evaluated for #73363 (Alembic / USD) milestone 4 anyway. I think for now it's fine to keep things as they are. I mean, it's been in there for three years and it's just a message (no crash/data loss).

Sebastian Parborg commented

2020-03-24 10:29:41 +01:00

I agree, let's keep it as is until the Alembic/USD cache is further along.

Julian Eisel commented

2020-09-05 16:18:15 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2020-09-05 16:18:15 +02:00

I will mark this as Known Issue for the UI team workboard, but I'll leave the actual classification up to you.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Dopesheet in cache file mode - Type Error val:enum "DRAW_POLY" not found in ... #74921