Page MenuHome

Crash: Divide By Zero with workbench depth of field when antialiasing disabled
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.74

Blender Version
Broken: version: 2.83 (sub 10), branch: master, commit date: 2020-03-21 20:58, hash: rB9e8afa8817ed
Broken: version: 2.83 (sub 9), branch: master, commit date: 2020-03-14 18:05, hash: rBa210b8297f5a
Worked: version: 2.83 (sub 7), branch: master, commit date: 2020-03-09 22:23, hash: rBfbe81db29a28

Short description of error
Disabling antialiasing causes workbench depth of field to crash blender.

Exact steps for others to reproduce the error
With factory settings:

  1. Set Viewport Anti-Aliasing to "No Antialiasing"
  2. View -> Cameras -> Active Camera
  3. Enable Depth of Field in Viewport Shading
  4. Enable Camera Depth of Field in Active Camera Object Data Properties

Event Timeline

Robert Guetzkow (rjg) changed the task status from Needs Triage to Confirmed.Wed, Mar 25, 10:21 PM
Robert Guetzkow (rjg) triaged this task as High priority.

In float offset = wpd->taa_sample / wpd->taa_sample_len; the taa_sample_len is zero.

workbench_dof_cache_init(WORKBENCH_Data * vedata) Line 329	C
workbench_cache_init(void * ved) Line 96	C
drw_engines_cache_init() Line 963	C
DRW_draw_render_loop_ex(Depsgraph * depsgraph, RenderEngineType * engine_type, ARegion * region, View3D * v3d, GPUViewport * viewport, const bContext * evil_C) Line 1468	C
DRW_draw_view(const bContext * C) Line 1400	C
view3d_draw_view(const bContext * C, ARegion * region) Line 1603	C
view3d_main_region_draw(const bContext * C, ARegion * region) Line 1628	C
ED_region_do_draw(bContext * C, ARegion * region) Line 539	C
wm_draw_window_offscreen(bContext * C, wmWindow * win, bool stereo) Line 669	C
wm_draw_window(bContext * C, wmWindow * win) Line 795	C
wm_draw_update(bContext * C) Line 997	C
WM_main(bContext * C) Line 454	C
main(int argc, const unsigned char * * UNUSED_argv_c) Line 526	C

@Robert Guetzkow (rjg), for a bug to be confirmed, it must also be tagged with the relevent module project, otherwise it's not fully triaged.

If it's high priority or likely caused by a recent change, CC the relevant developer as well.

@Brecht Van Lommel (brecht) That was unintentional, I somehow forgot to tag the project.

The change was introduced by @Clément Foucault (fclem) 's workbench refactor c476c36e400883d929a7149def8dcb6ad6157a86.

Brecht Van Lommel (brecht) changed the subtype of this task from "Report" to "Bug".Thu, Mar 26, 11:40 AM