Exported key configuration set is not sorted #75355

New Issue

Roman Kornev · 2020-04-03T18:35:49+02:00

Roman Kornev commented

2020-04-03 18:35:49 +02:00

System Information
Operating system: Win10 x64
Graphics card: GTX 1080Ti

Blender Version
Broken: 2.82a
Worked: (newest version of Blender that worked as expected)

Short description of error
Easy fix.
Right now, the exported key configuration set is NOT sorted. Which makes it extremely difficult to compare different key sets, because the order constantly changes.
A simple piece of code like sorted(keyconfig_data) before exporting should do the trick.
Since the order of items in that file has no effect on importing, I see no downside to this.

Exact steps for others to reproduce the error
Open any keymap
Click Export
The exported list is not alphabetically sorted by the first tuple value.

**System Information** Operating system: Win10 x64 Graphics card: GTX 1080Ti **Blender Version** Broken: 2.82a Worked: (newest version of Blender that worked as expected) **Short description of error** Easy fix. Right now, the exported key configuration set is NOT sorted. Which makes it extremely difficult to compare different key sets, because the order constantly changes. A simple piece of code like `sorted(keyconfig_data)` before exporting should do the trick. Since the order of items in that file has no effect on importing, I see no downside to this. **Exact steps for others to reproduce the error** Open any keymap Click Export The exported list is not alphabetically sorted by the first tuple value.

Roman Kornev commented

2020-04-03 18:35:49 +02:00

Added subscriber: @RomanKornev

Ankit Meel commented

2020-04-05 12:29:12 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-05 12:29:12 +02:00

https://developer.blender.org/diffusion/B/browse/master/release/scripts/modules/bl_keymap_utils/io.py$131

Roman Kornev commented

2020-04-05 13:04:16 +02:00

Looking at current issues in https://developer.blender.org/T68884:

The ability to re-order key-map items.

This is important as key-map items are handled in the order listed, with some items passing on to key-map items defined afterwards.

If key-map items are handled in order without the ability to change that order in the UI, then we can't quite sort everything.
But we can sort the top-level groups like 'Window', 'Screen', '3D View' between each other, since they will never conflict, but their order is still random currently.

I've implemented the change locally, and the performance impact is non-existant on my machine, because the top-level list has only about 200 items.

Looking at current issues in https://developer.blender.org/T68884: > The ability to re-order key-map items. > > This is important as key-map items are handled in the order listed, with some items passing on to key-map items defined afterwards. If key-map items are handled in order without the ability to change that order in the UI, then we can't quite sort everything. But we can sort the top-level groups like 'Window', 'Screen', '3D View' between each other, since they will never conflict, but their order is still random currently. I've implemented the change locally, and the performance impact is non-existant on my machine, because the top-level list has only about 200 items.

Ankit Meel commented

2020-04-05 13:06:09 +02:00

you may submit a patch though.
https://developer.blender.org/differential/diff/create/

you may submit a patch though. https://developer.blender.org/differential/diff/create/

Roman Kornev commented

2020-04-05 13:39:10 +02:00

Thanks! I'm still learning how to contribute.