File browser should accept full paths in file input #75376

Closed
opened 2020-04-04 13:42:32 +02:00 by Frankie Hobbins · 14 comments

System Information
Operating system: windows 10
Graphics card: 2080ti

Blender Version
Broken: 2.82 Windows
Worked: 2.82 Linux

Short description of error
The file browser used to load and save files has its file path split up into 2 parts. The top of the window has a section for the folder and the bottom has a section for the filename.

To be standard with other window applications it should be possible to do everything with the bottom "file" input.

In the bottom input section user should be able to;

  • Type/paste a directory (C:\Assets\House) in and open that folder
  • Type/paste a full filepath (C:\Assets\House\Door.blend) in and save to that file

My apologies if this is not a bug, initially I put it on rightclickselect as a feature but someone commented saying it worked in linux so therefore may be considered a bug.
https://blender.community/c/rightclickselect/drfbbc/#5e6e02a69c1221214ad66b4a

Exact steps for others to reproduce the error
While in windows, start blender and try to save the file by typing the whole path into the bottom file input. eg "C:\folder\file.blend"
Notice how it will save to "C:\folder\file.blend\untitled.blend"

**System Information** Operating system: windows 10 Graphics card: 2080ti **Blender Version** Broken: 2.82 Windows Worked: 2.82 Linux **Short description of error** The file browser used to load and save files has its file path split up into 2 parts. The top of the window has a section for the folder and the bottom has a section for the filename. To be standard with other window applications it should be possible to do everything with the bottom "file" input. In the bottom input section user should be able to; - Type/paste a directory (C:\Assets\House) in and open that folder - Type/paste a full filepath (C:\Assets\House\Door.blend) in and save to that file My apologies if this is not a bug, initially I put it on rightclickselect as a feature but someone commented saying it worked in linux so therefore may be considered a bug. https://blender.community/c/rightclickselect/drfbbc/#5e6e02a69c1221214ad66b4a **Exact steps for others to reproduce the error** While in windows, start blender and try to save the file by typing the whole path into the bottom file input. eg "C:\folder\file.blend" Notice how it will save to "C:\folder\file.blend\untitled.blend"

Added subscriber: @FrankieHobbins

Added subscriber: @FrankieHobbins

#71346 was marked as duplicate of this issue

#71346 was marked as duplicate of this issue

#89043 was marked as duplicate of this issue

#89043 was marked as duplicate of this issue
Ankit Meel changed title from File browser should accept full paths in file input to File browser should accept full paths in file input like in Linux 2020-04-05 13:12:10 +02:00

Added subscriber: @bent

Added subscriber: @bent

Added subscribers: @LazyDodo, @mont29

Added subscribers: @LazyDodo, @mont29

Likely some bad handling of the backslash path separator here? Anyway, would be easier for some windows dev to investigate this… gentle poke at @LazyDodo ;)

Otherwise will have to spend some time dusting off again my VM and whole blender build chain there. ;)

Likely some bad handling of the backslash path separator here? Anyway, would be easier for some windows dev to investigate this… gentle poke at @LazyDodo ;) Otherwise will have to spend some time dusting off again my VM and whole blender build chain there. ;)
Member

I always assumed this was because blender cut the path (upper part of the dialog) and filename (bottom part of the dialog) into two separate things unlike any file dialog on this platform.

The filename part is being run though BLI_filename_make_safe in file_filename_enter_handle which replaces all 'bad characters' with an underscore (including /) we sure this is actually working on linux?

I always assumed this was because blender cut the path (upper part of the dialog) and filename (bottom part of the dialog) into two separate things unlike any file dialog on this platform. The filename part is being run though `BLI_filename_make_safe` in `file_filename_enter_handle` which replaces all 'bad characters' with an underscore (including `/`) we sure this is actually working on linux?
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

@LazyDodo : nope, this is the same on linux (at least for me) -- forward slashes replace by underscore.
Not sure this is really a bug?

@LazyDodo : nope, this is the same on linux (at least for me) -- forward slashes replace by underscore. Not sure this is really a bug?

Added subscriber: @ZedDB

Added subscriber: @ZedDB

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Sebastian Parborg self-assigned this 2020-04-06 17:53:17 +02:00

This is not a bug as the bottom field is only intended for filename input. (At least currently)

This is not a bug as the bottom field is only intended for filename input. (At least currently)
Ankit Meel changed title from File browser should accept full paths in file input like in Linux to File browser should accept full paths in file input 2021-06-12 19:10:13 +02:00
Member
Added subscribers: @jsprenkle, @dfelinto, @Zandman, @PratikPB2123, @WilliamReynish, @rjg

To add my two cents:

  • I agree the bottom input should accept full paths.
  • Having the bottom input convert filenames into “safe” variants is unwanted functionality, especially for dialogs displayed for opening files (in contrast to save dialogs).
  • I also think it’s wrong for the top input (folder path) to suggest creating a new directory when a path that doesn’t yet exist is entered. Having a dedicated button on the dialog for creating a new folder is the way to go.
To add my two cents: * I agree the bottom input should accept full paths. * Having the bottom input convert filenames into “safe” variants is unwanted functionality, especially for dialogs displayed for opening files (in contrast to save dialogs). * I also think it’s wrong for the top input (folder path) to suggest creating a new directory when a path that doesn’t yet exist is entered. Having a dedicated button on the dialog for creating a new folder is the way to go.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#75376
No description provided.