Sculpt Mask brush toggle hotkey is broken #75457

New Issue

TheRedWaxPolice · 2020-04-06T21:41:37+02:00

TheRedWaxPolice commented

2020-04-06 21:41:37 +02:00

System Information
Operating system: Win 10

Blender Version
Broken: blender-2.83-7c0e28594840-windows64
Worked: blender-2.80-windows64

Short description of error
The sculpting mask brush hotkey (M) used to work as a toggle on previous versions of blender, which means, if you press "M" it would switch to the mask brush, and once you press "M" again it would switch back to the previous sculpting brush you were using. But that's no longer the case, even though the Toggle property checkbox is enabled in the keymap...

Exact steps for others to reproduce the error
Launch Blender
Go to File/New/Sculpting
Press "M" and it will switch to the mask brush
Press "M" again and nothing will happen. (it should toggle back to the draw brush)

**System Information** Operating system: Win 10 **Blender Version** Broken: blender-2.83-7c0e28594840-windows64 Worked: blender-2.80-windows64 **Short description of error** The sculpting mask brush hotkey (M) used to work as a toggle on previous versions of blender, which means, if you press "M" it would switch to the mask brush, and once you press "M" again it would switch back to the previous sculpting brush you were using. But that's no longer the case, even though the Toggle property checkbox is enabled in the keymap... **Exact steps for others to reproduce the error** Launch Blender Go to File/New/Sculpting Press "M" and it will switch to the mask brush Press "M" again and nothing will happen. *(it should toggle back to the draw brush)*

TheRedWaxPolice commented

2020-04-06 21:41:37 +02:00

Added subscriber: @TheRedWaxPolice

Ankit Meel commented

2020-04-07 07:57:41 +02:00

Added subscriber: @ankitm

Ankit Meel commented

2020-04-07 07:57:41 +02:00

The shortcut of draw brush is X though

TheRedWaxPolice commented

2020-04-07 14:41:04 +02:00

In #75457#905058, @ankitm wrote:
The shortcut of draw brush is X though

Of course. But what it has to do with this bug report?
Have you tried to replicate the bug?

> In #75457#905058, @ankitm wrote: > The shortcut of draw brush is X though Of course. But what it has to do with this bug report? Have you tried to replicate the bug?

Nelson commented

2020-04-07 15:52:52 +02:00

Added subscriber: @NelsonNAS

Nelson commented

2020-04-07 15:52:52 +02:00

I can confirm this regression.

Richard Antalik commented

2020-04-07 15:58:32 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-05-18 17:56:35 +02:00

Added subscribers: @ideasman42, @lichtwerk

Philipp Oeser commented

2020-05-18 17:56:35 +02:00

Caused by 47da01a4db, so I think this is indeed a bug...

CC @ideasman42

Caused by 47da01a4db, so I think this is indeed a bug... CC @ideasman42

Philipp Oeser self-assigned this 2020-05-18 18:31:05 +02:00

Philipp Oeser commented

2020-05-18 18:31:05 +02:00

Think I got it, Diff incoming shortly...

blender-admin commented

2020-05-19 09:47:13 +02:00

This issue was referenced by d33c27d68b

This issue was referenced by d33c27d68bb3dfa6f2a5690657ee820e9d65822c

Philipp Oeser commented

2020-05-19 14:56:53 +02:00

This is because we correctly switch the brush back to Brush->toggle_brush, but immediately after set the tool to the Tool for which the hotkey is assigned.
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/sculpt_paint/paint_ops.c$737

First I thought it would be easy to get the tool from the toggle_brush, but needs a bit more investigation...

This is because we correctly switch the brush back to `Brush->toggle_brush`, but immediately after set the tool to the Tool for which the hotkey is assigned. https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/sculpt_paint/paint_ops.c$737 First I thought it would be easy to get the tool from the `toggle_brush`, but needs a bit more investigation...

Philipp Oeser commented

2020-05-20 15:17:02 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2020-05-20 15:17:02 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sculpt Mask brush toggle hotkey is broken #75457