Rigify + Whole Character Keying Sets + Library Overrides = Unselectable / Undeletable Keyframes #75781

Closed
opened 2020-04-16 12:05:48 +02:00 by Keith Boshoff · 12 comments
Member

If a Rigify character is linked and overridden in another file, then keyed with Whole Character, it creates keys that are unselectable (kind of) and undeleteable (completely).

  • In the attached zip, open TestLibrary.blend
  • In the rig, enter Pose Mode
  • Press 'I' and select Whole Character

The character is now in a strange state, where:

  • In the dopesheet, grab all the key frames and move them, some keyframes will remain, they will not change their selection state unless Shift-LMBed on, and cannot be deleted.
  • Select all the keyframes and hit delete. All keyframes appear to be deleted. Goto another frame, grab a single widget and key it (any key will do), and you'll see the previously unmovable key is still there, unmovable and undeletable.

WholeCharacterTest.zip

If a Rigify character is linked and overridden in another file, then keyed with Whole Character, it creates keys that are unselectable (kind of) and undeleteable (completely). - In the attached zip, open TestLibrary.blend - In the rig, enter Pose Mode - Press 'I' and select Whole Character The character is now in a strange state, where: - In the dopesheet, grab all the key frames and move them, some keyframes will remain, they will not change their selection state unless Shift-LMBed on, and cannot be deleted. - Select all the keyframes and hit delete. All keyframes appear to be deleted. Goto another frame, grab a single widget and key it (any key will do), and you'll see the previously unmovable key is still there, unmovable and undeletable. [WholeCharacterTest.zip](https://archive.blender.org/developer/F8476705/WholeCharacterTest.zip)
Author
Member

Added subscriber: @Wahooney

Added subscriber: @Wahooney
Member

Added subscriber: @icappiello

Added subscriber: @icappiello
Member

Changed status from 'Needs Triage' to: 'Archived'

Changed status from 'Needs Triage' to: 'Archived'
Ivan Cappiello self-assigned this 2020-04-16 12:14:26 +02:00
Member

Those channels are just hidden. By default blender is not showing in dope sheet and graph editor the hidden channels. You either disable the "only selected" end enable "show hidden" option to move and delete keys accordingly, or just avoid using "Whole Character" keying set.
The "Whole Character" keying set is designed explicitly to key all values, even if hidden.
Moreover this has nothing to do at all with linked libraries.

Those channels are just hidden. By default blender is not showing in dope sheet and graph editor the hidden channels. You either disable the "only selected" end enable "show hidden" option to move and delete keys accordingly, or just avoid using "Whole Character" keying set. The "Whole Character" keying set is designed explicitly to key all values, even if hidden. Moreover this has nothing to do at all with linked libraries.
Author
Member

It seems to be related to hidden bones being keyed with the Whole Character, but hidden bones staying hidden in the Dopesheet (but their keyframes show in the rig's keyframe overview).

It seems to be related to hidden bones being keyed with the Whole Character, but hidden bones staying hidden in the Dopesheet (but their keyframes show in the rig's keyframe overview).
Member

@Wahooney this has nothing to do with rigify itself. If you have suggestions or complaints about how keys have to be shown, please open a separate report so that blender devs can have a look at it.

cheers,
ivan

@Wahooney this has nothing to do with rigify itself. If you have suggestions or complaints about how keys have to be shown, please open a separate report so that blender devs can have a look at it. cheers, ivan
Author
Member

@icappiello I mentioned Rigify because it was the quickest route to get to the problem, not an indication that the problem is caused by Rigify itself, though changes could possibly be made to Rigify to mitigate the issue.

I was only able to delete those keyframes in the linked library scenario with some python script, as the only way to delete those keys through the UI is by unhiding the bones, which cannot be done when it's linked and overridden BTW, even the IK Pole Target toggle doesn't work (definitely something that needs to be sorted out between Rigify and Library Overrides, IMO).

When I try reproducing the error in a non-linked library scenario (TestRig.blend in the attached zip), it manifests differently, the keys are created and their deletion ignored, but they aren't visible in the dope sheet as they are in the linked library override scenario, so something is definitely inconsitant there. Though it is easier to fix in the non-linked scenario, as we can just Reveal All and then see the fcurves which allows for keyframe deletion.

At the end of the day this issue is a UX issue and arguably a paper cut, but it's definitely something that should be addressed. It took me, a fairly knowledgable and technical user, a few hours and some python script to find out where the problem even was let alone fixing it, since those zombie keyframes give no indication of what they are even keying.

@icappiello I mentioned Rigify because it was the quickest route to get to the problem, not an indication that the problem is caused by Rigify itself, though changes could possibly be made to Rigify to mitigate the issue. I was only able to delete those keyframes in the linked library scenario with some python script, as the only way to delete those keys through the UI is by unhiding the bones, which cannot be done when it's linked and overridden BTW, even the IK Pole Target toggle doesn't work (definitely something that needs to be sorted out between Rigify and Library Overrides, IMO). When I try reproducing the error in a non-linked library scenario (TestRig.blend in the attached zip), it manifests differently, the keys are created and their deletion ignored, but they aren't visible in the dope sheet as they are in the linked library override scenario, so something is definitely inconsitant there. Though it is easier to fix in the non-linked scenario, as we can just Reveal All and then see the fcurves which allows for keyframe deletion. At the end of the day this issue **is** a UX issue and arguably a paper cut, but it's definitely something that should be addressed. It took me, a fairly knowledgable and technical user, a few hours and some python script to find out where the problem even was let alone fixing it, since those zombie keyframes give no indication of what they are even keying.
Member

@Wahooney maybe i am missing something, but in your linked file i can delete, move and show all the keys after disabling the "only selected" end enabling "show hidden".
Still this isn't a rigify specific issue and i can't reproduce it on my system.
Moreover some more information are missing in this report and are required to investigate further:

blender version?
OS?

EDIT:
reading once more i see this is happening when you make a library override. This area should probably need a deeper investigation by @mont29, but as i suggested before, it would require a more general report, and a way more simple example for the developer to reproduce.

@Wahooney maybe i am missing something, but in your linked file i can delete, move and show all the keys after disabling the "only selected" end enabling "show hidden". Still this isn't a rigify specific issue and i can't reproduce it on my system. Moreover some more information are missing in this report and are required to investigate further: blender version? OS? EDIT: reading once more i see this is happening when you make a library override. This area should probably need a deeper investigation by @mont29, but as i suggested before, it would require a more general report, and a way more simple example for the developer to reproduce.
Member

Added subscriber: @mont29

Added subscriber: @mont29
Member

@Wahooney can you please check that your dopesheet options are set like this?
Schermata 2020-04-16 alle 15.49.40.png

@Wahooney can you please check that your dopesheet options are set like this? ![Schermata 2020-04-16 alle 15.49.40.png](https://archive.blender.org/developer/F8476954/Schermata_2020-04-16_alle_15.49.40.png)

not sure I understand properly, but editing an overridden animation is not supported at all currently. The only thing that is expected to work for now is creating a new animation (Action data-block) on an overridden data, and editing that one...

not sure I understand properly, but editing an overridden animation is not supported at all currently. The only thing that is expected to work for now is creating a new animation (Action data-block) on an overridden data, and editing that one...
Author
Member

Ah, that must've been the only combination I didn't try! So that's that sorted, thanks.

So the only problems then would be the display inconsistency of the hidden object f-curves between linked and non-linked sources, that still seems to be a thing, and the Toggle Pole not working in a linked override scenario (most likely a problem with Library Overrides rather than Rigify).

Ah, that must've been the only combination I didn't try! So that's that sorted, thanks. So the only problems then would be the display inconsistency of the hidden object f-curves between linked and non-linked sources, that still seems to be a thing, and the Toggle Pole not working in a linked override scenario (most likely a problem with Library Overrides rather than Rigify).
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#75781
No description provided.