Masking with MultiRes is inconsistent across all subdiv levels by having the mask saved to individual levels and the 0 subdiv level not having a mask at all #76386

New Issue

Frozen_Death_Knight · 2020-05-03T22:33:05+02:00

2020-05-03 22:33:05 +02:00

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.50

Blender Version
Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-30 20:00, hash: 03f4d20bcf

Short description of error
Masking is not visible on the level 0 mesh with MultiRes added to the object. Also, the mask is saved on every single subdiv level individually, so if you clear the mask at a lower level the mask will still be there on every level above it (i.e. removing the mask at level 3 will have the mask still present at level 4 and up, etc., etc.).
Desktop 2020.05.03 - 17.25.41.01.mp4

Exact steps for others to reproduce the error

Take a cube and subdivide it.
Go down to level 0 and try to mask the mesh, which will be completely invisible. Then pick any subdiv level above it and mask.
Remove the mask at a lower subdiv above level 0 and then move up one level. The mask should still be there.
Repeat 3) until you reach the highest subdiv level.

**System Information** Operating system: Windows-10-10.0.18362-SP0 64 Bits Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.50 **Blender Version** Broken: version: 2.90 (sub 0), branch: master, commit date: 2020-04-30 20:00, hash: `03f4d20bcf` **Short description of error** Masking is not visible on the level 0 mesh with MultiRes added to the object. Also, the mask is saved on every single subdiv level individually, so if you clear the mask at a lower level the mask will still be there on every level above it (i.e. removing the mask at level 3 will have the mask still present at level 4 and up, etc., etc.). [Desktop 2020.05.03 - 17.25.41.01.mp4](https://archive.blender.org/developer/F8510031/Desktop_2020.05.03_-_17.25.41.01.mp4) **Exact steps for others to reproduce the error** 1) Take a cube and subdivide it. 2) Go down to level 0 and try to mask the mesh, which will be completely invisible. Then pick any subdiv level above it and mask. 3) Remove the mask at a lower subdiv above level 0 and then move up one level. The mask should still be there. 4) Repeat 3) until you reach the highest subdiv level.

Frozen_Death_Knight commented

2020-05-03 22:33:05 +02:00

Added subscriber: @Frozen_Death_Knight

Germano Cavalcante commented

2020-05-04 17:07:30 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-05-04 17:07:30 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-05-04 17:07:30 +02:00

I can confirm that the mask does not propagate in the next subdivision levels.

But I cannot reproduce the problem described in item 2:

Go down to level 0 and try to mask the mesh, which will be completely invisible

I can confirm that the mask does not propagate in the next subdivision levels. But I cannot reproduce the problem described in item 2: > 2. Go down to level 0 and try to mask the mesh, which will be completely invisible

Mark Koczwara commented

2020-05-05 08:07:43 +02:00

Added subscriber: @KidTempo

Sergey Sharybin commented

2020-05-12 15:34:32 +02:00

Added subscriber: @Sergey

Sergey Sharybin self-assigned this 2020-05-12 15:34:32 +02:00

Sergey Sharybin commented

2020-05-12 15:34:32 +02:00

Propagaiton is easiest to be implemented by me.

Level 0 wouldn't be affected by thew propagation. In fact, quite sure mask on level 0 totally separate from mask on multires levels.

Propagaiton is easiest to be implemented by me. Level 0 wouldn't be affected by thew propagation. In fact, quite sure mask on level 0 totally separate from mask on multires levels.

Sergey Sharybin commented

2020-05-13 12:15:23 +02:00

This comment was removed by @Sergey

*This comment was removed by @Sergey*

Sergey Sharybin commented

2020-05-13 12:17:49 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sergey Sharybin closed this issue

2020-05-13 12:17:49 +02:00

Sergey Sharybin commented

2020-05-13 12:17:49 +02:00

Eeeeh, the phabricator didn't put the entire comment. Re-typing the reply again.

So the fix propagation has been committed. Would suggest to test everything again with a newer build. If there are still some issues in there submit them one per report.

For the level 0 I think this was bout drawing mask on multires, then going to level 0 which will not have the mask. This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

Eeeeh, the phabricator didn't put the entire comment. Re-typing the reply again. So the fix propagation has been committed. Would suggest to test everything again with a newer build. If there are still some issues in there submit them one per report. For the level 0 I think this was bout drawing mask on multires, then going to level 0 which will not have the mask. This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

Frozen_Death_Knight commented

2020-05-13 20:14:26 +02:00

@Sergey Okay, but what makes masking so unique that it can't be propagated from level 0 and up? Face Sets is a brand new feature yet it propagates its colours to every level, including level 0. I know that in ZBRush it works the same way with the mask propagating from the base mesh up to the highest subdiv level. I honestly think it would be a good idea to at least consider it as a known issue if you are not going to mark it as a bug.

Regnas commented

2020-05-14 05:08:25 +02:00

Added subscriber: @Regnas

Regnas commented

2020-05-14 05:08:25 +02:00

In #76386#930609, @Sergey wrote:
This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug.

Ok. But this behavior is not desirable at all, and certainly feels like a glitch. So I hope it can be changed at some point in the future.

> In #76386#930609, @Sergey wrote: > This is how the current design work (as I've mentioned before multires and non-multires masks are separate). This is not considered a bug. Ok. But this behavior is not desirable at all, and certainly feels like a glitch. So I hope it can be changed at some point in the future.

Sergey Sharybin commented

2020-05-14 09:17:40 +02:00

Face Sets were likely designed keeping propagation from level 0 all the way in mind. This is not how mask was initially implemented,
It is surely always possible to upgrade existing designs, but this happens outside of the bug tracker.

Face Sets were likely designed keeping propagation from level 0 all the way in mind. This is not how mask was initially implemented, It is surely always possible to upgrade existing designs, but this happens outside of the bug tracker.

Frozen_Death_Knight commented

2020-05-17 00:43:38 +02:00

@Sergey I have had the chance to test MultiRes masking with the bug fix patch now. Although it is better, masking is still not fixed properly. Here is a video demonstration showing that deleting the mask does not actually remove the entire mask from all subdiv levels by having mask artefacts remaining at the edges of your mask:

Desktop 2020.05.17 - 00.35.46.01.mp4

When you delete a mask, it should be deleted completely across all levels. Until this is fixed, my bug report remains valid.

@Sergey I have had the chance to test MultiRes masking with the bug fix patch now. Although it is better, masking is still not fixed properly. Here is a video demonstration showing that deleting the mask does not actually remove the entire mask from all subdiv levels by having mask artefacts remaining at the edges of your mask: [Desktop 2020.05.17 - 00.35.46.01.mp4](https://archive.blender.org/developer/F8539378/Desktop_2020.05.17_-_00.35.46.01.mp4) When you delete a mask, it should be deleted completely across all levels. Until this is fixed, my bug report remains valid.

Sergey Sharybin commented

2020-05-18 09:26:32 +02:00

Please submit new report for that.