Crash when changing Size in Add Cube pop-up #76646

New Issue

db · 2020-05-11T16:53:27+02:00

db commented

2020-05-11 16:53:27 +02:00

System Information
Operating system: Windows 10 x64 (1909)
Graphics card: Asus GeForce RTX 2080ti (latest GeForce Experience NVIDIA Studio Driver 442.92)

Blender Version
Broken:
2.90, 51ac411ce8, master, 2020-05-10 15:42
2.83, eaee2b4119, master, 2020-05-10 06:26

Worked: 2.82

Short description of error
Mouse-dragging the Size setting in the Add Cube popup causes Blender to crash. Both 2.83 and 2.90 daily build seem to exhibit the same issue.

Exact steps for others to reproduce the error

Open Preferences, Reset to Factory Default (note: wasn't getting a crash when using my current preferences)
Shift-A and add a Cube
Drag the Size slider left/right (note: typing a value directly and hitting enter doesn't seem to cause the crash)
Crash to desktop

I was getting CTD when using the Redo Last (Shift-R) shortcut when using a custom Transform Orientation. I hit this crash when trying to reproduce that. Unsure if the two are related.

Crash logs from 2.90 build:

blender_debug_output.txt
blender_system_info.txt

**System Information** Operating system: Windows 10 x64 (1909) Graphics card: Asus GeForce RTX 2080ti (latest GeForce Experience NVIDIA Studio Driver 442.92) **Blender Version** Broken: 2.90, 51ac411ce80c, master, 2020-05-10 15:42 2.83, eaee2b411935, master, 2020-05-10 06:26 Worked: 2.82 **Short description of error** Mouse-dragging the Size setting in the Add Cube popup causes Blender to crash. Both 2.83 and 2.90 daily build seem to exhibit the same issue. **Exact steps for others to reproduce the error** 1. Open Preferences, Reset to Factory Default (note: wasn't getting a crash when using my current preferences) 2. Shift-A and add a Cube 3. Drag the Size slider left/right (note: typing a value directly and hitting enter doesn't seem to cause the crash) 4. Crash to desktop I was getting CTD when using the Redo Last (Shift-R) shortcut when using a custom Transform Orientation. I hit this crash when trying to reproduce that. Unsure if the two are related. Crash logs from 2.90 build: [blender_debug_output.txt](https://archive.blender.org/developer/F8528285/blender_debug_output.txt) [blender_system_info.txt](https://archive.blender.org/developer/F8528286/blender_system_info.txt)

db commented

2020-05-11 16:53:27 +02:00

Added subscriber: @browneggz

Hans Goudey commented

2020-05-11 18:46:02 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2020-05-11 18:46:02 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2020-05-11 18:46:02 +02:00

Can confirm this, and also that I had to reset to default preferences to cause it.

Hans Goudey commented

2020-05-11 18:51:01 +02:00

Added subscriber: @mont29

Hans Goudey commented

2020-05-11 18:51:01 +02:00

@mont29 This looks like an undo related crash. Maybe related to c43725e189

libc.so.6!raise (Unknown Source:0)
libc.so.6!abort (Unknown Source:0)
BKE_main_idmap_create(struct Main * bmain, const _Bool create_valid_ids_set, struct Main * old_bmain, const int idmap_types) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/main_idmap.c:126)
blo_make_old_idmap_from_main(FileData * fd, Main * bmain) (/home/hans/Documents/Blender-Git/blender/source/blender/blenloader/intern/readfile.c:2295)
BLO_read_from_memfile(Main * oldmain, const char * filename, MemFile * memfile, const struct BlendFileReadParams * params, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/blenloader/intern/readblenentry.c:390)
BKE_blendfile_read_from_memfile(bContext * C, struct MemFile * memfile, const struct BlendFileReadParams * params, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/blendfile.c:499)
BKE_memfile_undo_decode(MemFileUndoData * mfu, const int undo_direction, const _Bool use_old_bmain_data, bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/blender_undo.c:87)
memfile_undosys_step_decode(struct bContext * C, struct Main * bmain, UndoStep * us_p, int undo_direction, _Bool UNUSED_is_final) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/memfile_undo.c:190)
undosys_step_decode(bContext * C, Main * bmain, UndoStack * ustack, UndoStep * us, int dir, _Bool is_final) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:210)
BKE_undosys_step_undo_with_data_ex(UndoStack * ustack, bContext * C, UndoStep * us, _Bool use_skip) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:696)
BKE_undosys_step_undo_with_data(UndoStack * ustack, bContext * C, UndoStep * us) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:725)
ed_undo_step_impl(bContext * C, int step, const char * undoname, int undo_index, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:183)
ed_undo_step_by_name(bContext * C, const char * undo_name, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:259)
ED_undo_pop_op(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:308)
ED_undo_operator_repeat(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:583)
ED_undo_operator_repeat_cb_evt(bContext * C, void * arg_op, int UNUSED_arg_event) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:629)
ui_apply_but_funcs_after(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:916)
ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:10709)
wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:616)
wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2723)

This seems like quite a corner case though, because it only occurs right after resetting to factory settings. Starting Blender again after resetting to default settings does not cause the crash.

@mont29 This looks like an undo related crash. Maybe related to c43725e189 ``` libc.so.6!raise (Unknown Source:0) libc.so.6!abort (Unknown Source:0) BKE_main_idmap_create(struct Main * bmain, const _Bool create_valid_ids_set, struct Main * old_bmain, const int idmap_types) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/main_idmap.c:126) blo_make_old_idmap_from_main(FileData * fd, Main * bmain) (/home/hans/Documents/Blender-Git/blender/source/blender/blenloader/intern/readfile.c:2295) BLO_read_from_memfile(Main * oldmain, const char * filename, MemFile * memfile, const struct BlendFileReadParams * params, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/blenloader/intern/readblenentry.c:390) BKE_blendfile_read_from_memfile(bContext * C, struct MemFile * memfile, const struct BlendFileReadParams * params, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/blendfile.c:499) BKE_memfile_undo_decode(MemFileUndoData * mfu, const int undo_direction, const _Bool use_old_bmain_data, bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/blender_undo.c:87) memfile_undosys_step_decode(struct bContext * C, struct Main * bmain, UndoStep * us_p, int undo_direction, _Bool UNUSED_is_final) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/memfile_undo.c:190) undosys_step_decode(bContext * C, Main * bmain, UndoStack * ustack, UndoStep * us, int dir, _Bool is_final) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:210) BKE_undosys_step_undo_with_data_ex(UndoStack * ustack, bContext * C, UndoStep * us, _Bool use_skip) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:696) BKE_undosys_step_undo_with_data(UndoStack * ustack, bContext * C, UndoStep * us) (/home/hans/Documents/Blender-Git/blender/source/blender/blenkernel/intern/undo_system.c:725) ed_undo_step_impl(bContext * C, int step, const char * undoname, int undo_index, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:183) ed_undo_step_by_name(bContext * C, const char * undo_name, ReportList * reports) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:259) ED_undo_pop_op(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:308) ED_undo_operator_repeat(bContext * C, wmOperator * op) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:583) ED_undo_operator_repeat_cb_evt(bContext * C, void * arg_op, int UNUSED_arg_event) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/undo/ed_undo.c:629) ui_apply_but_funcs_after(bContext * C) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:916) ui_handler_region_menu(bContext * C, const wmEvent * event, void * UNUSED_userdata) (/home/hans/Documents/Blender-Git/blender/source/blender/editors/interface/interface_handlers.c:10709) wm_handler_ui_call(bContext * C, wmEventHandler_UI * handler, const wmEvent * event, int always_pass) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:616) wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) (/home/hans/Documents/Blender-Git/blender/source/blender/windowmanager/intern/wm_event_system.c:2723) ``` This seems like quite a corner case though, because it only occurs right after resetting to factory settings. Starting Blender again after resetting to default settings does not cause the crash.

Brecht Van Lommel commented

2020-05-11 18:58:52 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2020-05-11 18:58:52 +02:00

The issue is that BKE_lib_libblock_session_uuid_reset is being called when resetting preferences to factory settings, even though the .blend file and datablocks remain unchanged. I also noticed that WM_file_read calls BKE_lib_libblock_session_uuid_reset before it is certain that a new file will be loaded.

Could we just remove BKE_lib_libblock_session_uuid_reset altogether? The UUID wraps around anyway, so I'm not sure there's anything to be gained from resetting it to zero.

The issue is that `BKE_lib_libblock_session_uuid_reset` is being called when resetting preferences to factory settings, even though the .blend file and datablocks remain unchanged. I also noticed that `WM_file_read` calls `BKE_lib_libblock_session_uuid_reset` before it is certain that a new file will be loaded. Could we just remove `BKE_lib_libblock_session_uuid_reset` altogether? The UUID wraps around anyway, so I'm not sure there's anything to be gained from resetting it to zero.

Bastien Montagne commented

2020-05-13 10:36:31 +02:00

@brecht yes, think it simpler to just remove it altogether, it might be a bit tricky to do those calls always at proper place, and they do not bring any added value anymore...

blender-admin commented

2020-05-13 10:37:02 +02:00

This issue was referenced by cda25f8f38

This issue was referenced by cda25f8f381d9596951062f22c66bca8302fe84f

Bastien Montagne commented

2020-05-13 10:39:50 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2020-05-13 10:39:50 +02:00

Bastien Montagne self-assigned this 2020-05-13 10:39:50 +02:00

Thomas Dinges added this to the 2.83 LTS milestone 2023-02-08 16:35:48 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when changing Size in Add Cube pop-up #76646