Display modifier in Edit Mode doesn't work For Lattice #77184

New Issue

Anton Lents · 2020-05-30T03:49:17+02:00

Anton Lents commented

2020-05-30 03:49:17 +02:00

System Information
Operating system: Windows 10
Graphics card: GTX 1660

Blender Version
Broken: 2.82a
Worked: 2.79

Short description of error
In the modifier Armature that is applied to a Lattice object the button "Display modifier in Edit Mode" doesn't work. You can activate the button, but nothing happens.

Exact steps for others to reproduce the error
The problem remains even with a simpler scene.
Create a cube -> Create Lattice -> Add Lattice modifier to the cube -> Create armature -> Add Armature modifier to the Lattice -> Select some Lattice vertexes in Edit Mode and create a Vertex Group, name it after the armature bone.
Now, if we move the bone in Pose Mode and then try to work with Lattice in Edit Mode, the button "Display modifier in Edit Mode" still does not work

#77184.blend

**System Information** Operating system: Windows 10 Graphics card: GTX 1660 **Blender Version** Broken: 2.82a Worked: 2.79 **Short description of error** In the modifier Armature that is applied to a Lattice object the button "Display modifier in Edit Mode" doesn't work. You can activate the button, but nothing happens. **Exact steps for others to reproduce the error** The problem remains even with a simpler scene. Create a cube -> Create Lattice -> Add Lattice modifier to the cube -> Create armature -> Add Armature modifier to the Lattice -> Select some Lattice vertexes in Edit Mode and create a Vertex Group, name it after the armature bone. Now, if we move the bone in Pose Mode and then try to work with Lattice in Edit Mode, the button "Display modifier in Edit Mode" still does not work [#77184.blend](https://archive.blender.org/developer/F8571609/T77184.blend)

Anton Lents commented

2020-05-30 03:49:17 +02:00

Added subscriber: @AntonLents

Richard Antalik commented

2020-06-02 00:43:45 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2020-06-02 08:30:07 +02:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2020-06-02 08:30:07 +02:00

Not sure if this is a viewport or a modifier issue. Eg.

modifier that does not calculate the right results.
viewport that does not draw the right results.

diff --git a/source/blender/draw/intern/draw_cache_impl_lattice.c b/source/blender/draw/intern/draw_cache_impl_lattice.c
index bb313b31deb..f8c9baad2a2 100644
--- a/source/blender/draw/intern/draw_cache_impl_lattice.c
+++ b/source/blender/draw/intern/draw_cache_impl_lattice.c
@@ -141,6 +141,8 @@ static LatticeRenderData *lattice_render_data_create(Lattice *lt, const int type
   LatticeRenderData *rdata = MEM_callocN(sizeof(*rdata), __func__);
   rdata->types = types;
 
+  /* `lt` contains the deformed BPoints.*/
+  rdata->bp = lt->def;
   if (lt->editlatt) {
     EditLatt *editlatt = lt->editlatt;
     lt = editlatt->latt;
@@ -171,8 +173,6 @@ static LatticeRenderData *lattice_render_data_create(Lattice *lt, const int type
     }
   }
 
-  rdata->bp = lt->def;
-
   rdata->dims.u_len = lt->pntsu;
   rdata->dims.v_len = lt->pntsv;
   rdata->dims.w_len = lt->pntsw;

fixes the drawing part, but shows that the (presumably) depsgraph uses the incorrect Lattice to evaluate related objects. in this case the cube. Leading to other unwanted behaviors.

Not sure if this is a viewport or a modifier issue. Eg. * modifier that does not calculate the right results. * viewport that does not draw the right results. ``` diff --git a/source/blender/draw/intern/draw_cache_impl_lattice.c b/source/blender/draw/intern/draw_cache_impl_lattice.c index bb313b31deb..f8c9baad2a2 100644 --- a/source/blender/draw/intern/draw_cache_impl_lattice.c +++ b/source/blender/draw/intern/draw_cache_impl_lattice.c @@ -141,6 +141,8 @@ static LatticeRenderData *lattice_render_data_create(Lattice *lt, const int type LatticeRenderData *rdata = MEM_callocN(sizeof(*rdata), __func__); rdata->types = types; + /* `lt` contains the deformed BPoints.*/ + rdata->bp = lt->def; if (lt->editlatt) { EditLatt *editlatt = lt->editlatt; lt = editlatt->latt; @@ -171,8 +173,6 @@ static LatticeRenderData *lattice_render_data_create(Lattice *lt, const int type } } - rdata->bp = lt->def; - rdata->dims.u_len = lt->pntsu; rdata->dims.v_len = lt->pntsv; rdata->dims.w_len = lt->pntsw; ``` fixes the drawing part, but shows that the (presumably) depsgraph uses the incorrect `Lattice` to evaluate related objects. in this case the cube. Leading to other unwanted behaviors. ![Screenshot from 2020-06-02 09-39-30.png](https://archive.blender.org/developer/F8571663/Screenshot_from_2020-06-02_09-39-30.png)

Jeroen Bakker changed title from ~~Display modifier in Edit Mode doesn't work~~ to Display modifier in Edit Mode doesn't work For Lattice

2020-06-02 14:52:49 +02:00

Philipp Oeser commented

2020-06-03 13:39:27 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-06-03 13:39:27 +02:00

This comment was removed by @lichtwerk

*This comment was removed by @lichtwerk*

Philipp Oeser commented

2020-06-03 14:36:46 +02:00

P1446 somewhat shows that the deformation does not feed back to the editlatt.

[P1446](https://archive.blender.org/developer/P1446.txt) somewhat shows that the deformation does not feed back to the `editlatt`.

Campbell Barton commented

2022-02-07 05:58:49 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2022-02-07 05:58:49 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2022-02-07 05:58:49 +01:00

Campbell Barton self-assigned this 2022-02-07 05:58:49 +01:00

Campbell Barton commented

2022-02-07 05:58:49 +01:00

This is now working (possibly, although I didn't bisect 3681a619de).

Now the deformed lattice is shown in edit-mode, although selected vertices aren't (reported separately: #95574 (Lattices don't display selected vertices with modifier "Edit Mode" enabled)).

This is now working (possibly, although I didn't bisect 3681a619de). Now the deformed lattice is shown in edit-mode, although selected vertices aren't (reported separately: #95574 (Lattices don't display selected vertices with modifier "Edit Mode" enabled)).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Display modifier in Edit Mode doesn't work For Lattice #77184