Operators that create library data without being flaged to UNDO crash when undoing #77249

New Issue

MACHIN3 · 2020-06-01T10:35:04+02:00

MACHIN3 commented

2020-06-01 10:35:04 +02:00

System Information
Operating system: Linux-4.15.0-96-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.83.0 Beta, branch: master, commit date: 2020-05-30 15:33, hash: ec26260132
Worked: 1239cab11f

Short description of error
Using a custom operator to append an object from another file, will crash Blender when undoing right after.
Curiously, the operator has to be called from a menu (like the operator search menu), and won't crash when run from the text editor.

append_obj_undo_crash.zip

Exact steps for others to reproduce the error

open the append_obj_undo_crash.blend file from the zip
run the script in the text editor to register the AppendUndoCrash operator
run Append Undo Crash from the operator search menu in the 3d view
undo

**System Information** Operating system: Linux-4.15.0-96-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** Broken: version: 2.83.0 Beta, branch: master, commit date: 2020-05-30 15:33, hash: `ec26260132` Worked: `1239cab11f` **Short description of error** Using a custom operator to append an object from another file, will crash Blender when undoing right after. Curiously, the operator has to be called from a menu (like the operator search menu), and won't crash when run from the text editor. [append_obj_undo_crash.zip](https://archive.blender.org/developer/F8569400/append_obj_undo_crash.zip) **Exact steps for others to reproduce the error** * open the append_obj_undo_crash.blend file from the zip * run the script in the text editor to register the AppendUndoCrash operator * run Append Undo Crash from the operator search menu in the 3d view * undo

MACHIN3 commented

2020-06-01 10:35:04 +02:00

Added subscriber: @MACHIN3

MACHIN3 changed title from ~~Appedin an object using an Operator, followed by Undo will crash Blender~~ to Appending an object using an Operator, followed by Undo will crash Blender

2020-06-01 10:35:15 +02:00

Bent Hillerkus commented

2020-06-01 10:58:25 +02:00

Added subscriber: @bent

Bohdan Lvov commented

2020-06-01 17:00:25 +02:00

Added subscriber: @ostapblender

Bohdan Lvov commented

2020-06-01 17:00:25 +02:00

Yup, have it on WIndows using ec26260132, af3a55bb1b and bba11c68c4. Last one is the earliest and is from 2nd of May.

Yup, have it on WIndows using ec26260132b4, af3a55bb1b and bba11c68c4. Last one is the earliest and is from 2nd of May.

Piotr commented

2020-06-01 18:19:25 +02:00

Added subscriber: @Pinnhead

Piotr commented

2020-06-01 18:19:25 +02:00

Exactly the same in blender-2.83.0-ec26260132b4-windows64

Campbell Barton commented

2020-06-02 09:31:41 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-06-02 09:31:41 +02:00

If the operator is adding/removing library data it should use: bl_options = {'REGISTER', 'UNDO'}

A fix for this would likely be to do an undo push, even though the operator didn't request it.

Marking as TODO.

If the operator is adding/removing library data it should use: `bl_options = {'REGISTER', 'UNDO'}` A fix for this would likely be to do an undo push, even though the operator didn't request it. Marking as TODO.

Campbell Barton changed title from ~~Appending an object using an Operator, followed by Undo will crash Blender~~ to Operators that create library data without being flaged to UNDO crash when undoing

2020-06-02 09:32:56 +02:00

Campbell Barton commented

2020-06-02 09:32:56 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Bastien Montagne commented

2020-06-03 12:39:15 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2020-06-03 12:39:15 +02:00

Changed status from 'Confirmed' to: 'Archived'

Bastien Montagne closed this issue

2020-06-03 12:39:15 +02:00

Bastien Montagne self-assigned this 2020-06-03 12:39:15 +02:00

Bastien Montagne commented

2020-06-03 12:39:15 +02:00

This is no longer expected to work. As Campbell said, operators affecting Blender data must register for undo. Not doing so was already an issue in the past anyway (undoing would then undo too much things at once), it is now a critical error.

@ideasman42 I would not consider always storing an undo step when operator do not request it, we have quiet a few UI ones that we really do not want to undo ever…

This is no longer expected to work. As Campbell said, operators affecting Blender data must register for undo. Not doing so was already an issue in the past anyway (undoing would then undo too much things at once), it is now a critical error. @ideasman42 I would not consider always storing an undo step when operator do not request it, we have quiet a few UI ones that we really do not want to undo ever…

MACHIN3 commented

2020-06-03 12:41:00 +02:00

Thanks for clearing that up.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Operators that create library data without being flaged to UNDO crash when undoing #77249