Edit mesh fails to draw loose edges in 2.90x when working with high poly count objects #77342

New Issue

Kent Davis · 2020-06-04T05:44:55+02:00

Kent Davis commented

2020-06-04 05:44:55 +02:00

Edit: Bisecting shows bf34b0c8f4 as the cause for the issue.

Also

In #77342#944213, @ideasman42 wrote:
Note that this isn't related to extrude, drawing any loose wire fails in the file provided, unless all faces are deleted (with only faces option).

System Information @Kent-Davis
Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.6

System Information @Alaska
Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits
Graphics card: GTX 1050Ti 440.82

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-03 18:45, hash: b94ab93dfb
Worked: Blender 2.82a, 2.83.0 release

Short description of error
Extruding a vertex on a sufficiently high poly mesh does not work and can appear to cause small graphical glitches in some cases.

Exact steps for others to reproduce the error

Open Blender 2.90.
Select the cube and sub-divide it a lot (I used a sub-division surface modifier with a level of 5 and applied it)
Enter edit mode on the object and select a vertex.
Attempt to extrude the vertex with E. This will not work. Attempting to do this on low poly objects, or with edges, or faces does not cause the issue.

Here's a .blend file with a high poly cube.

#77342 - Extrustion bug.blend

Original steps to reproduce:

Push the E key not work for Blender 2.90 June 3, 2020
Blender 2.83 it work push the E key I can see.

https://www.patreon.com/posts/3d-model-bugs-14969357
I did remove everything materials, texture, modifier (properties), rigging and thing complete.

BugsBunny v4.0.9.blend

See video
https://youtu.be/FcxkJDrOy9E

Edit: Bisecting shows bf34b0c8f4 as the cause for the issue. Also > In #77342#944213, @ideasman42 wrote: > Note that this isn't related to extrude, drawing any loose wire fails in the file provided, unless all faces are deleted (with only faces option). --- **System Information @Kent-Davis** Operating system: Darwin-19.6.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 575 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.10.6 **System Information @Alaska** Operating system: Linux-5.4.0-7634-generic-x86_64-with-debian-bullseye-sid 64 Bits Graphics card: GTX 1050Ti 440.82 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-03 18:45, hash: `b94ab93dfb` Worked: Blender 2.82a, 2.83.0 release **Short description of error** Extruding a vertex on a sufficiently high poly mesh does not work and can appear to cause small graphical glitches in some cases. **Exact steps for others to reproduce the error** 1. Open Blender 2.90. 2. Select the cube and sub-divide it a lot (I used a sub-division surface modifier with a level of 5 and applied it) 3. Enter edit mode on the object and select a vertex. 4. Attempt to extrude the vertex with E. This will not work. Attempting to do this on low poly objects, or with edges, or faces does not cause the issue. Here's a .blend file with a high poly cube. [#77342 - Extrustion bug.blend](https://archive.blender.org/developer/F8575682/T77342_-_Extrustion_bug.blend) --- Original steps to reproduce: Push the E key not work for Blender 2.90 June 3, 2020 Blender 2.83 it work push the E key I can see. https://www.patreon.com/posts/3d-model-bugs-14969357 I did remove everything materials, texture, modifier (properties), rigging and thing complete. [BugsBunny v4.0.9.blend](https://archive.blender.org/developer/F8575671/BugsBunny_v4.0.9.blend) See video https://youtu.be/FcxkJDrOy9E

Kent Davis commented

2020-06-04 05:44:55 +02:00

Added subscriber: @Kent-Davis

blender-admin commented

2020-06-04 05:44:55 +02:00

#77369 was marked as duplicate of this issue

Alaska commented

2020-06-04 05:56:16 +02:00

Added subscriber: @Alaska

Alaska commented

2020-06-04 05:56:16 +02:00

I can confirm the issue, but am having trouble pin pointing the issue.

Here's what I know so far:

The issue does not occur in Blender 2.82a.
The issue occurs in Blender 2.90 with the file provided.
However, the issue only occurs with the objects in the file provided. Any new objects added to the scene can be extruded.
If I copy one of the objects from the provided file to a new instance of Blender, it can't be edited, lining up with the cause being the objects.

I will continue to investigate to see if I can recreate the issue from a simple file or pin point the cause with the current model.

I can confirm the issue, but am having trouble pin pointing the issue. Here's what I know so far: 1. The issue does not occur in Blender 2.82a. 2. The issue occurs in Blender 2.90 with the file provided. 3. However, the issue only occurs with the objects in the file provided. Any new objects added to the scene can be extruded. 4. If I copy one of the objects from the provided file to a new instance of Blender, it can't be edited, lining up with the cause being the objects. I will continue to investigate to see if I can recreate the issue from a simple file or pin point the cause with the current model.

Kent Davis commented

2020-06-04 06:02:46 +02:00

Yes correct. not matter vertex, edge cause problem on 2.90 I was work and make me frustrate start over, start over many times yesterday and today.

When open Blender 2.90 Alpha there cube is fine extruded.
I got download and clean up everything complete and extrude any edge and/or vertex cause bug of 2.90.

Yes correct. not matter vertex, edge cause problem on 2.90 I was work and make me frustrate start over, start over many times yesterday and today. When open Blender 2.90 Alpha there cube is fine extruded. I got download and clean up everything complete and extrude any edge and/or vertex cause bug of 2.90.

Alaska commented

2020-06-04 06:02:49 +02:00

I've found the cause, updating the description to reflect this. I will also bisect the issue to find the commit.

Kent Davis commented

2020-06-04 06:03:55 +02:00

Really good job @Alaska

Campbell Barton changed title from ~~Push the E key have bug.~~ to Edit mesh fails to draw loose edges in 2.90x in some cases

2020-06-04 06:08:37 +02:00

Alaska changed title from ~~Edit mesh fails to draw loose edges in 2.90x in some cases~~ to Extruding a vertex on a sufficiently high poly mesh does not work (2.90)

2020-06-04 06:08:49 +02:00

Campbell Barton commented

2020-06-04 06:09:09 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2020-06-04 06:09:09 +02:00

Note that this isn't related to extrude, drawing any loose wire fails in the file provided, unless all faces are deleted (with only faces option).

Alaska changed title from ~~Extruding a vertex on a sufficiently high poly mesh does not work (2.90)~~ to Edit mesh fails to draw loose edges in 2.90x when working with high poly count objects

2020-06-04 06:09:29 +02:00

Alaska commented

2020-06-04 06:10:08 +02:00

Changed the name back. Will start the bisect now unless you know the commit already @ideasman42

Alaska commented

2020-06-04 06:28:01 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Alaska commented

2020-06-04 06:28:01 +02:00

Added subscriber: @Jeroen-Bakker

Alaska commented

2020-06-04 06:28:01 +02:00

Bisect shows bf34b0c8f4 as the cause.

@Jeroen-Bakker, mind taking a look.

Updating the description to include the bisect information.

Bisect shows bf34b0c8f4b8 as the cause. @Jeroen-Bakker, mind taking a look. Updating the description to include the bisect information.

Kent Davis commented

2020-06-04 06:32:56 +02:00

Oh really. Good job. Thank you for fix correct english. My not good english I do know sign language.

Kent Davis commented

2020-06-04 06:48:04 +02:00

I just test what you said very excellent correct answer yaaa ay.

Alaska commented

2020-06-04 14:30:10 +02:00

Added subscriber: @YAFU

Kent Davis commented

2020-06-04 22:22:48 +02:00

Push the F key is bug while between from vertex to vertex too.

Konstantin Kharkovschenko commented

2020-06-06 20:30:34 +02:00

Added subscriber: @Morphin

Jeroen Bakker self-assigned this 2020-06-08 08:36:35 +02:00

Jeroen Bakker commented

2020-06-08 08:36:35 +02:00

Comfirm. It could be related to my change. Not sure what the real cause is. as this part is single threaded.

Jeroen Bakker commented

2020-06-08 16:51:21 +02:00

diff --git a/source/blender/draw/intern/draw_cache_extract_mesh.c b/source/blender/draw/intern/draw_cache_extract_mesh.c
index 06462d5b9c5..ff54ab5827e 100644
--- a/source/blender/draw/intern/draw_cache_extract_mesh.c
+++ b/source/blender/draw/intern/draw_cache_extract_mesh.c
@@ -4674,11 +4674,8 @@ static void mesh_render_data_update_task_data_free(MeshRenderDataUpdateTaskData
   MEM_freeN(taskdata);
 }
 
-static void mesh_extract_render_data_node_exec(void *__restrict task_data)
+static void mesh_extract_render_data_node_exec(void *__restrict UNUSED(task_data))
 {
-  MeshRenderDataUpdateTaskData *update_task_data = task_data;
-  mesh_render_data_update(
-      update_task_data->mr, update_task_data->iter_type, update_task_data->data_flag);
 }
 
 static struct TaskNode *mesh_extract_render_data_node_create(struct TaskGraph *task_graph,
@@ -4688,6 +4685,7 @@ static struct TaskNode *mesh_extract_render_data_node_create(struct TaskGraph *t
 {
   MeshRenderDataUpdateTaskData *task_data = MEM_mallocN(sizeof(MeshRenderDataUpdateTaskData),
                                                         __func__);
+  mesh_render_data_update(mr, iter_type, data_flag);
   task_data->mr = mr;
   task_data->iter_type = iter_type;
   task_data->data_flag = data_flag;

Solves the issue. Means that the split of the mesh_render_data isn't working as expected. Will investigate.

``` diff --git a/source/blender/draw/intern/draw_cache_extract_mesh.c b/source/blender/draw/intern/draw_cache_extract_mesh.c index 06462d5b9c5..ff54ab5827e 100644 --- a/source/blender/draw/intern/draw_cache_extract_mesh.c +++ b/source/blender/draw/intern/draw_cache_extract_mesh.c @@ -4674,11 +4674,8 @@ static void mesh_render_data_update_task_data_free(MeshRenderDataUpdateTaskData MEM_freeN(taskdata); } -static void mesh_extract_render_data_node_exec(void *__restrict task_data) +static void mesh_extract_render_data_node_exec(void *__restrict UNUSED(task_data)) { - MeshRenderDataUpdateTaskData *update_task_data = task_data; - mesh_render_data_update( - update_task_data->mr, update_task_data->iter_type, update_task_data->data_flag); } static struct TaskNode *mesh_extract_render_data_node_create(struct TaskGraph *task_graph, @@ -4688,6 +4685,7 @@ static struct TaskNode *mesh_extract_render_data_node_create(struct TaskGraph *t { MeshRenderDataUpdateTaskData *task_data = MEM_mallocN(sizeof(MeshRenderDataUpdateTaskData), __func__); + mesh_render_data_update(mr, iter_type, data_flag); task_data->mr = mr; task_data->iter_type = iter_type; task_data->data_flag = data_flag; ``` Solves the issue. Means that the split of the mesh_render_data isn't working as expected. Will investigate.

blender-admin commented

2020-06-15 15:25:25 +02:00

This issue was referenced by ab8a691431

This issue was referenced by ab8a6914317f6fc287fbe176df0b7ef202468d26

Jeroen Bakker commented

2020-06-15 15:27:26 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-06-15 15:27:26 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Edit mesh fails to draw loose edges in 2.90x when working with high poly count objects #77342