Unable to fix broken linked IDs when renamed in libfile #77437

New Issue

Palo Piktor · 2020-06-05T12:24:27+02:00

Palo Piktor commented

2020-06-05 12:24:27 +02:00

System Information
Windows 10
Windows 7 x64

Blender Version
Worked: 2.82
Broken: 2.83.0

Short description of error
Cant rename linked collection. Error: Cannot edit external library data

Exact steps for others to reproduce the error
Default Blender setup (first file lets call it assets.blend)
Create a collection and name it "Test"
Create a cube and move it to "Test" collection
Save the file

Create another file (lets call it level.blend)
Link the "test" collection from the assets.blend
Check all linking options before hiting link
Save the file

Now open assets.blend again and rename "Test" collection to "Cube"
And save it again.

Open level.blend
A message appears that link is broken
Go to Outliner and change Display mode to Blender File
Now go down to the linked collection
Double click broken collection to rename it
Error message appears "Cannot edit external library data"

Renaming linked collections works fine in 2.82

**System Information** Windows 10 Windows 7 x64 **Blender Version** Worked: 2.82 Broken: 2.83.0 **Short description of error** Cant rename linked collection. Error: Cannot edit external library data **Exact steps for others to reproduce the error** Default Blender setup (first file lets call it assets.blend) Create a collection and name it "Test" Create a cube and move it to "Test" collection Save the file Create another file (lets call it level.blend) Link the "test" collection from the assets.blend Check all linking options before hiting link Save the file Now open assets.blend again and rename "Test" collection to "Cube" And save it again. Open level.blend A message appears that link is broken Go to Outliner and change Display mode to Blender File Now go down to the linked collection Double click broken collection to rename it Error message appears "Cannot edit external library data" Renaming linked collections works fine in 2.82

Palo Piktor commented

2020-06-05 12:24:27 +02:00

Added subscriber: @PaloPiktor

Philipp Oeser commented

2020-06-05 13:10:02 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-06-05 13:10:02 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2020-06-05 13:10:02 +02:00

Can confirm.

Not sure if there what was the reason for this change (but looks like a valid usecase), bisecting...

Can confirm. Not sure if there what was the reason for this change (but looks like a valid usecase), bisecting...

Philipp Oeser self-assigned this 2020-06-05 13:29:10 +02:00

Philipp Oeser commented

2020-06-05 13:29:10 +02:00

Added subscriber: @mont29

Philipp Oeser commented

2020-06-05 13:29:10 +02:00

Ha, caused by own c7f74863dd, lets see if I can find a better solution (need to test a little when renaming a linked collection should actually be allowed...)

CC @mont29

Ha, caused by own c7f74863dd, lets see if I can find a better solution (need to test a little when renaming a linked collection should actually be allowed...) CC @mont29

Philipp Oeser commented

2020-06-05 14:10:54 +02:00

Added subscriber: @brecht

Philipp Oeser commented

2020-06-05 14:10:54 +02:00

Hm, I am unsure about all indications this might have here, but to recap:

prior to c7f74863dd, it was possible to rename a linked collection [changing its reference in the linked file] with following consequences:

after renaming the collection (to "repair" a renamed collection from the source file -- or to just reference a different existing collection in the source file), nothing really changes immediately
upon save/reload that renamed collection gets sucked in (this can be a possible workflow [see the "repair" usecase from this report -- even switching to a different existing collection from the source file might make sense])
same thing was never allowed for linked objects btw. (the same "repair" / "switching" workflow is thinkable here, but is forbidden)

#77437.zip

In general I think doing so (renaming a collection to "repair" a renamed collection in the sourcefile or to switch to a different existing collection in the sourcefile) is a bit hidden to actually accept as a valid workflow?

So what I think we could do is:

be strict, keep current behavior (forcing the user to re-link the renamed collection from the sourcefile) OR
make an operator similar to Relocate Library, like Relocate Datablock that lets you browse the sourcefile contents again? (that would show the changes immediately) OR
allow renaming again, but then it would be good to actually see the consequences of that immediately (sucking in the new datablock)

@mont29, @brecht: opinions?

Hm, I am unsure about all indications this might have here, but to recap: prior to c7f74863dd, it was possible to rename a linked collection [changing its reference in the linked file] with following consequences: - after renaming the collection (to "repair" a renamed collection from the source file -- or to just reference a different existing collection in the source file), nothing really changes immediately - upon save/reload that renamed collection gets sucked in (this can be a possible workflow [see the "repair" usecase from this report -- even switching to a different existing collection from the source file might make sense]) - same thing was never allowed for linked objects btw. (the same "repair" / "switching" workflow is thinkable here, but is forbidden) [#77437.zip](https://archive.blender.org/developer/F8579166/T77437.zip) In general I think doing so (renaming a collection to "repair" a renamed collection in the sourcefile or to switch to a different existing collection in the sourcefile) is a bit hidden to actually accept as a valid workflow? So what I think we could do is: - be strict, keep current behavior (forcing the user to re-link the renamed collection from the sourcefile) OR - make an operator similar to `Relocate Library`, like `Relocate Datablock` that lets you browse the sourcefile contents again? (that would show the changes immediately) OR - allow renaming again, but then it would be good to actually see the consequences of that immediately (sucking in the new datablock) @mont29, @brecht: opinions?

Bastien Montagne commented

2020-06-05 16:01:57 +02:00

Renaming linked datadblocks has never been expected to work, this was purely a bug.

Adding some relocation tool for IDs is a nice TODO, I guess.

Renaming linked datadblocks has never been expected to work, this was purely a bug. Adding some relocation tool for IDs is a nice TODO, I guess.

Bastien Montagne changed title from ~~Unable to rename linked collection in Outliner~~ to Unable to fix broken linked IDs when renamed in libfile

2020-06-05 16:02:41 +02:00

Philipp Oeser was unassigned by Bastien Montagne

2020-06-05 16:02:49 +02:00

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Unable to fix broken linked IDs when renamed in libfile #77437