2.83.0 Power Sequencer addon alt+up or alt+down arrow acts differently after the first usage #77671

New Issue

Baran Yagcioglu · 2020-06-09T11:07:05+02:00

Baran Yagcioglu commented

2020-06-09 11:07:05 +02:00

Operating system: Windows 10 Home 2004
Graphics card: RTX 2070 Super

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: 211b6c29f771, type: Release
build date: 2020-06-03, 12:41:58

Worked: ?

Power Sequencer addon alt+up or alt+down arrow acts differently after the first usage

Exact steps for others to reproduce the error
open blender as "video editing"
1- add a movie strip
2- add another shorter movie strip
3- select the shorter strip
4- hit ctrl+alt+down arrow
5- shorter strip divided and placed in other strip
6- repeat 1-3 steps again
7- hit alt+down arrow
8- expecting the shorter strip place under the other strip, it behaves like we hit ctrl+alt+down arrow
alt+down arrow always behaves ctrl+alt+down arrow from now on until we reopen the blender

video shows : youtube video

Operating system: Windows 10 Home 2004 Graphics card: RTX 2070 Super **Blender Version** Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: 211b6c29f771, type: Release build date: 2020-06-03, 12:41:58 Worked: ? Power Sequencer addon alt+up or alt+down arrow acts differently after the first usage **Exact steps for others to reproduce the error** open blender as "video editing" 1- add a movie strip 2- add another shorter movie strip 3- select the shorter strip 4- hit ctrl+alt+down arrow 5- shorter strip divided and placed in other strip 6- repeat 1-3 steps again 7- hit alt+down arrow 8- expecting the shorter strip place under the other strip, it behaves like we hit ctrl+alt+down arrow alt+down arrow always behaves ctrl+alt+down arrow from now on until we reopen the blender video shows : [youtube video ](https://youtu.be/PvaVJGwv5Hs)

Baran Yagcioglu commented

2020-06-09 11:07:05 +02:00

Added subscriber: @BaranYagcioglu

Richard Antalik commented

2020-06-19 03:12:42 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-06-19 03:12:42 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2020-06-19 03:12:42 +02:00

I can confirm, I think I saw this bug previously, and it happens for all keymaps with ctrl+alt modifier keys.

I will have to investigate more, if this happens everywhere or only in VSE layout.

I can confirm, I think I saw this bug previously, and it happens for all keymaps with ctrl+alt modifier keys. I will have to investigate more, if this happens everywhere or only in VSE layout.

Sergey Sharybin commented

2020-06-24 16:13:48 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2020-06-24 16:13:48 +02:00

Could also be related on "Save property value for the next operator run". In this case "just" assign all operator properties in the keymap and see if that helps.

Richard Antalik commented

2020-06-26 17:36:40 +02:00

In #77671#964370, @Sergey wrote:
Could also be related on "Save property value for the next operator run". In this case "just" assign all operator properties in the keymap and see if that helps.

This did not help when I edited keymap manually. In adjust last operation I saw that operator properties did not correspond to keymap. Don't see how this flag can be set/cleared from python. Will check this on C side as well.

> In #77671#964370, @Sergey wrote: > Could also be related on "Save property value for the next operator run". In this case "just" assign all operator properties in the keymap and see if that helps. This did not help when I edited keymap manually. In adjust last operation I saw that operator properties did not correspond to keymap. Don't see how this flag can be set/cleared from python. Will check this on C side as well.

Richard Antalik commented

2020-06-26 19:21:42 +02:00

Checking with C operator I can reproduce only with operator property, that doesn't have PROP_SKIP_SAVE set, so that is probably the issue here indeed. And that works correctly.

As for addon functionality, this resolved the problem:

@@ -39,7 +39,7 @@ class POWER_SEQUENCER_OT_channel_offset(bpy.types.Operator):
         "shortcuts": [
             (
                 {"type": "UP_ARROW", "value": "PRESS", "alt": True},
-                {"direction": "up"},
+                {"direction": "up", "trim_target_channel": False},
                 "Move to Open Channel Above",
             ),
             (
@@ -49,7 +49,7 @@ class POWER_SEQUENCER_OT_channel_offset(bpy.types.Operator):
             ),
             (
                 {"type": "DOWN_ARROW", "value": "PRESS", "alt": True},
-                {"direction": "down"},
+                {"direction": "down", "trim_target_channel": False},
                 "Move to Open Channel Below",
             ),
             (

Will have to look if it is possible to do equivalent of RNA_def_property_flag(prop, PROP_SKIP_SAVE); in python.

That being said, I will change this report to addon issue only.

Checking with C operator I can reproduce only with operator property, that doesn't have `PROP_SKIP_SAVE` set, so that is probably the issue here indeed. And that works correctly. As for addon functionality, this resolved the problem: ``` @@ -39,7 +39,7 @@ class POWER_SEQUENCER_OT_channel_offset(bpy.types.Operator): "shortcuts": [ ( {"type": "UP_ARROW", "value": "PRESS", "alt": True}, - {"direction": "up"}, + {"direction": "up", "trim_target_channel": False}, "Move to Open Channel Above", ), ( @@ -49,7 +49,7 @@ class POWER_SEQUENCER_OT_channel_offset(bpy.types.Operator): ), ( {"type": "DOWN_ARROW", "value": "PRESS", "alt": True}, - {"direction": "down"}, + {"direction": "down", "trim_target_channel": False}, "Move to Open Channel Below", ), ( ``` Will have to look if it is possible to do equivalent of `RNA_def_property_flag(prop, PROP_SKIP_SAVE);` in python. That being said, I will change this report to addon issue only.

Richard Antalik commented

2020-06-29 16:29:49 +02:00

Added subscriber: @GDQuest

Richard Antalik commented

2020-06-29 16:29:49 +02:00

Ah, found it: https://docs.blender.org/api/current/bpy.props.html#bpy.props.EnumProperty
You can pass options={'SKIP_SAVE'}

@GDQuest you may be interested in setting this flag for more opeators to prevent this issue.

Ah, found it: https://docs.blender.org/api/current/bpy.props.html#bpy.props.EnumProperty You can pass `options={'SKIP_SAVE'}` @GDQuest you may be interested in setting this flag for more opeators to prevent this issue.

Gerard Taulats Braos commented

2021-03-27 15:33:24 +01:00

Added subscriber: @Tabra