Page MenuHome
Create Task
Maniphest T77853

Error reloading linked library
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1660/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 441.28

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: rB211b6c29f771

Caused by rB367ecff15d74: readfile: Move ID refcounting to libquery.

Short description of error
Dupplicated objects are created (but not visible) when reloading a linked library.

Exact steps for others to reproduce the error

  • Create a blender file with just a cube and save it
  • Create a new blender file, delete the default cube and link the other cube
    • File -> Link -> (select file) -> Object -> Cube
  • Reload the library
    • Select "Blender File" from the "Scenes", "View Layer", etc dropdown
    • Select the linked file and click "Reload"

This error message shows on the bottom:
Lib Reload: Replacing all references to old data-block 'OBCube' by reloaded one failed, old one (2 remaining users) had to be kept and was renamed to 'OBCube~000'

The blend file will show repeated objects as shown in the attached screenshot.

Revisions and Commits

rB Blender
rB4f3fdf7715c2 Fix T77853: Error reloading linked library.
rBeadbdf170aec Fix T77853: Error reloading linked library.

Related Objects

Event Timeline

Mário Pereira (zimarrio) created this task.Jun 14 2020, 12:57 PM
Riccardo Giovanetti (harvester) added a subscriber: Riccardo Giovanetti (harvester).Jun 14 2020, 9:30 PM

I can confirm the issue.

System Information
Operating system: Windows-10-10.0.18362-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 442.92

Blender Version
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: rB211b6c29f771
Worked: version: 2.82 (sub 7), branch: master, commit date: 2020-03-12 05:06, hash: rB375c7dc4caf4

Saving & reloading the file purges those additional data-blocks (it happens also with collections).

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Jun 15 2020, 10:36 AM
Philipp Oeser (lichtwerk) added a project: Pipeline, Assets & I/O.
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).

Can confirm, checking...

Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".Jun 15 2020, 12:13 PM
Philipp Oeser (lichtwerk) added a subscriber: Bastien Montagne (mont29).

Caused by rB367ecff15d74: readfile: Move ID refcounting to libquery..

Havent checked further, but looks like a bug to me, This kicks in:

Note that this *should* not happen - but better be safe than sorry in this area,
at least until we are 100% sure this cannot ever happen.
Also, we can safely assume names were unique so far,
so just replacing '.' by '~' should work,
but this does not totally rules out the possibility of name collision.

CC @Bastien Montagne (mont29)

Philipp Oeser (lichtwerk) updated the task description. (Show Details)Jun 15 2020, 12:14 PM
Bastien Montagne (mont29) claimed this task.Jun 15 2020, 3:01 PM
Bastien Montagne (mont29) moved this task from Backlog to Bugs on the Pipeline, Assets & I/O board.
Bastien Montagne (mont29) edited projects, added BF Blender (2.83); removed BF Blender.
Bastien Montagne (mont29) mentioned this in T77348: Blender LTS: Maintenance Task.
Bastien Montagne (mont29) closed this task as Resolved by committing rBeadbdf170aec: Fix T77853: Error reloading linked library..Jun 15 2020, 3:04 PM
Bastien Montagne (mont29) added a commit: rBeadbdf170aec: Fix T77853: Error reloading linked library..
Jeroen Bakker (jbakker) added a commit: rB4f3fdf7715c2: Fix T77853: Error reloading linked library..Jun 25 2020, 10:21 AM