Operating system: Darwin-15.6.0-x86_64-i386-64bit 64 Bits
Graphics card: ATI Radeon HD 5770 OpenGL Engine ATI Technologies Inc. 4.1 ATI-1.42.15
Broken: version: 2.83.0, branch: master, commit date: 2020-06-03 14:38, hash: rB211b6c29f771
Short description of error
While in texture mode users press S to activate a color picker (not sure why this isnt the GUI nor the tools palette?)
When its active, we have the options menu (used to be F6 i believe) There is this option "Add to Palette".
This however always adds colors. When you uncheck it, it will enable itself the next time your use the S key and pick a color.
Exact steps for others to reproduce the error
01. Open the attached scene.
02. Start texture paint mode
03. Use S key to enable color picker
04. Options menu (bottom left) shows "Add option to palette" > Deactivate it.
05. Use S key again > Notice colors are still being added but option is unchecked.
06. When you let go of the S key, its checked again