BLI_assert fails when applying camera image on mesh with subdivision modifier. #78198

New Issue

Martijn Versteegh · 2020-06-24T10:46:08+02:00

Martijn Versteegh commented

2020-06-24 10:46:08 +02:00

System Information
Operating system:
Ubuntu eoan
Graphics card:
Nvidia GeForce GTX 760

Blender Version
Broken:
2.90.0 alpha ,61fa710aa3442, master, 2020-06-23
Worked:
Don't know, as I don't have a debug build of earlier versions available here.

Short description of error
When applying a camera image (with 'apply camera image') on a mesh with the subdivision surface modifier, an assert fails.

Exact steps for others to reproduce the error

Debug build of blender
default startup
add background image to camera (any image will do)
add a subdivision surface modifier to the cube
add a material to the cube with an image texture for the Base Color
go to texture paint mode
options->apply camera image

result:
BLI_assert failed: ~/blender-git/blender/source/blender/blenkernel/intern/DerivedMesh.c:896, mesh_calc_modifiers(), at '(mesh_input->id.tag & LIB_TAG_COPIED_ON_WRITE_EVAL_RESULT) == 0'
BLI_assert_failed_on_apply_camera_image_with_subsurf_mesh.blend

I attached a blend file set up to trigger the crash with the cube prepared with a material and and image packed to test it with.

**System Information** Operating system: Ubuntu eoan Graphics card: Nvidia GeForce GTX 760 **Blender Version** Broken: 2.90.0 alpha ,61fa710aa3442, master, 2020-06-23 Worked: Don't know, as I don't have a debug build of earlier versions available here. **Short description of error** When applying a camera image (with 'apply camera image') on a mesh with the subdivision surface modifier, an assert fails. **Exact steps for others to reproduce the error** - Debug build of blender - default startup - add background image to camera (any image will do) - add a subdivision surface modifier to the cube - add a material to the cube with an image texture for the Base Color - go to texture paint mode - options->apply camera image result: BLI_assert failed: ~/blender-git/blender/source/blender/blenkernel/intern/DerivedMesh.c:896, mesh_calc_modifiers(), at '(mesh_input->id.tag & LIB_TAG_COPIED_ON_WRITE_EVAL_RESULT) == 0' [BLI_assert_failed_on_apply_camera_image_with_subsurf_mesh.blend](https://archive.blender.org/developer/F8640229/BLI_assert_failed_on_apply_camera_image_with_subsurf_mesh.blend) I attached a blend file set up to trigger the crash with the cube prepared with a material and and image packed to test it with.

Martijn Versteegh commented

2020-06-24 10:46:08 +02:00

Added subscriber: @Baardaap

Jacques Lucke commented

2020-06-24 11:24:22 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jacques Lucke commented

2020-06-24 11:35:28 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2020-06-24 11:35:29 +02:00

Just for quick reference, because it took me a while to find it ^^

This seems to solve the issue in this specific case, but might not be entirely correct:

diff --git a/source/blender/editors/sculpt_paint/paint_image_proj.c b/source/blender/editors/sculpt_paint/paint_image_proj.c
index 5e3204b6d5a..1d137d71824 100644
--- a/source/blender/editors/sculpt_paint/paint_image_proj.c
+++ b/source/blender/editors/sculpt_paint/paint_image_proj.c
@@ -4057,7 +4057,7 @@ static bool proj_paint_state_mesh_eval_init(const bContext *C, ProjPaintState *p
   /* Workaround for subsurf selection, try the display mesh first */
   if (ps->source == PROJ_SRC_IMAGE_CAM) {
     /* using render mesh, assume only camera was rendered from */
-    ps->me_eval = mesh_create_eval_final_render(depsgraph, scene_eval, ob_eval, &cddata_masks);
+    ps->me_eval = mesh_create_eval_final_render(depsgraph, scene_eval, ob, &cddata_masks);
     ps->me_eval_free = true;
   }
   else {

Just for quick reference, because it took me a while to find it ^^ ![image.png](https://archive.blender.org/developer/F8640299/image.png) This seems to solve the issue in this specific case, but might not be entirely correct: ``` diff --git a/source/blender/editors/sculpt_paint/paint_image_proj.c b/source/blender/editors/sculpt_paint/paint_image_proj.c index 5e3204b6d5a..1d137d71824 100644 --- a/source/blender/editors/sculpt_paint/paint_image_proj.c +++ b/source/blender/editors/sculpt_paint/paint_image_proj.c @@ -4057,7 +4057,7 @@ static bool proj_paint_state_mesh_eval_init(const bContext *C, ProjPaintState *p /* Workaround for subsurf selection, try the display mesh first */ if (ps->source == PROJ_SRC_IMAGE_CAM) { /* using render mesh, assume only camera was rendered from */ - ps->me_eval = mesh_create_eval_final_render(depsgraph, scene_eval, ob_eval, &cddata_masks); + ps->me_eval = mesh_create_eval_final_render(depsgraph, scene_eval, ob, &cddata_masks); ps->me_eval_free = true; } else { ```

Martijn Versteegh commented

2020-06-24 12:16:00 +02:00

Yes, it's a bit hard to find :-). I hoped I was clear enough by writing 'options->apply camera image' but apparently not! Sorry!

Martijn Versteegh commented

2020-06-24 12:17:55 +02:00

I'll try your possible fix and see if it also has any effect on the bug I was actually chasing while finding this one. (But which is too vague/unreproducible to report yet)

Sybren A. Stüvel commented

2020-08-17 10:10:07 +02:00

Closed as duplicate of #79714

Sybren A. Stüvel closed this issue

2020-08-17 10:10:07 +02:00

Sybren A. Stüvel commented

2020-08-17 10:10:38 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-08-17 10:10:38 +02:00

I merged this task into #79714 as that one has more info & a patch.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

BLI_assert fails when applying camera image on mesh with subdivision modifier. #78198