Page MenuHome

Viewport vertex color mode: now it uses only sculpt vertex colors, even if datablock do not exist
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 660 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 445.87

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-24 14:01, hash: rB6fec2e4db05f
Caused by rBf7bbc7cdbb6c: Sculpt Vertex Colors: Initial implementation

Short description of error
Vertex color doesn't show in edit mode, it return only black


Exact steps for others to reproduce the error

  • Change the viewport shading color to vertex
  • Go to vertex paint mode, fill any object with any color
  • Go to edit mode, then it appears only black

this example from default startup:

BLI_assert failed: /blender/source/blender/draw/intern/draw_cache_impl_mesh.c:760, texpaint_request_active_vcol(), at 'cd_needed.vcol != 0 && "No MLOOPCOL layer available in vertpaint, but batches requested anyway!"'

Original report [this is about objectmode as well -- this does not happen with experimental feature disabled]

If old vertex color exist and new sculpt vertex colors is not, I think, viewport should take first one until full replacement.
As far as addons will import vcolors to regular vertex color, it may be handy too.

Event Timeline

Philipp Oeser (lichtwerk) changed the task status from Needs Triage to Confirmed.Jun 25 2020, 2:58 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".

I think this is a bug, yes...

CC @Pablo Dobarro (pablodp606)

Philipp Oeser (lichtwerk) renamed this task from Viewport vertex color mode: now it uses only sculpt vertex colors, even if datablock do not exist. (bug?) to Viewport vertex color mode: now it uses only sculpt vertex colors, even if datablock do not exist.Jun 26 2020, 1:55 PM
Philipp Oeser (lichtwerk) triaged this task as High priority.
Philipp Oeser (lichtwerk) updated the task description. (Show Details)

@Philipp Oeser (lichtwerk): currently this issue is only visible when Sculpt Vertex Colors is activated in the experimental tab. I would suggest to keep this ticket open, but lower the priority. I have seen some discussions about how to proceed with sculpt vertex vs loop vertex colors, but no clear direction afaik. As both codepaths are split in the current codebase a fix would not be in the area where I would expected it to happen.

Pablo Dobarro (pablodp606) lowered the priority of this task from High to Normal.Aug 17 2020, 5:32 PM
Philipp Oeser (lichtwerk) triaged this task as High priority.Sep 5 2020, 11:00 AM

@Philipp Oeser (lichtwerk): currently this issue is only visible when Sculpt Vertex Colors is activated in the experimental tab. I would suggest to keep this ticket open, but lower the priority. I have seen some discussions about how to proceed with sculpt vertex vs loop vertex colors, but no clear direction afaik. As both codepaths are split in the current codebase a fix would not be in the area where I would expected it to happen.

In editmode, this is also happening when Sculpt Vertex Colors is deactivated in the experimental tab (also happening in 2.90 release).
Asserts here:

BLI_assert failed: /blender/source/blender/draw/intern/draw_cache_impl_mesh.c:760, texpaint_request_active_vcol(), at 'cd_needed.vcol != 0 && "No MLOOPCOL layer available in vertpaint, but batches requested anyway!"'

Feel free to change back, but I think we should not break existing functionality unless we have something better in place.