OIDN Viewport Denoiser start sample behaviour differs depending on number of viewport samples #78370

Closed
opened 2020-06-27 22:45:42 +02:00 by Wouter Stomp · 12 comments

System Information
Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.9.15

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-25 21:53, hash: 62aa103d48
Worked: n.a.

Short description of error
When viewport samples is set to 1 and start sample to 1, you immediately get a denoised image. When viewport samples is set to anything larger than 1 and start sample to 1, you get noisy images while the first 2 samples are being rendered, and then the first denoised image appears while the third sample is rendered. Setting the start sample to 0 does directly give a denoised image.

Exact steps for others to reproduce the error
Cycles rendered view, viewport denoising set to OIDN
Viewport samples 1, denoising start sample 1: denoised image appears directly
Viewport samples >1, denoising start sample 1: denoised image appears when the third sample is being rendered
Viewport samples 1, denoising start sample 0: denoised image appears directly

**System Information** Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.9.15 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-25 21:53, hash: `62aa103d48` Worked: n.a. **Short description of error** When viewport samples is set to 1 and start sample to 1, you immediately get a denoised image. When viewport samples is set to anything larger than 1 and start sample to 1, you get noisy images while the first 2 samples are being rendered, and then the first denoised image appears while the third sample is rendered. Setting the start sample to 0 does directly give a denoised image. **Exact steps for others to reproduce the error** Cycles rendered view, viewport denoising set to OIDN Viewport samples 1, denoising start sample 1: denoised image appears directly Viewport samples >1, denoising start sample 1: denoised image appears when the third sample is being rendered Viewport samples 1, denoising start sample 0: denoised image appears directly
Author

Added subscriber: @blenderrocket

Added subscriber: @blenderrocket

Added subscriber: @YAFU

Added subscriber: @YAFU

This that I am going to comment has to do more than anything with the title of the entry, for me not to open a new report because the problems may be related. Here I commented something about it:
https://developer.blender.org/rB669befdfbe487f76c65f54e3da0013d140d56893#270857

The point is that depending on the Viewport Samples and Start Sample settings, denoising in viewport may not run under certain circumstances, not only with OIDN but also with Optix denoiser. I think this could be due to render speed in viewport according to the scene, so people with different hardware could get different behaviors and perhaps not everyone can reproduce the problem in the same way. Anyway it is not clear to me exactly when the problem occurs.
Here is a .blend file:
Bug 2.9-viewport denoising volumetric world vs no volumetric world.blend
On my machine (i7-3770 CPU), by default scene does not run denoiser in viewport. If in the scene with the same settings you in World tab select Volumetric World instead of World, then rendering in viewport is slower and when it reach Start Sample then denoiser it is executed and work this time.

This that I am going to comment has to do more than anything with the title of the entry, for me not to open a new report because the problems may be related. Here I commented something about it: https://developer.blender.org/rB669befdfbe487f76c65f54e3da0013d140d56893#270857 The point is that depending on the Viewport Samples and Start Sample settings, denoising in viewport may not run under certain circumstances, not only with OIDN but also with Optix denoiser. I think this could be due to render speed in viewport according to the scene, so people with different hardware could get different behaviors and perhaps not everyone can reproduce the problem in the same way. Anyway it is not clear to me exactly when the problem occurs. Here is a .blend file: [Bug 2.9-viewport denoising volumetric world vs no volumetric world.blend](https://archive.blender.org/developer/F8651123/Bug_2.9-viewport_denoising_volumetric_world_vs_no_volumetric_world.blend) On my machine (i7-3770 CPU), by default scene does not run denoiser in viewport. If in the scene with the same settings you in World tab select Volumetric World instead of World, then rendering in viewport is slower and when it reach Start Sample then denoiser it is executed and work this time.

Added subscriber: @iss

Added subscriber: @iss

I can confirm this, but I am not sure if this is bug or some limitation.

I can confirm this, but I am not sure if this is bug or some limitation.

Added subscribers: @brecht, @ZedDB

Added subscribers: @brecht, @ZedDB

@brecht bug or not?

@brecht bug or not?
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

Not totally sure if I am reading this report correctly.
Is this the same (or similar) then {#79680}?

In that case it should be fixed already with 58a457da3d.
Could you guys check if this is still an issue in a fresh build from https://builder.blender.org/download/?

If this is still the case, please confirm it (if you can), does not have to be classified as bug (but confirming helps already).

Not totally sure if I am reading this report correctly. Is this the same (or similar) then {#79680}? In that case it should be fixed already with 58a457da3d. Could you guys check if this is still an issue in a fresh build from https://builder.blender.org/download/? If this is still the case, please confirm it (if you can), does not have to be classified as bug (but confirming helps already).
Author

It works as expected now, this bug can be closed, thanks.

It works as expected now, this bug can be closed, thanks.
Author

Changed status from 'Needs User Info' to: 'Resolved'

Changed status from 'Needs User Info' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#78370
No description provided.