Shear operator fails to affect curve control point handles #78592

New Issue

Sam Brubaker · 2020-07-04T02:14:12+02:00

Sam Brubaker commented

2020-07-04 02:14:12 +02:00

Version: 2.83.1 (Linux 64)

This bug requires no example file to reproduce.

Create a Curve object with Free or Aligned Handle Types.
Use the Shear operator/tool.

Below is an example of the expected result (left) vs what you actually get (right):

The operator appears to only affect the locations of the curve control points and not their handles.

Version: 2.83.1 (Linux 64) This bug requires no example file to reproduce. 1. Create a Curve object with Free or Aligned Handle Types. 2. Use the Shear operator/tool. Below is an example of the expected result (left) vs what you actually get (right): ![screen.png](https://archive.blender.org/developer/F8662559/screen.png) The operator appears to only affect the locations of the curve control points and not their handles.

Sam Brubaker commented

2020-07-04 02:14:12 +02:00

Added subscriber: @rocketman

Germano Cavalcante commented

2020-07-07 22:36:28 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2020-07-07 22:36:28 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2020-07-07 22:36:28 +02:00

I imagine that the original code was not made to support this case.
But I will confirm for now.

I imagine that the original code was not made to support this case. But I will confirm for now.

Germano Cavalcante commented

2020-07-20 15:08:46 +02:00

Added subscriber: @ideasman42

Germano Cavalcante commented

2020-07-20 15:08:47 +02:00

This occurs because the pivot (center) of each handle that is used in the shear.
I'm not sure why this happens (CC @ideasman42)

Maybe we could always use td->loc to shear curves:

diff --git a/source/blender/editors/transform/transform_mode_shear.c b/source/blender/editors/transform/transform_mode_shear.c
index fa33c1550e7..1902ef8a513 100644
    - a/source/blender/editors/transform/transform_mode_shear.c
+++ b/source/blender/editors/transform/transform_mode_shear.c
@@ -40,6 +40,7 @@
 #include "BLT_translation.h"
 
 #include "transform.h"
+#include "transform_convert.h"
 - include "transform_mode.h"
 - include "transform_snap.h"
 
@@ -125,6 +126,7 @@ static void applyShear(TransInfo *t, const int UNUSED(mval[2]))

int i;
char str[UI_MAX_DRAW_STR];
const bool is_local_center = transdata_check_local_center(t, t->around);

+  const bool transform_td_center = !is_local_center && t->data_type != TC_CURVE_VERTS;

value = t->values[0];

 
@@ -178,12 +180,17 @@ static void applyShear(TransInfo *t, const int UNUSED(mval[2]))

 if (is_local_center) {
   center = td->center;

- co = td->loc;

 }
 else {
   center = tc->center_local;

+      }
+
+      if (transform_td_center) {

   co = td->center;
 }

+      else {
+        co = td->loc;
+      }

 sub_v3_v3v3(vec, co, center);

This occurs because the pivot (center) of each handle that is used in the shear. I'm not sure why this happens (CC @ideasman42) Maybe we could always use `td->loc` to shear curves: ```lines = 10 diff --git a/source/blender/editors/transform/transform_mode_shear.c b/source/blender/editors/transform/transform_mode_shear.c index fa33c1550e7..1902ef8a513 100644 - a/source/blender/editors/transform/transform_mode_shear.c +++ b/source/blender/editors/transform/transform_mode_shear.c @@ -40,6 +40,7 @@ #include "BLT_translation.h" #include "transform.h" +#include "transform_convert.h" - include "transform_mode.h" - include "transform_snap.h" @@ -125,6 +126,7 @@ static void applyShear(TransInfo *t, const int UNUSED(mval[2])) ``` int i; char str[UI_MAX_DRAW_STR]; const bool is_local_center = transdata_check_local_center(t, t->around); ``` + const bool transform_td_center = !is_local_center && t->data_type != TC_CURVE_VERTS; ``` value = t->values[0]; ``` @@ -178,12 +180,17 @@ static void applyShear(TransInfo *t, const int UNUSED(mval[2])) ``` if (is_local_center) { center = td->center; ``` - co = td->loc; ``` } else { center = tc->center_local; ``` + } + + if (transform_td_center) { ``` co = td->center; } ``` + else { + co = td->loc; + } ``` sub_v3_v3v3(vec, co, center); ``` ```

blender-admin commented

2020-08-05 20:06:23 +02:00

This issue was referenced by 854f73b4a2

This issue was referenced by 854f73b4a2317e026b3d6f8c3598d9bded09337b

Germano Cavalcante commented

2020-08-05 20:06:51 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2020-08-05 20:06:51 +02:00

Germano Cavalcante self-assigned this 2020-08-05 20:06:51 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Shear operator fails to affect curve control point handles #78592