'Reset to default value' sets all values in the physics cloth, soft body and fluid tabs to 0 or 1 #78634

New Issue

Wouter Stomp · 2020-07-05T11:53:23+02:00

Wouter Stomp commented

2020-07-05 11:53:23 +02:00

System Information
Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.9.15

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-28 15:13, hash: b21ba5e579
Worked: unknown

Short description of error
In the physics tab when cloth, soft body or fluid is added, right-clicking and pressing 'reset to default value' will set the value to 0 (and in some cases 1) instead of the actual default value.

Exact steps for others to reproduce the error
see above

**System Information** Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 5500M OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.9.15 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-06-28 15:13, hash: `b21ba5e579` Worked: unknown **Short description of error** In the physics tab when cloth, soft body or fluid is added, right-clicking and pressing 'reset to default value' will set the value to 0 (and in some cases 1) instead of the actual default value. **Exact steps for others to reproduce the error** see above

Wouter Stomp commented

2020-07-05 11:53:23 +02:00

Added subscriber: @blenderrocket

Richard Antalik commented

2020-07-08 05:50:41 +02:00

Added subscriber: @iss

Richard Antalik commented

2020-07-08 05:50:41 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Richard Antalik closed this issue

2020-07-08 05:50:41 +02:00

Richard Antalik self-assigned this 2020-07-08 05:50:41 +02:00

Richard Antalik commented

2020-07-08 05:50:41 +02:00

This is working correctly. Each property does have default value for situation when the property is created. They are usually creaded with new object or scene or pretty much anything. This can be modified further by software though. So if you add quick smoke on cube, domain resolution default value is 6 instead of 32 as it may seem.

Wouter Stomp commented

2020-07-08 22:25:57 +02:00

But these are not the default values they reset to. For example if I add cloth physics to an object, the quality steps are set to 5 by default, but clicking 'reset to default value' sets the value to 1. (or do I misunderstand your answer?)

Richard Antalik commented

2020-07-09 06:26:13 +02:00

These default values are hard-coded. For example for quality it is

  prop = RNA_def_property(srna, "quality", PROP_INT, PROP_NONE);
  RNA_def_property_int_sdna(prop, NULL, "stepsPerFrame");
  RNA_def_property_range(prop, 1, INT_MAX);

This value may be changed before it is presented to you, but it is reset always to hard-coded value. That is what "default value" means here.

These default values are hard-coded. For example for quality it is ``` prop = RNA_def_property(srna, "quality", PROP_INT, PROP_NONE); RNA_def_property_int_sdna(prop, NULL, "stepsPerFrame"); RNA_def_property_range(prop, 1, INT_MAX); ``` This value may be changed before it is presented to you, but it is reset always to hard-coded value. That is what "default value" means here.

Wouter Stomp commented

2020-07-12 22:23:38 +02:00

Thanks. So technically it is doing the right thing, but it is totally worthless and unintuitive to end-users. I would expect the number that first appears there when you add the physics to be the default value. Digging a bit further I found this task that suggests default values need to be added in code for countless values: https://developer.blender.org/T47618 Is there any place where this is tracked or is there any systematic effort to add these values?

Richard Antalik commented

2020-07-13 13:30:51 +02:00

Added subscriber: @sebbas

Richard Antalik commented

2020-07-13 13:30:51 +02:00

I don't think this is tracked in any way. Perhaps once in a while we may do a cleanup or we change way how thing works and these values will get consolidated.

I think that with physics sim, main issue is, that for different simulations you need different defaults and properties are shared for multiple types(like between gas or liquid). Same may apply for force fields and other things. I may agree that for some or even most values default may be completely off.

I will tag @sebbas here if he consider this to be valid issue worth resolving, he can reopen.

I don't think this is tracked in any way. Perhaps once in a while we may do a cleanup or we change way how thing works and these values will get consolidated. I think that with physics sim, main issue is, that for different simulations you need different defaults and properties are shared for multiple types(like between gas or liquid). Same may apply for force fields and other things. I may agree that for some or even most values default may be completely off. I will tag @sebbas here if he consider this to be valid issue worth resolving, he can reopen.

Wouter Stomp commented

2020-10-13 14:23:22 +02:00

Just in case somebody stumbles upon this report, this is now being tracked and fixed in #80164.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

'Reset to default value' sets all values in the physics cloth, soft body and fluid tabs to 0 or 1 #78634