[Bug] Keymap filter crashed Blender
Closed, ResolvedPublic
Actions

Description

System Information
Operating system: MacOs High Sierra 10.13.2
Graphics card: Intel Iris Graphics 6100

Blender Version
2.90.0 Alpha

Short description of error
Keymap filter crashed Blender

Exact steps for others to reproduce the error

Open Blender preferences
Select keymap option
Write to filter search filed (For example "E").
Blender crashed

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   org.blenderfoundation.blender 	0x00000001042c7e9d ui_block_align_calc + 365
1   org.blenderfoundation.blender 	0x00000001042bd6fd UI_block_end_ex + 1085
2   org.blenderfoundation.blender 	0x0000000103fef7bc ed_panel_draw + 956
3   org.blenderfoundation.blender 	0x0000000103fef143 ED_region_panels_layout_ex + 1075
4   org.blenderfoundation.blender 	0x00000001089ed758 userpref_main_region_layout + 184
5   org.blenderfoundation.blender 	0x0000000103c10525 wm_draw_update + 1205
6   org.blenderfoundation.blender 	0x0000000103c0e330 WM_main + 48
7   org.blenderfoundation.blender 	0x00000001038d360d main + 909
8   libdyld.dylib                 	0x00007fff7af08115 start + 1

Revisions and Commits

rB Blender
	rBde3e797d47e9 Fix T78636: Crash displaying many aligned buttons
	rB75520894c72a Fix T78636: Crash displaying many aligned buttons

Related Objects

Mentioned In: T77348: Blender LTS: Maintenance Task
rBad4928a1710f: UI: avoid aligning labels for ui_item_with_label
T78731: Blender crashes while searching for key-binding by name

Event Timeline

James Baxter (Pegacy) created this task.Jul 5 2020, 1:00 PM

James Baxter (Pegacy) updated the task description. (Show Details)

I can't reproduce this on Windows with the latest master. What commit hash is the build you're using based on? In case you don't know what I mean, you can save the system information in Blender through Help > Save System Info and upload the file by clicking on the upload button, as shown in the screenshot below, or via drag-and-drop.

In T78636#973416, @Robert Guetzkow (rjg) wrote:

I can't reproduce this on Windows with the latest master. What commit hash is the build you're using based on? In case you don't know what I mean, you can save the system information in Blender through Help > Save System Info and upload the file by clicking on the upload button, as shown in the screenshot below, or via drag-and-drop.

system-info.txt9 KBDownload

error-info.txt63 KBDownload

Robert Guetzkow (rjg) changed the task status from Needs Information from User to Needs Triage.Jul 6 2020, 10:11 AM

Worked version: 2.90.0 Alpha, branch: master, commit date: 2020-06-18 19:05, hash: rBb89898cbd381
Broken version: 2.90.0 Alpha, branch: master, commit date: 2020-07-01 20:17, hash: rB52b125a790e3

Searching by "Name" (not "Key-Binding") will crash.
It crashed with some single letter, for example "E" or "T", but not if you paste word, example "Extrude".

Robert Guetzkow (rjg) edited projects, added BF Blender, User Interface; removed Add-ons (Community).Jul 6 2020, 11:51 AM

@Yevgeny Makarov (jenkm) Are you reproducing this on macOS as well?

Robert Guetzkow (rjg) updated the task description. (Show Details)Jul 6 2020, 11:57 AM

Yes, macOS.

Operating system: Darwin-19.4.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-3.8.24

Robert Guetzkow (rjg) added a project: Platform: macOS.Jul 6 2020, 2:41 PM

It looks like too many search results, I tried to expand all categories, and at some point it crashed.

Can't reproduce as well.

Just to be sure, does this happen when you click on File > Defaults > Load factory Settings?

On macOS we add Cmd along with Ctrl, so there are a lot more keys here. Without this code, there is no crash.

if platform == 'darwin':
    from bl_keymap_utils.platform_helpers import keyconfig_data_oskey_from_ctrl_for_macos
    keyconfig_data = keyconfig_data_oskey_from_ctrl_for_macos(keyconfig_data)