Oscurart Tool exception when rendering without scene camera (compositor) #78651

New Issue

MACHIN3 · 2020-07-05T21:04:05+02:00

MACHIN3 commented

2020-07-05 21:04:05 +02:00

System Information
Operating system: Linux-4.15.0-101-generic-x86_64-with-debian-buster-sid 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21

Blender Version
Broken: version: 2.83.1, branch: master, commit date: 2020-06-25 09:47, hash: 8289fc688b
Worked: never

Short description of error
The bundled Oscurart addon will throw the following exception when rendering without scene camera (compositor)

Traceback (most recent call last):
  File "/opt/blender-2.83.1-linux64/2.83/scripts/addons/oscurart_tools/render/render_tokens.py", line 32, in replaceTokens
    "$Camera":bpy.context.scene.camera.name}
AttributeError: 'NoneType' object has no attribute 'name'
Traceback (most recent call last):
  File "/opt/blender-2.83.1-linux64/2.83/scripts/addons/oscurart_tools/render/render_tokens.py", line 43, in restoreTokens
    bpy.context.scene.render.filepath = renpath
NameError: name 'renpath' is not defined

This in turn causes problems for other addons, which try to do just that.

Exact steps for others to reproduce the error

download and open oscurart_exception_render_without_camera.blend
render and check the terminal

**System Information** Operating system: Linux-4.15.0-101-generic-x86_64-with-debian-buster-sid 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 435.21 **Blender Version** Broken: version: 2.83.1, branch: master, commit date: 2020-06-25 09:47, hash: `8289fc688b` Worked: never **Short description of error** The bundled Oscurart addon will throw the following exception when rendering without scene camera (compositor) ``` Traceback (most recent call last): File "/opt/blender-2.83.1-linux64/2.83/scripts/addons/oscurart_tools/render/render_tokens.py", line 32, in replaceTokens "$Camera":bpy.context.scene.camera.name} AttributeError: 'NoneType' object has no attribute 'name' Traceback (most recent call last): File "/opt/blender-2.83.1-linux64/2.83/scripts/addons/oscurart_tools/render/render_tokens.py", line 43, in restoreTokens bpy.context.scene.render.filepath = renpath NameError: name 'renpath' is not defined ``` This in turn causes problems for other addons, which try to do just that. **Exact steps for others to reproduce the error** * download and open [oscurart_exception_render_without_camera.blend](https://archive.blender.org/developer/F8667816/oscurart_exception_render_without_camera.blend) * render and check the terminal

MACHIN3 commented

2020-07-05 21:04:05 +02:00

Added subscriber: @MACHIN3

Eugenio Pignataro was assigned by MACHIN3

2020-07-05 21:04:46 +02:00

Eugenio Pignataro commented

2020-07-06 14:04:53 +02:00

Thanks for report!

FIXED.

Thanks for report! FIXED.

Eugenio Pignataro commented

2020-07-06 14:05:17 +02:00

Changed status from 'Needs Triage' to: 'Resolved'

Eugenio Pignataro closed this issue

2020-07-06 14:05:17 +02:00

MACHIN3 commented

2020-08-24 20:38:47 +02:00

I've noticed that Blender 2.90, doesn't seem to have this problem anymore, yet Blender 2.83.5 still has. So can we get this fix into 2.83 LTS too? Also, why hasn't the version changed at all?

Eugenio Pignataro commented

2020-08-25 13:07:55 +02:00

Hi, I'm in 2.9.
I don't know the reason why it doesn't work, I didn't test it.

My addons will always be for the latest version.
For me it was a bad idea to have to do double development.

Hi, I'm in 2.9. I don't know the reason why it doesn't work, I didn't test it. My addons will always be for the latest version. For me it was a bad idea to have to do double development.

MACHIN3 commented

2020-08-25 13:17:28 +02:00

Added subscriber: @jesterking

MACHIN3 commented

2020-08-25 13:17:28 +02:00

Right now, Blender 2.83 is the latest stable release. Please consider getting this into 2.83 as well. 2.83 is the long time release and will be supported for the next 2 years. Since your addon is officially supplied with Blender, and since this is just a fix, not a new feature, it should go into the next bugfix release, so 2.83.6.

Maybe talk to @jesterking?

Right now, Blender 2.83 is the latest stable release. Please consider getting this into 2.83 as well. 2.83 is the long time release and will be supported for the next 2 years. Since your addon is officially supplied with Blender, and since this is just a fix, not a new feature, it should go into the next bugfix release, so 2.83.6. Maybe talk to @jesterking?

Eugenio Pignataro commented

2020-08-25 13:23:10 +02:00

Try downloading de 2.9 version and copy paste to 2.83.
I'm going to work for the latest version. I regret the decision to do double duty.
I can't be doing things twice.

Try downloading de 2.9 version and copy paste to 2.83. I'm going to work for the latest version. I regret the decision to do double duty. I can't be doing things twice.

MACHIN3 commented

2020-08-25 13:37:50 +02:00

Look, you have your addon supplied with Blender. You are responsible for it.

You are currently at version 4.0.0. However, the 2.90 4.0.0 version differs in various places from the 4.0.0 version in 2.83. One of the differences is the bug I've posted here about, and which is fixed in 2.90, but not in 2.83.

Both version also claim to work for Blender 2.80 in the bl_info. I won't tell you how do do your development, but this is bad practice.

Please refer to https:*wiki.blender.org/wiki/Process/Addons in regards to your duties as the maintainer of this addon. And also https:*www.blender.org/download/lts/ in regards to the LTS release cycle.

Look, you have your addon supplied with Blender. You are responsible for it. You are currently at version 4.0.0. However, the 2.90 4.0.0 version differs in various places from the 4.0.0 version in 2.83. One of the differences is the bug I've posted here about, and which is fixed in 2.90, but not in 2.83. Both version also claim to work for Blender 2.80 in the bl_info. I won't tell you how do do your development, but this is bad practice. Please refer to https:*wiki.blender.org/wiki/Process/Addons in regards to your duties as the maintainer of this addon. And also https:*www.blender.org/download/lts/ in regards to the LTS release cycle.

Eugenio Pignataro commented

2020-08-25 13:47:00 +02:00

I recommend that you pay attention to how you talk to me.
A greeting.

I recommend that you pay attention to how you talk to me. A greeting.

MACHIN3 commented

2020-08-25 13:57:10 +02:00

Added subscriber: @ideasman42

MACHIN3 commented

2020-08-25 13:57:10 +02:00

Hi @ideasman42, can you take a look at this please?

I suggest this addon to be removed from 2.83 LTS, if the maintainer refuses to fix it.

Hi @ideasman42, can you take a look at this please? I suggest this addon to be removed from 2.83 LTS, if the maintainer refuses to fix it.

Philipp Oeser commented

2020-08-25 14:10:06 +02:00

Added subscribers: @Jeroen-Bakker, @lichtwerk

Philipp Oeser commented

2020-08-25 14:10:06 +02:00

For reference, this is probably about this commit blender/blender-addons@955332bf02

@Jeroen-Bakker : should this be considered for LTS?
@MACHIN3 : Not sure there is a hard rule to backport every fix to LTS? (we are also not backporting every non-Addon fix either, so this is more of a decision process than a rule?)

But sure, LTS is a promise to provide critical fixes, so this might be one of them.

For reference, this is probably about this commit blender/blender-addons@955332bf02 @Jeroen-Bakker : should this be considered for LTS? @MACHIN3 : Not sure there is a hard rule to backport **every** fix to LTS? (we are also not backporting every non-Addon fix either, so this is more of a decision **process** than a **rule**?) But sure, LTS is a promise to provide critical fixes, so this might be one of them.

MACHIN3 commented

2020-08-25 14:16:27 +02:00

@lichtwerk I'm not sure either so I appreciate the input. The addon throws and exception when rendering in the compositor, the fix is easy and done already. So why not bring it to LTS, considering it will be in use for the next 2+ years.

I'm also not sure where the resistance to this is coming from.

"You must be aware that your add-on will be integrated into the official Blender distribution. Therefor you must ensure there is continuous support for keeping your add-on working and fixing bugs as they appear. So you must commit yourself (or find a maintainer who does it for you) to do the maintenance"

@lichtwerk I'm not sure either so I appreciate the input. The addon throws and exception when rendering in the compositor, the fix is easy and done already. So why not bring it to LTS, considering it will be in use for the next 2+ years. I'm also not sure where the resistance to this is coming from. > "You must be aware that your add-on will be integrated into the official Blender distribution. Therefor you must ensure there is continuous support for keeping your add-on working and fixing bugs as they appear. So you must commit yourself (or find a maintainer who does it for you) to do the maintenance"

Eugenio Pignataro commented

2020-08-25 14:26:46 +02:00

Hi everybody!

I prefer that they remove the addon from the repository.
I will continue use my addons locally.

I want to avoid this type of discussion, I don't have the time or the desire.

Thanks !!!

Hi everybody! I prefer that they remove the addon from the repository. I will continue use my addons locally. I want to avoid this type of discussion, I don't have the time or the desire. Thanks !!!

Philipp Oeser commented

2020-08-25 14:33:07 +02:00

@EugenioPignataro : I remember LTS should not be a burden for devs, so lets just check if we can backport this and leave you out of the extra-work? Would that calm the waters?

Chris Kohl commented

2020-08-27 02:41:46 +02:00

Added subscriber: @ckohl_art

Raimund Klink commented

2020-09-07 14:51:54 +02:00

Added subscriber: @Raimund58

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Oscurart Tool exception when rendering without scene camera (compositor) #78651