Grease Pencil - A corrupt Sculpt > Push brush is created when undoing a mode change #79003

Open
opened 2020-07-16 20:42:11 +02:00 by Tomasz Kaye · 9 comments

System Information
Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits
Graphics card: NVIDIA GeForce GT 650M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-14.0.32 355.11.11.10.10.143

Blender Version
Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-07-02 22:21, hash: 5a13f682ee

Short description of error
A corrupt Push brush is created when I undo a Draw -> Sculpt mode change.

Exact steps for others to reproduce the error

  • File > New > 2D animation
  • Change from draw to sculpt mode
    image.png
  • Edit > Undo (the mode changes back to draw mode)
  • Change again to sculpt mode as before
  • A new corrupt Push brush has appeared called F Push (instead of F Push Stroke), and is selected. It has no thumbnail. It is missing the usual UI elements of the Push brush, like strength. See screenshot.
    Screenshot 2020-07-16 at 20.34.57.png
**System Information** Operating system: Darwin-19.5.0-x86_64-i386-64bit 64 Bits Graphics card: NVIDIA GeForce GT 650M OpenGL Engine NVIDIA Corporation 4.1 NVIDIA-14.0.32 355.11.11.10.10.143 **Blender Version** Broken: version: 2.90.0 Alpha, branch: master, commit date: 2020-07-02 22:21, hash: `5a13f682ee` **Short description of error** A corrupt Push brush is created when I undo a Draw -> Sculpt mode change. **Exact steps for others to reproduce the error** * File > New > 2D animation * Change from draw to sculpt mode ![image.png](https://archive.blender.org/developer/F8699894/image.png) * Edit > Undo (the mode changes back to draw mode) * Change again to sculpt mode as before * A new corrupt Push brush has appeared called F Push (instead of F Push Stroke), and is selected. It has no thumbnail. It is missing the usual UI elements of the Push brush, like strength. See screenshot. ![Screenshot 2020-07-16 at 20.34.57.png](https://archive.blender.org/developer/F8699901/Screenshot_2020-07-16_at_20.34.57.png)
Author

Added subscriber: @info-27

Added subscriber: @info-27

#75780 was marked as duplicate of this issue

#75780 was marked as duplicate of this issue

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @antoniov

Added subscriber: @antoniov
Antonio Vazquez self-assigned this 2020-07-17 16:35:41 +02:00

This is due the Undo of the settings of the brushes. The first time you change to Sculpt mode, the brushes are reset, but when you undo, the mode is undo, but also the brushes. This bug is only the first time you Undo. As soon you cannot undo the first change, it works.

I'm going to try to tag in some way the reset to avoid this situation.

This is due the Undo of the settings of the brushes. The first time you change to Sculpt mode, the brushes are reset, but when you undo, the mode is undo, but also the brushes. This bug is only the first time you Undo. As soon you cannot undo the first change, it works. I'm going to try to tag in some way the reset to avoid this situation.
Antonio Vazquez removed their assignment 2020-07-18 10:11:32 +02:00

Added subscriber: @ideasman42

Added subscriber: @ideasman42

@ideasman42 Could you help me with this? Actually, when you enter in Sculpt mode, the brushes are checked and if something is missing, the brushes are created. Also, in the versioning of the template, the brushes are set. The problem is when Undo, the brush in the tool gets wrong.

I have been looking at the function gpencil_sculptmode_toggle_exec, and I call to the reset and to BKE_paint_brush_set to set the right brush, but for any reason the brush is not set.

@ideasman42 Could you help me with this? Actually, when you enter in Sculpt mode, the brushes are checked and if something is missing, the brushes are created. Also, in the versioning of the template, the brushes are set. The problem is when Undo, the brush in the tool gets wrong. I have been looking at the function `gpencil_sculptmode_toggle_exec`, and I call to the reset and to `BKE_paint_brush_set` to set the right brush, but for any reason the brush is not set.

Added subscribers: @tbrimbo, @lemairecarl, @Pineapple, @lichtwerk

Added subscribers: @tbrimbo, @lemairecarl, @Pineapple, @lichtwerk

For those who have this problem, there is a simple workaround: click Reset All Brushes (as suggested before by Antonio Vazquez)
preview-image.png

For those who have this problem, there is a simple workaround: click Reset All Brushes (as suggested before by Antonio Vazquez) ![preview-image.png](https://archive.blender.org/developer/F8704392/preview-image.png)
Philipp Oeser removed the
Interest
Grease Pencil
label 2023-02-09 15:19:47 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#79003
No description provided.